Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows][x64] compareexchangedouble.cmd fails #129

Closed
jashook opened this issue Nov 19, 2019 · 6 comments · Fixed by #2310
Closed

[Windows][x64] compareexchangedouble.cmd fails #129

jashook opened this issue Nov 19, 2019 · 6 comments · Fixed by #2310
Labels
area-TieredCompilation-coreclr disabled-test The test is disabled in source code against the issue
Milestone

Comments

@jashook
Copy link
Contributor

jashook commented Nov 19, 2019


Assert failure(PID 2664 [0x00000a68], Thread: 3612 [0x0e1c]): pMethodDesc->GetCallCounter()->IsCallCountingEnabled(pMethodDesc)

CORECLR! TieredCompilationManager::OnMethodCodeVersionCalledSubsequently + 0x65 (0x00007ffd`84ed5a09)
CORECLR! CallCounter::OnMethodCodeVersionCalledSubsequently + 0x16A (0x00007ffd`84ed3e52)
CORECLR! CodeVersionManager::PublishVersionableCodeIfNecessary + 0x42F (0x00007ffd`84c3ebcb)
CORECLR! MethodDesc::DoPrestub + 0x8A9 (0x00007ffd`84ad390d)
CORECLR! PreStubWorker + 0x592 (0x00007ffd`84adc9d2)
CORECLR! ThePreStub + 0x55 (0x00007ffd`84d6d0e5)
<no module>! <no symbol> + 0x0 (0x00007ffd`255c9a01)
<no module>! <no symbol> + 0x0 (0x0000021c`00019ca8)
    File: F:\workspace.4\_work\1\s\src\coreclr\src\vm\tieredcompilation.cpp Line: 187
    Image: C:\dotnetbuild\work\79307fb0-a531-4878-872c-89038d00d99e\Payload\CoreRun.exe


Return code:      1
Raw output file:      C:\dotnetbuild\work\79307fb0-a531-4878-872c-89038d00d99e\Work\6095937b-f538-49d4-8993-920994f02aa4\Exec\baseservices\threading\Reports\baseservices.threading\interlocked\compareexchange\compareexchangedouble\compareexchangedouble.output.txt
Raw output:
BEGIN EXECUTION
 "C:\dotnetbuild\work\79307fb0-a531-4878-872c-89038d00d99e\Payload\corerun.exe" compareexchangedouble.dll /loops:100 /addVal:1.79769313486232E+304 
Expected: 100
Actual: -1073740286
END EXECUTION - FAILED
FAILED
Test Harness Exitcode is : 1
To run the test:
> set CORE_ROOT=C:\dotnetbuild\work\79307fb0-a531-4878-872c-89038d00d99e\Payload
> C:\dotnetbuild\work\79307fb0-a531-4878-872c-89038d00d99e\Work\6095937b-f538-49d4-8993-920994f02aa4\Exec\baseservices\threading\interlocked\compareexchange\compareexchangedouble\compareexchangedouble.cmd

https://dev.azure.com/dnceng/public/_build/results?buildId=430774&view=logs

Note this looks like it started this week, unless it is non-deterministic.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI untriaged New issue has not been triaged by the area owner labels Nov 19, 2019
@jashook jashook added area-VM-coreclr and removed area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Nov 19, 2019
@jashook
Copy link
Contributor Author

jashook commented Nov 19, 2019

Will open a pr to disable the test to get outerloop green.

@jashook
Copy link
Contributor Author

jashook commented Nov 19, 2019

/cc @kouvel

jashook pushed a commit that referenced this issue Nov 19, 2019
@ViktorHofer ViktorHofer added disabled-test The test is disabled in source code against the issue and removed untriaged New issue has not been triaged by the area owner labels Nov 20, 2019
@ViktorHofer
Copy link
Member

@jashook added the "disabled-test" label.

@jeffschwMSFT jeffschwMSFT added this to the 5.0 milestone Jan 8, 2020
@jkotas
Copy link
Member

jkotas commented Jan 15, 2020

This looks like non-deterministic failure. It was hit by JIT.Methodical test (unclear which one) in #1727

@kouvel
Copy link
Member

kouvel commented Jan 28, 2020

Fixed by #1457. When the JIT switches to optimized code for a method that contains a loop, the method's tier is updated after the native code slot is updated. There was a race where a parallel thread calling the same method would read the native code slot but not see the tier change, and thinks it needs to be counted.

@kouvel kouvel closed this as completed Jan 28, 2020
@kouvel
Copy link
Member

kouvel commented Jan 28, 2020

Need to enable the test, reopening

@kouvel kouvel reopened this Jan 28, 2020
kouvel added a commit to kouvel/runtime that referenced this issue Jan 28, 2020
stephentoub pushed a commit that referenced this issue Jan 29, 2020
This reverts commit 3a2dc0f.

Fixed by #1457. Closes #129.
jkotas added a commit that referenced this issue Feb 1, 2020
* Revert "Revert "Disable test based on #129 (#130)" (#2310)"

This reverts commit 427cd91.

* Revert "Fail FuncEval if slot backpatching lock is held by any thread (#2380)"

This reverts commit fc06054.

* Revert "Improve call counting mechanism (#1457)"

This reverts commit 3a457cb.
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-TieredCompilation-coreclr disabled-test The test is disabled in source code against the issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants