EnsureValidDataType should reject whitespaces in DataTypeAttribute.CustomDataType property

[sparraguerra]

Method EnsureValidDataType() should not raise an exception when the property CustomDataType is a WhiteSpace?

This code:

/// <summary>
///  Throws an exception if this attribute is not correctly formed
/// </summary>
/// <exception cref="InvalidOperationException"> is thrown if the current attribute is ill-formed.</exception>
private void EnsureValidDataType()
{
    if (DataType == DataType.Custom && string.IsNullOrEmpty(CustomDataType))
    {
         throw new InvalidOperationException(string.Format(CultureInfo.CurrentCulture,
               SR.DataTypeAttribute_EmptyDataTypeString));
     }
}

Should be?

/// <summary>
///  Throws an exception if this attribute is not correctly formed
/// </summary>
/// <exception cref="InvalidOperationException"> is thrown if the current attribute is ill-formed.</exception>
private void EnsureValidDataType()
{
    if (DataType == DataType.Custom && string.IsNullOrWhiteSpace(CustomDataType))
    {
         throw new InvalidOperationException(string.Format(CultureInfo.CurrentCulture,
               SR.DataTypeAttribute_EmptyDataTypeString));
     }
}

[karelz]

Sounds reasonable, can you submit a PR?

BTW: Sorry for the overdue answer :( ... we are catching up now.

[divega]

@karelz was this fixed?

[karelz]

Not yet - the PR was against wrong branch (future) - see dotnet/corefx#14654 for more details
@sparraguerra can you please submit your changes against master branch? Very sorry for the inconvenience ... I should have caught the wrong branch earlier :(

[ajcvickers]

Marking this for triage since there is now a behavior difference between .NET Core and .NET Framework and we need to re-evaluate if this is okay given our current understanding.

See dotnet/corefx#17874