Follow-Up: Issue-URL Cleanup

[deeprobin]

Follow-up 2023 for #63902

As discussed in mentioned issue, I periodically review the issue comments in the current codebase.
To avoid confusion here, weshould of course remove these occurences when the related issue is resolved.

@jeffhandley Should we do this like we did last year? Just create issues for all points?
Would you take a quick look over and see if something could be taken out of here?

New

• The Dependency resolver should select the most compatible [Patch] version instead of only the exact 'requested' version #3093

File docs/design/features/additional-deps.md (File Position 221-266)

runtime/docs/design/features/additional-deps.md

Lines 3 to 7 in f21a266

	## Summary
	This document describes current (2.0) and proposed (2.1) behavior for "light-up" scenarios regarding additional-deps functionality. The proposed behavior resolves the following issues:
	https://github.com/dotnet/runtime/issues/3093

• Latest DependencyModel writes / as \u0002f breaks all but bleeding edge versions of xunit + dotnet test #3678

File src/libraries/Microsoft.Extensions.DependencyModel/src/DependencyContextWriter.cs (File Position 641-686)

runtime/src/libraries/Microsoft.Extensions.DependencyModel/src/DependencyContextWriter.cs

Lines 19 to 23 in f21a266

	ThrowHelper.ThrowIfNull(stream);
	// Custom encoder is required to fix https://github.com/dotnet/runtime/issues/3678
	// Since the JSON is only written to a file that is read by the SDK (and not transmitted over the wire),
	// it is safe to skip escaping certain characters in this scenario

• File src/libraries/Microsoft.Extensions.DependencyModel/tests/DependencyContextJsonWriterTests.cs (File Position 9033-9078)

runtime/src/libraries/Microsoft.Extensions.DependencyModel/tests/DependencyContextJsonWriterTests.cs

Lines 189 to 193 in f21a266

	"PackageName",
	"1.2.3",
	"HASH+/==", // verify that '+' and '/' is not getting escaped to workaround bug in older xunit https://github.com/dotnet/runtime/issues/3678
	new [] {"Banana.dll"},
	new [] {

• RyuJIT generates redundant code when inlining string.IsNullOrEmpty #4207

File src/libraries/System.Private.CoreLib/src/System/Text/Unicode/Utf8Utility.Helpers.cs (File Position 12599-12645)

runtime/src/libraries/System.Private.CoreLib/src/System/Text/Unicode/Utf8Utility.Helpers.cs

Lines 244 to 248 in f21a266

	// Big-endian: Given [ AAAA #### ], return whether AAAA is in range [ 0000..007F ].
	// Return statement is written this way to work around https://github.com/dotnet/runtime/issues/4207.
	return (BitConverter.IsLittleEndian && (value & 0xFF80u) == 0)

• Remove generic type limitation around collectible assemblies #4731

File src/libraries/System.Collections.Immutable/src/System/Collections/Immutable/AllocFreeConcurrentStack.cs (File Position 2575-2621)

runtime/src/libraries/System.Collections.Immutable/src/System/Collections/Immutable/AllocFreeConcurrentStack.cs

Lines 77 to 81 in f21a266

	internal static class AllocFreeConcurrentStack
	{
	// Workaround for https://github.com/dotnet/runtime/issues/4731.
	[ThreadStatic]
	internal static Dictionary<Type, object>? t_stacks;

• [ARM64] Performance regression: Utf8Encoding #41699
  • 2022: Original issue was reopened
  • Comment still exists ...

File src/libraries/System.Private.CoreLib/src/System/Text/Unicode/Utf16Utility.Validation.cs (File Position 3262-3308)

runtime/src/libraries/System.Private.CoreLib/src/System/Text/Unicode/Utf16Utility.Validation.cs

Lines 60 to 64 in f21a266

	char* pEndOfInputBuffer = pInputBuffer + (uint)inputLength;
	// Per https://github.com/dotnet/runtime/issues/41699, temporarily disabling
	// ARM64-intrinsicified code paths. ARM64 platforms may still use the vectorized
	// non-intrinsicified 'else' block below.

• System.Reflection.MetadataLoadContext doesn't support function pointer types #43791

File src/tasks/WasmAppBuilder/PInvokeTableGenerator.cs (File Position 7634-7680)

runtime/src/tasks/WasmAppBuilder/PInvokeTableGenerator.cs

Lines 202 to 206 in f21a266

	// FIXME: System.Reflection.MetadataLoadContext can't decode function pointer types
	// https://github.com/dotnet/runtime/issues/43791
	private static bool TryIsMethodGetParametersUnsupported(MethodInfo method, [NotNullWhen(true)] out string? reason)
	{

• https://github.com/dotnet/runtime/issues/44072

File src/tests/tracing/eventpipe/diagnosticport/diagnosticport.cs (File Position 9323-9369)

runtime/src/tests/tracing/eventpipe/diagnosticport/diagnosticport.cs

Lines 214 to 218 in f21a266

	}
	// workaround for https://github.com/dotnet/runtime/issues/44072 which happens because the
	// above provider only sends 2 events and that can cause EventPipeEventSource (from TraceEvent)
	// to not dispatch the events if the EventBlock is a size not divisible by 8 (the reading alignment in TraceEvent).

• [wasm][aot] build tries to cross compile unrelated dlls from the publish folder #46856

File src/libraries/System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/System.Diagnostics.FileVersionInfo.Tests.csproj (File Position 2303-2349)

runtime/src/libraries/System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/System.Diagnostics.FileVersionInfo.Tests.csproj

Lines 43 to 47 in f21a266

	<ItemGroup>
	<!-- Include the test assembly as Content. We don't do this on Browser to work around
	https://github.com/dotnet/runtime/issues/46856 that would proceed to treat Content as an assembly reference anyway.
	Works around: Found identical vfs mappings for target path: System.Diagnostics.FileVersionInfo.TestAssembly.dll, source file: .../System.Diagnostics.FileVersionInfo.TestAssembly.dll. Ignoring. -->
	<ProjectReference Include="..\System.Diagnostics.FileVersionInfo.TestAssembly\System.Diagnostics.FileVersionInfo.TestAssembly.csproj" Condition="'$(TargetOS)' != 'browser'">

• Bug in System.IO.Compression.Inflater or the native zlib dependency - invalid distance too far back. #50235

File src/libraries/System.Net.WebSockets/tests/WebSocketDeflateTests.cs (File Position 22234-22281)

runtime/src/libraries/System.Net.WebSockets/tests/WebSocketDeflateTests.cs

Lines 511 to 515 in f21a266

	{
	// When running Autobahn Test Suite some tests failed with zlib error "invalid distance too far back".
	// Further investigation lead to a bug fix in zlib intel's implementation - https://github.com/dotnet/runtime/issues/50235.
	// This test replicates one of the Autobahn tests to make sure this issue doesn't appear again.
	byte[][] messages = new[]

• A delegate object is created for each IOptionsMonitor<T>.Get call #61086

File src/libraries/Microsoft.Extensions.Options/tests/Microsoft.Extensions.Options.Tests/OptionsMonitorTest.cs (File Position 18079-18125)

runtime/src/libraries/Microsoft.Extensions.Options/tests/Microsoft.Extensions.Options.Tests/OptionsMonitorTest.cs

Lines 470 to 474 in f21a266

	#if NET // need GC.GetAllocatedBytesForCurrentThread()
	/// <summary>
	/// Tests the fix for https://github.com/dotnet/runtime/issues/61086
	/// </summary>
	[Fact]

• Unnecessary LdelemaRef call not elided with Volatile.Read #65789

File src/libraries/System.Collections.Concurrent/src/System/Collections/Concurrent/ConcurrentDictionary.cs (File Position 105461-105508)

runtime/src/libraries/System.Collections.Concurrent/src/System/Collections/Concurrent/ConcurrentDictionary.cs

Lines 2191 to 2195 in f21a266

	private struct VolatileNode
	{
	// Workaround for https://github.com/dotnet/runtime/issues/65789.
	// If we had a Node?[] array, to safely read from the array we'd need to do Volatile.Read(ref array[i]),
	// but that triggers an unnecessary ldelema, which in turn results in a call to CastHelpers.LdelemaRef.

• Publish NativeAOT compiler with NativeAOT #67742

File src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj (File Position 259-305)

runtime/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

Lines 8 to 12 in f21a266

	<!-- BEGIN: Workaround for https://github.com/dotnet/runtime/issues/67742 -->
	<PropertyGroup Condition="'$(BuildingInsideVisualStudio)' != 'true'">
	<PublishDir>$(RuntimeBinDir)ilc-published/</PublishDir>

• required and GenerateReferenceAssemblySource #71559

File src/libraries/System.Net.Quic/src/System.Net.Quic.csproj (File Position 3689-3735)

runtime/src/libraries/System.Net.Quic/src/System.Net.Quic.csproj

Lines 41 to 45 in f21a266

	<ItemGroup Condition="'$(TargetPlatformIdentifier)' == ''">
	<Compile Include="System\Net\Quic\*.Unsupported.cs" />
	<!-- [ActiveIssue("https://github.com/dotnet/runtime/issues/71559")]: PNSE generator cannot handle required keyword, so excluding affected classes in ExcludeApiList.PNSE.txt and including real code for now. -->
	<Compile Include="System\Net\Quic\QuicListenerOptions.cs" />
	<Compile Include="System\Net\Quic\QuicConnectionOptions.cs" />

File src/libraries/System.Private.CoreLib/src/System/Collections/Generic/ValueListBuilder.cs (File Position 1220-1266)

runtime/src/libraries/System.Private.CoreLib/src/System/Collections/Generic/ValueListBuilder.cs

Lines 46 to 50 in f21a266

	int pos = _pos;
	// Workaround for https://github.com/dotnet/runtime/issues/72004
	Span<T> span = _span;
	if ((uint)pos < (uint)span.Length)

• IOException running NuGet-Migrations during tests in dotnet CLI first run #80619

File src/mono/wasm/Wasm.Build.Tests/data/RunScriptTemplate.sh (File Position 62-108)

runtime/src/mono/wasm/Wasm.Build.Tests/data/RunScriptTemplate.sh

Lines 1 to 5 in f21a266

	#!/usr/bin/env bash
	# create dummy console app to workaround https://github.com/dotnet/runtime/issues/80619
	(CONSOLE_TEMP_DIR="$(mktemp -d)"; "$DOTNET_ROOT/dotnet" new console -o "$CONSOLE_TEMP_DIR"; rm -rf "$CONSOLE_TEMP_DIR") || true

• Unnecessary Trim analysis warnings for internal static fields of a RequiresUnreferencedCode class #81864

File src/libraries/Microsoft.Extensions.Configuration.Xml/src/XmlStreamConfigurationProvider.cs (File Position 747-793)

runtime/src/libraries/Microsoft.Extensions.Configuration.Xml/src/XmlStreamConfigurationProvider.cs

Lines 19 to 23 in f21a266

	public class XmlStreamConfigurationProvider : StreamConfigurationProvider
	{
	// work around https://github.com/dotnet/runtime/issues/81864 by splitting this into a separate class.
	internal static class Consts
	{

File src/libraries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/XmlDecryptionTransform.cs (File Position 1185-1231)

runtime/src/libraries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/XmlDecryptionTransform.cs

Lines 24 to 28 in f21a266

	private XmlNamespaceManager? _nsm;
	// work around https://github.com/dotnet/runtime/issues/81864 by splitting this into a separate class.
	internal static class Consts
	{

File src/libraries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/XmlLicenseTransform.cs (File Position 796-842)

runtime/src/libraries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/XmlLicenseTransform.cs

Lines 18 to 22 in f21a266

	private IRelDecryptor? _relDecryptor;
	// work around https://github.com/dotnet/runtime/issues/81864 by splitting these into a separate class.
	internal static class Consts
	{

• Make non-file URL support optional in XmlUrlResolver #83495

File src/coreclr/tools/aot/AotCompilerCommon.props (File Position 350-396)

runtime/src/coreclr/tools/aot/AotCompilerCommon.props

Lines 8 to 12 in f21a266

	<ItemGroup>
	<!-- Replace this line with the documented property once https://github.com/dotnet/runtime/issues/83495 is fixed -->
	<RuntimeHostConfigurationOption Include="System.Xml.XmlResolver.IsNetworkingEnabledByDefault"
	Value="false"

Handled before

• [RyuJIT] Expression a % 0 sometimes generates incorrect code. #7141
  • Follow-up issue 2022: Remove % 0 workaround in Microsoft.VisualBasic.CompilerServices #65230
  • No changes planned
    File src/libraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/CompilerServices/Operators.vb (File Position 225458-225503)

runtime/src/libraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/CompilerServices/Operators.vb

Lines 4592 to 4596 in f21a266

	End Function
	<MethodImpl(MethodImplOptions.NoInlining)> ' To work around https://github.com/dotnet/runtime/issues/7141
	Private Shared Function ModSByte(ByVal left As SByte, ByVal right As SByte) As Object
	Return left Mod right

• Performance Regression: GetCustomAttributes() Allocations Increased from netcoreapp2.1 #11637
  • From 2022: Comment documents reasoning. No follow-up necessary.

File src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeCustomAttributeData.cs (File Position 59646-59692)

runtime/src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeCustomAttributeData.cs

Lines 1331 to 1335 in f21a266

	{
	// Resolve method ctor token found in decorated decoratedModule scope
	// See https://github.com/dotnet/runtime/issues/11637 for why we fast-path non-generics here (fewer allocations)
	if (attributeType.IsGenericType)
	{

• EnsureValidDataType should reject whitespaces in DataTypeAttribute.CustomDataType property #15690
  • From 2022: Comment documents reasoning. No follow-up necessary.

File src/libraries/System.ComponentModel.Annotations/tests/System/ComponentModel/DataAnnotations/DataTypeAttributeTests.cs (File Position 3236-3283)

runtime/src/libraries/System.ComponentModel.Annotations/tests/System/ComponentModel/DataAnnotations/DataTypeAttributeTests.cs

Lines 72 to 76 in f21a266

	// .NET Core fixed a bug where whitespace strings were allowed as CustomDataType.
	// See https://github.com/dotnet/runtime/issues/15690.
	yield return new object[] { " ", PlatformDetection.IsNetFramework };
	}

• Add a clean way to cancel a long-running Socket operation (e.g. accept or connect) #16236
  • From 2022: Comment documents reasoning. No follow-up necessary.

File src/mono/mono/utils/mono-threads-windows.c (File Position 4766-4813)

runtime/src/mono/mono/utils/mono-threads-windows.c

Lines 111 to 115 in f21a266

	// same resource that was part of the cancelation. Current implementation of
	// .NET Framework and .NET Core currently don't support the ability to abort a thread
	// blocked on sync IO calls, see https://github.com/dotnet/runtime/issues/16236.
	// Since there is no solution covering all scenarios aborting blocking syscall this
	// will be on best effort and there might still be a slight risk that the blocking call

• Add IsolatedStorageFile factory methods with Evidence dependencies #18208
  • Follow-up 2022: Review workaround for IsolatedStorageFile dependency on System.Security.Policy.Evidence #65930
  • No changes planned

File src/libraries/System.IO.IsolatedStorage/src/System/IO/IsolatedStorage/IsolatedStorageFile.NonMobile.cs (File Position 1064-1110)

runtime/src/libraries/System.IO.IsolatedStorage/src/System/IO/IsolatedStorage/IsolatedStorageFile.NonMobile.cs

Lines 24 to 28 in f21a266

	internal IsolatedStorageFile(IsolatedStorageScope scope)
	{
	// Evidence isn't currently available: https://github.com/dotnet/runtime/issues/18208
	// public static IsolatedStorageFile GetStore(IsolatedStorageScope scope, Evidence domainEvidence, Type domainEvidenceType, Evidence assemblyEvidence, Type assemblyEvidenceType) { return default(IsolatedStorageFile); }

• Add IsolatedStorageFile.GetEnumerator() #18209
  • Follow-up 2022: Review workaround for IsolatedStorageFile dependency on System.Security.Policy.Evidence #65930
  • No changes planned

File src/libraries/System.IO.IsolatedStorage/src/System/IO/IsolatedStorage/IsolatedStorageFile.cs (File Position 13300-13346)

runtime/src/libraries/System.IO.IsolatedStorage/src/System/IO/IsolatedStorage/IsolatedStorageFile.cs

Lines 375 to 379 in f21a266

	public static IEnumerator GetEnumerator(IsolatedStorageScope scope)
	{
	// Not currently supported: https://github.com/dotnet/runtime/issues/18209
	// Implementing this would require serializing/deserializing identity objects which is particularly

• ParameterInfo.HasDefaultValue throws System.FormatException on optional DateTime parameter #18844
  • Follow-up 2022: Remove ParameterInfo.HasDefaultValue workaround #65233
  • No changed planned (netstandard)

File src/libraries/Common/src/Extensions/ParameterDefaultValue/ParameterDefaultValue.netstandard.cs (File Position 685-731)

runtime/src/libraries/Common/src/Extensions/ParameterDefaultValue/ParameterDefaultValue.netstandard.cs

Lines 18 to 22 in f21a266

	catch (FormatException) when (parameter.ParameterType == typeof(DateTime))
	{
	// Workaround for https://github.com/dotnet/runtime/issues/18844
	// If HasDefaultValue throws FormatException for DateTime
	// we expect it to have default value

• Tuple.IStructuralComparable/Equatable throws NRE #19265
  • 2022: Comment documents reasoning. No follow-up necessary.

File src/libraries/System.Runtime/tests/System/TupleTests.cs (File Position 11829-11875)

runtime/src/libraries/System.Runtime/tests/System/TupleTests.cs

Lines 218 to 222 in f21a266

	{
	// This was not fixed in order to be compatible with the .NET Framework and Xamarin.
	// See https://github.com/dotnet/runtime/issues/19265
	IStructuralEquatable equatable = (IStructuralEquatable)Tuple;
	Assert.Throws<NullReferenceException>(() => equatable.Equals(Tuple, null));

• ValueTuple.IStructuralComparable/Equatable throws NRE instead of ArgumentNullException #19275
  • 2022: Comment documents reasoning. No follow-up necessary.

File src/libraries/System.ValueTuple/tests/ValueTupleTests.cs (File Position 12672-12718)

runtime/src/libraries/System.ValueTuple/tests/ValueTupleTests.cs

Lines 223 to 227 in f21a266

	{
	// This was not fixed in order to be compatible with the .NET Framework and Xamarin.
	// https://github.com/dotnet/runtime/issues/19275
	IStructuralEquatable equatable = (IStructuralEquatable)valueTuple;
	if (valueTuple is ValueTuple)

• Console.ReadLine() is blocked in Linux even though the StandardInput of the process has been disposed #19277
  • 2022: Comment documents reasoning. No follow-up necessary.

File src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs (File Position 18743-18790)

runtime/src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs

Lines 401 to 405 in f21a266

	public void TestEOFReceivedWhenStdInClosed()
	{
	// This is the test for the fix of https://github.com/dotnet/runtime/issues/19277.
	//
	// Summary of the issue:

• Vector3GetHashCodeTest AV'ing on Windows release #20080
  • 2022: Comment documents reasoning. No follow-up necessary.

File src/tests/JIT/SIMD/Vector3GetHash.cs (File Position 379-425)

runtime/src/tests/JIT/SIMD/Vector3GetHash.cs

Lines 5 to 9 in f21a266

	// It exposed a bug in morph, in which a SIMD field was being morphed in
	// a MACK_Ind context, even though it was under a GT_IND(G_ADDR()).
	// This was https://github.com/dotnet/runtime/issues/20080, and was "fixed" with
	// https://github.com/dotnet/coreclr/pull/9496 and a new issue,
	// https://github.com/dotnet/runtime/issues/7405, has been filed to track the underlying unexpected

• System.ServiceProcess.Tests.ServiceBaseTests.TestOnStartThenStop failed in CI #23247
  • 2022: Comment documents reasoning. No follow-up necessary.

File src/libraries/System.ServiceProcess.ServiceController/tests/System.ServiceProcess.ServiceController.TestService/TestServiceInstaller.cs (File Position 7332-7378)

runtime/src/libraries/System.ServiceProcess.ServiceController/tests/System.ServiceProcess.ServiceController.TestService/TestServiceInstaller.cs

Lines 153 to 157 in f21a266

	{
	// The Service exists at this point, but OpenService is failing, possibly because its being invoked concurrently for another service.
	// https://github.com/dotnet/runtime/issues/23247
	if (svc.Status != ServiceControllerStatus.Stopped)
	{

• Unix file enumerator isn't thread safe #24295
  • 2022: Comment documents reasoning. No follow-up necessary.

File src/libraries/System.IO.FileSystem/tests/Directory/EnumerableTests.cs (File Position 586-633)

runtime/src/libraries/System.IO.FileSystem/tests/Directory/EnumerableTests.cs

Lines 14 to 18 in f21a266

	// we don't guarantee thread safety of enumerators in general, but on Windows we
	// currently are thread safe, and this test will help ensure that if we change that
	// it's a conscious decision. Discussed in https://github.com/dotnet/runtime/issues/24295.
	[PlatformSpecific(TestPlatforms.Windows)]
	public void FileEnumeratorIsThreadSafe()

• System.Configuration.ConfigurationManager SettingElement Null Reference Exception #25369
  • 2022: Comment documents reasoning. No follow-up necessary.

File src/libraries/System.Configuration.ConfigurationManager/tests/System/Configuration/SettingElementTests.cs (File Position 1871-1917)

runtime/src/libraries/System.Configuration.ConfigurationManager/tests/System/Configuration/SettingElementTests.cs

Lines 53 to 57 in f21a266

	}
	[SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework, ".NET Framework does not have the fix for https://github.com/dotnet/runtime/issues/25369")]
	[Fact]
	public void DefaultConstructorEqualHashCodes()

• BeginConnect_EndPoint_AddressFamily_Throws_NotSupported test fails deterministically on netfx on RS4 #26062
  • 2022: Comment documents reasoning. No follow-up necessary.

File src/libraries/System.Net.Sockets/tests/FunctionalTests/ArgumentValidationTests.cs (File Position 39444-39490)

runtime/src/libraries/System.Net.Sockets/tests/FunctionalTests/ArgumentValidationTests.cs

Lines 916 to 920 in f21a266

	{
	// Unlike other tests that reuse a static Socket instance, this test avoids doing so
	// to work around a behavior of .NET 4.7.2. See https://github.com/dotnet/runtime/issues/26062
	// for more details.

• XmlReader.Create throws IndexOutOfRangeException #28615
  • 2022: Comment documents reasoning. No follow-up necessary.

File src/libraries/System.Private.Xml/tests/XmlReader/Tests/ReaderEncodingTests.cs (File Position 351-397)

runtime/src/libraries/System.Private.Xml/tests/XmlReader/Tests/ReaderEncodingTests.cs

Lines 8 to 12 in f21a266

	{
	/// <summary>
	/// This class is not completely testing XmlReader Encoding, it has a regression tests for the fix of the issue: https://github.com/dotnet/runtime/issues/28615
	/// which reported due to fuzzy testing. Defect happening while encoding byte array, which includes a surrogate char and an invalid char.
	/// </summary>

• Possible NRE in BinaryFormatterWriter.WriteObject( ... ) method #31402
  • 2022: The issue was closed as won't-fix
  • 2022: PR to update the comment: Update stale comments that reference GitHub issues #65932

File src/libraries/System.Runtime.Serialization.Formatters/src/System/Runtime/Serialization/Formatters/Binary/BinaryFormatterWriter.cs (File Position 5050-5096)

runtime/src/libraries/System.Runtime.Serialization.Formatters/src/System/Runtime/Serialization/Formatters/Binary/BinaryFormatterWriter.cs

Lines 118 to 122 in f21a266

	int objectId = (int)nameInfo._objectId;
	Debug.Assert(typeNameInfo != null); // Explicitly called with null. Potential bug, but closed as Won't Fix: https://github.com/dotnet/runtime/issues/31402
	string? objectName = objectId < 0 ?
	typeNameInfo.NIname : // Nested Object

• Bad IBC data causing official build failures #33303
  • 2022 Follow-up: Review workaround for bad IBC data causing official build failures on macOS #65933

File eng/codeOptimization.targets (File Position 731-777)

runtime/eng/codeOptimization.targets

Lines 8 to 12 in f21a266

	across many of our assemblies on Mac, so disable
	IBCMerge optimizations on Mac for now to unblock the official build.
	See issue https://github.com/dotnet/runtime/issues/33303
	-->
	<IsEligibleForNgenOptimization Condition="'$(TargetOS)' == 'osx' or '$(TargetsMobile)' == 'true'">false</IsEligibleForNgenOptimization>

• GCC warns when compiling the JIT: too small to hold all values of regNumber #33541
  • Comment documents reasoning. No follow-up necessary.

File src/coreclr/jit/CMakeLists.txt (File Position 388-434)

runtime/src/coreclr/jit/CMakeLists.txt

Lines 7 to 11 in f21a266

	# Since there is no better / specific suppression available for these core warnings, we disable
	# warn-as-error (-Werror) for JIT in this case. This issue has been fixed in gcc 11.
	# See https://github.com/dotnet/runtime/issues/33541
	if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS 11.0)
	add_compile_options(-Wno-error)

• Define and implement behavior of tracing functionality when EventSource is disabled via a feature switch #43657
  • Follow-Up Issue 2022: Reconsider tracing functionality when EventSource is disabled #65570

File src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/NativeRuntimeEventSource.cs (File Position 3243-3289)

runtime/src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/NativeRuntimeEventSource.cs

Lines 45 to 49 in f21a266

	{
	// A simple fix to avoid dependencies brought by this method if event source is disabled via a feature switch.
	// Should be reconsidered when https://github.com/dotnet/runtime/issues/43657 is done.
	if (!IsSupported)
	{

[deeprobin]

/area:Meta

[ghost]

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Follow-up 2023 for #63902

As discussed in mentioned issue, I periodically review the issue comments in the current codebase.
To avoid confusion here, weshould of course remove these occurences when the related issue is resolved.

@jeffhandley Should we do this like we did last year? Just create issues for all points?
Would you take a quick look over and see if something could be taken out of here?

Closedi ssues results

• The Dependency resolver should select the most compatible [Patch] version instead of only the exact 'requested' version #3093

File docs/design/features/additional-deps.md (File Position 221-266)

runtime/docs/design/features/additional-deps.md

Lines 3 to 7 in f21a266

	## Summary
	This document describes current (2.0) and proposed (2.1) behavior for "light-up" scenarios regarding additional-deps functionality. The proposed behavior resolves the following issues:
	https://github.com/dotnet/runtime/issues/3093

• Latest DependencyModel writes / as \u0002f breaks all but bleeding edge versions of xunit + dotnet test #3678

File src/libraries/Microsoft.Extensions.DependencyModel/src/DependencyContextWriter.cs (File Position 641-686)

runtime/src/libraries/Microsoft.Extensions.DependencyModel/src/DependencyContextWriter.cs

Lines 19 to 23 in f21a266

	ThrowHelper.ThrowIfNull(stream);
	// Custom encoder is required to fix https://github.com/dotnet/runtime/issues/3678
	// Since the JSON is only written to a file that is read by the SDK (and not transmitted over the wire),
	// it is safe to skip escaping certain characters in this scenario

File src/libraries/Microsoft.Extensions.DependencyModel/tests/DependencyContextJsonWriterTests.cs (File Position 9033-9078)

runtime/src/libraries/Microsoft.Extensions.DependencyModel/tests/DependencyContextJsonWriterTests.cs

Lines 189 to 193 in f21a266

	"PackageName",
	"1.2.3",
	"HASH+/==", // verify that '+' and '/' is not getting escaped to workaround bug in older xunit https://github.com/dotnet/runtime/issues/3678
	new [] {"Banana.dll"},
	new [] {

• RyuJIT generates redundant code when inlining string.IsNullOrEmpty #4207

File src/libraries/System.Private.CoreLib/src/System/Text/Unicode/Utf8Utility.Helpers.cs (File Position 12599-12645)

runtime/src/libraries/System.Private.CoreLib/src/System/Text/Unicode/Utf8Utility.Helpers.cs

Lines 244 to 248 in f21a266

	// Big-endian: Given [ AAAA #### ], return whether AAAA is in range [ 0000..007F ].
	// Return statement is written this way to work around https://github.com/dotnet/runtime/issues/4207.
	return (BitConverter.IsLittleEndian && (value & 0xFF80u) == 0)

• Remove generic type limitation around collectible assemblies #4731

File src/libraries/System.Collections.Immutable/src/System/Collections/Immutable/AllocFreeConcurrentStack.cs (File Position 2575-2621)

runtime/src/libraries/System.Collections.Immutable/src/System/Collections/Immutable/AllocFreeConcurrentStack.cs

Lines 77 to 81 in f21a266

	internal static class AllocFreeConcurrentStack
	{
	// Workaround for https://github.com/dotnet/runtime/issues/4731.
	[ThreadStatic]
	internal static Dictionary<Type, object>? t_stacks;

• [RyuJIT] Expression a % 0 sometimes generates incorrect code. #7141

File src/libraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/CompilerServices/Operators.vb (File Position 225458-225503)

runtime/src/libraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/CompilerServices/Operators.vb

Lines 4592 to 4596 in f21a266

	End Function
	<MethodImpl(MethodImplOptions.NoInlining)> ' To work around https://github.com/dotnet/runtime/issues/7141
	Private Shared Function ModSByte(ByVal left As SByte, ByVal right As SByte) As Object
	Return left Mod right

• Performance Regression: GetCustomAttributes() Allocations Increased from netcoreapp2.1 #11637

File src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeCustomAttributeData.cs (File Position 59646-59692)

runtime/src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeCustomAttributeData.cs

Lines 1331 to 1335 in f21a266

	{
	// Resolve method ctor token found in decorated decoratedModule scope
	// See https://github.com/dotnet/runtime/issues/11637 for why we fast-path non-generics here (fewer allocations)
	if (attributeType.IsGenericType)
	{

• EnsureValidDataType should reject whitespaces in DataTypeAttribute.CustomDataType property #15690

File src/libraries/System.ComponentModel.Annotations/tests/System/ComponentModel/DataAnnotations/DataTypeAttributeTests.cs (File Position 3236-3283)

runtime/src/libraries/System.ComponentModel.Annotations/tests/System/ComponentModel/DataAnnotations/DataTypeAttributeTests.cs

Lines 72 to 76 in f21a266

	// .NET Core fixed a bug where whitespace strings were allowed as CustomDataType.
	// See https://github.com/dotnet/runtime/issues/15690.
	yield return new object[] { " ", PlatformDetection.IsNetFramework };
	}

• Add a clean way to cancel a long-running Socket operation (e.g. accept or connect) #16236

File src/mono/mono/utils/mono-threads-windows.c (File Position 4766-4813)

runtime/src/mono/mono/utils/mono-threads-windows.c

Lines 111 to 115 in f21a266

	// same resource that was part of the cancelation. Current implementation of
	// .NET Framework and .NET Core currently don't support the ability to abort a thread
	// blocked on sync IO calls, see https://github.com/dotnet/runtime/issues/16236.
	// Since there is no solution covering all scenarios aborting blocking syscall this
	// will be on best effort and there might still be a slight risk that the blocking call

• Add IsolatedStorageFile factory methods with Evidence dependencies #18208

File src/libraries/System.IO.IsolatedStorage/src/System/IO/IsolatedStorage/IsolatedStorageFile.NonMobile.cs (File Position 1064-1110)

runtime/src/libraries/System.IO.IsolatedStorage/src/System/IO/IsolatedStorage/IsolatedStorageFile.NonMobile.cs

Lines 24 to 28 in f21a266

	internal IsolatedStorageFile(IsolatedStorageScope scope)
	{
	// Evidence isn't currently available: https://github.com/dotnet/runtime/issues/18208
	// public static IsolatedStorageFile GetStore(IsolatedStorageScope scope, Evidence domainEvidence, Type domainEvidenceType, Evidence assemblyEvidence, Type assemblyEvidenceType) { return default(IsolatedStorageFile); }

• Add IsolatedStorageFile.GetEnumerator() #18209

File src/libraries/System.IO.IsolatedStorage/src/System/IO/IsolatedStorage/IsolatedStorageFile.cs (File Position 13300-13346)

runtime/src/libraries/System.IO.IsolatedStorage/src/System/IO/IsolatedStorage/IsolatedStorageFile.cs

Lines 375 to 379 in f21a266

	public static IEnumerator GetEnumerator(IsolatedStorageScope scope)
	{
	// Not currently supported: https://github.com/dotnet/runtime/issues/18209
	// Implementing this would require serializing/deserializing identity objects which is particularly

• ParameterInfo.HasDefaultValue throws System.FormatException on optional DateTime parameter #18844

File src/libraries/Common/src/Extensions/ParameterDefaultValue/ParameterDefaultValue.netstandard.cs (File Position 685-731)

runtime/src/libraries/Common/src/Extensions/ParameterDefaultValue/ParameterDefaultValue.netstandard.cs

Lines 18 to 22 in f21a266

	catch (FormatException) when (parameter.ParameterType == typeof(DateTime))
	{
	// Workaround for https://github.com/dotnet/runtime/issues/18844
	// If HasDefaultValue throws FormatException for DateTime
	// we expect it to have default value

• Tuple.IStructuralComparable/Equatable throws NRE #19265

File src/libraries/System.Runtime/tests/System/TupleTests.cs (File Position 11829-11875)

runtime/src/libraries/System.Runtime/tests/System/TupleTests.cs

Lines 218 to 222 in f21a266

	{
	// This was not fixed in order to be compatible with the .NET Framework and Xamarin.
	// See https://github.com/dotnet/runtime/issues/19265
	IStructuralEquatable equatable = (IStructuralEquatable)Tuple;
	Assert.Throws<NullReferenceException>(() => equatable.Equals(Tuple, null));

• ValueTuple.IStructuralComparable/Equatable throws NRE instead of ArgumentNullException #19275

File src/libraries/System.ValueTuple/tests/ValueTupleTests.cs (File Position 12672-12718)

runtime/src/libraries/System.ValueTuple/tests/ValueTupleTests.cs

Lines 223 to 227 in f21a266

	{
	// This was not fixed in order to be compatible with the .NET Framework and Xamarin.
	// https://github.com/dotnet/runtime/issues/19275
	IStructuralEquatable equatable = (IStructuralEquatable)valueTuple;
	if (valueTuple is ValueTuple)

• Console.ReadLine() is blocked in Linux even though the StandardInput of the process has been disposed #19277

File src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs (File Position 18743-18790)

runtime/src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs

Lines 401 to 405 in f21a266

	public void TestEOFReceivedWhenStdInClosed()
	{
	// This is the test for the fix of https://github.com/dotnet/runtime/issues/19277.
	//
	// Summary of the issue:

• Vector3GetHashCodeTest AV'ing on Windows release #20080

File src/tests/JIT/SIMD/Vector3GetHash.cs (File Position 379-425)

runtime/src/tests/JIT/SIMD/Vector3GetHash.cs

Lines 5 to 9 in f21a266

	// It exposed a bug in morph, in which a SIMD field was being morphed in
	// a MACK_Ind context, even though it was under a GT_IND(G_ADDR()).
	// This was https://github.com/dotnet/runtime/issues/20080, and was "fixed" with
	// https://github.com/dotnet/coreclr/pull/9496 and a new issue,
	// https://github.com/dotnet/runtime/issues/7405, has been filed to track the underlying unexpected

• System.ServiceProcess.Tests.ServiceBaseTests.TestOnStartThenStop failed in CI #23247

File src/libraries/System.ServiceProcess.ServiceController/tests/System.ServiceProcess.ServiceController.TestService/TestServiceInstaller.cs (File Position 7332-7378)

runtime/src/libraries/System.ServiceProcess.ServiceController/tests/System.ServiceProcess.ServiceController.TestService/TestServiceInstaller.cs

Lines 153 to 157 in f21a266

	{
	// The Service exists at this point, but OpenService is failing, possibly because its being invoked concurrently for another service.
	// https://github.com/dotnet/runtime/issues/23247
	if (svc.Status != ServiceControllerStatus.Stopped)
	{

• Unix file enumerator isn't thread safe #24295

File src/libraries/System.IO.FileSystem/tests/Directory/EnumerableTests.cs (File Position 586-633)

runtime/src/libraries/System.IO.FileSystem/tests/Directory/EnumerableTests.cs

Lines 14 to 18 in f21a266

	// we don't guarantee thread safety of enumerators in general, but on Windows we
	// currently are thread safe, and this test will help ensure that if we change that
	// it's a conscious decision. Discussed in https://github.com/dotnet/runtime/issues/24295.
	[PlatformSpecific(TestPlatforms.Windows)]
	public void FileEnumeratorIsThreadSafe()

• System.Configuration.ConfigurationManager SettingElement Null Reference Exception #25369

File src/libraries/System.Configuration.ConfigurationManager/tests/System/Configuration/SettingElementTests.cs (File Position 1871-1917)

runtime/src/libraries/System.Configuration.ConfigurationManager/tests/System/Configuration/SettingElementTests.cs

Lines 53 to 57 in f21a266

	}
	[SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework, ".NET Framework does not have the fix for https://github.com/dotnet/runtime/issues/25369")]
	[Fact]
	public void DefaultConstructorEqualHashCodes()

• BeginConnect_EndPoint_AddressFamily_Throws_NotSupported test fails deterministically on netfx on RS4 #26062

File src/libraries/System.Net.Sockets/tests/FunctionalTests/ArgumentValidationTests.cs (File Position 39444-39490)

runtime/src/libraries/System.Net.Sockets/tests/FunctionalTests/ArgumentValidationTests.cs

Lines 916 to 920 in f21a266

	{
	// Unlike other tests that reuse a static Socket instance, this test avoids doing so
	// to work around a behavior of .NET 4.7.2. See https://github.com/dotnet/runtime/issues/26062
	// for more details.

• XmlReader.Create throws IndexOutOfRangeException #28615

File src/libraries/System.Private.Xml/tests/XmlReader/Tests/ReaderEncodingTests.cs (File Position 351-397)

runtime/src/libraries/System.Private.Xml/tests/XmlReader/Tests/ReaderEncodingTests.cs

Lines 8 to 12 in f21a266

	{
	/// <summary>
	/// This class is not completely testing XmlReader Encoding, it has a regression tests for the fix of the issue: https://github.com/dotnet/runtime/issues/28615
	/// which reported due to fuzzy testing. Defect happening while encoding byte array, which includes a surrogate char and an invalid char.
	/// </summary>

• Possible NRE in BinaryFormatterWriter.WriteObject( ... ) method #31402

File src/libraries/System.Runtime.Serialization.Formatters/src/System/Runtime/Serialization/Formatters/Binary/BinaryFormatterWriter.cs (File Position 5050-5096)

runtime/src/libraries/System.Runtime.Serialization.Formatters/src/System/Runtime/Serialization/Formatters/Binary/BinaryFormatterWriter.cs

Lines 118 to 122 in f21a266

	int objectId = (int)nameInfo._objectId;
	Debug.Assert(typeNameInfo != null); // Explicitly called with null. Potential bug, but closed as Won't Fix: https://github.com/dotnet/runtime/issues/31402
	string? objectName = objectId < 0 ?
	typeNameInfo.NIname : // Nested Object

• Bad IBC data causing official build failures #33303

File eng/codeOptimization.targets (File Position 731-777)

runtime/eng/codeOptimization.targets

Lines 8 to 12 in f21a266

	across many of our assemblies on Mac, so disable
	IBCMerge optimizations on Mac for now to unblock the official build.
	See issue https://github.com/dotnet/runtime/issues/33303
	-->
	<IsEligibleForNgenOptimization Condition="'$(TargetOS)' == 'osx' or '$(TargetsMobile)' == 'true'">false</IsEligibleForNgenOptimization>

• GCC warns when compiling the JIT: too small to hold all values of regNumber #33541

File src/coreclr/jit/CMakeLists.txt (File Position 388-434)

runtime/src/coreclr/jit/CMakeLists.txt

Lines 7 to 11 in f21a266

	# Since there is no better / specific suppression available for these core warnings, we disable
	# warn-as-error (-Werror) for JIT in this case. This issue has been fixed in gcc 11.
	# See https://github.com/dotnet/runtime/issues/33541
	if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS 11.0)
	add_compile_options(-Wno-error)

• [ARM64] Performance regression: Utf8Encoding #41699

File src/libraries/System.Private.CoreLib/src/System/Text/Unicode/Utf16Utility.Validation.cs (File Position 3262-3308)

runtime/src/libraries/System.Private.CoreLib/src/System/Text/Unicode/Utf16Utility.Validation.cs

Lines 60 to 64 in f21a266

	char* pEndOfInputBuffer = pInputBuffer + (uint)inputLength;
	// Per https://github.com/dotnet/runtime/issues/41699, temporarily disabling
	// ARM64-intrinsicified code paths. ARM64 platforms may still use the vectorized
	// non-intrinsicified 'else' block below.

• Define and implement behavior of tracing functionality when EventSource is disabled via a feature switch #43657

File src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/NativeRuntimeEventSource.cs (File Position 3243-3289)

runtime/src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/NativeRuntimeEventSource.cs

Lines 45 to 49 in f21a266

	{
	// A simple fix to avoid dependencies brought by this method if event source is disabled via a feature switch.
	// Should be reconsidered when https://github.com/dotnet/runtime/issues/43657 is done.
	if (!IsSupported)
	{

• System.Reflection.MetadataLoadContext doesn't support function pointer types #43791

File src/tasks/WasmAppBuilder/PInvokeTableGenerator.cs (File Position 7634-7680)

runtime/src/tasks/WasmAppBuilder/PInvokeTableGenerator.cs

Lines 202 to 206 in f21a266

	// FIXME: System.Reflection.MetadataLoadContext can't decode function pointer types
	// https://github.com/dotnet/runtime/issues/43791
	private static bool TryIsMethodGetParametersUnsupported(MethodInfo method, [NotNullWhen(true)] out string? reason)
	{

• https://github.com/dotnet/runtime/issues/44072

File src/tests/tracing/eventpipe/diagnosticport/diagnosticport.cs (File Position 9323-9369)

runtime/src/tests/tracing/eventpipe/diagnosticport/diagnosticport.cs

Lines 214 to 218 in f21a266

	}
	// workaround for https://github.com/dotnet/runtime/issues/44072 which happens because the
	// above provider only sends 2 events and that can cause EventPipeEventSource (from TraceEvent)
	// to not dispatch the events if the EventBlock is a size not divisible by 8 (the reading alignment in TraceEvent).

• [wasm][aot] build tries to cross compile unrelated dlls from the publish folder #46856

File src/libraries/System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/System.Diagnostics.FileVersionInfo.Tests.csproj (File Position 2303-2349)

runtime/src/libraries/System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/System.Diagnostics.FileVersionInfo.Tests.csproj

Lines 43 to 47 in f21a266

	<ItemGroup>
	<!-- Include the test assembly as Content. We don't do this on Browser to work around
	https://github.com/dotnet/runtime/issues/46856 that would proceed to treat Content as an assembly reference anyway.
	Works around: Found identical vfs mappings for target path: System.Diagnostics.FileVersionInfo.TestAssembly.dll, source file: .../System.Diagnostics.FileVersionInfo.TestAssembly.dll. Ignoring. -->
	<ProjectReference Include="..\System.Diagnostics.FileVersionInfo.TestAssembly\System.Diagnostics.FileVersionInfo.TestAssembly.csproj" Condition="'$(TargetOS)' != 'browser'">

• Bug in System.IO.Compression.Inflater or the native zlib dependency - invalid distance too far back. #50235

File src/libraries/System.Net.WebSockets/tests/WebSocketDeflateTests.cs (File Position 22234-22281)

runtime/src/libraries/System.Net.WebSockets/tests/WebSocketDeflateTests.cs

Lines 511 to 515 in f21a266

	{
	// When running Autobahn Test Suite some tests failed with zlib error "invalid distance too far back".
	// Further investigation lead to a bug fix in zlib intel's implementation - https://github.com/dotnet/runtime/issues/50235.
	// This test replicates one of the Autobahn tests to make sure this issue doesn't appear again.
	byte[][] messages = new[]

• A delegate object is created for each IOptionsMonitor<T>.Get call #61086

File src/libraries/Microsoft.Extensions.Options/tests/Microsoft.Extensions.Options.Tests/OptionsMonitorTest.cs (File Position 18079-18125)

runtime/src/libraries/Microsoft.Extensions.Options/tests/Microsoft.Extensions.Options.Tests/OptionsMonitorTest.cs

Lines 470 to 474 in f21a266

	#if NET // need GC.GetAllocatedBytesForCurrentThread()
	/// <summary>
	/// Tests the fix for https://github.com/dotnet/runtime/issues/61086
	/// </summary>
	[Fact]

• Unnecessary LdelemaRef call not elided with Volatile.Read #65789

File src/libraries/System.Collections.Concurrent/src/System/Collections/Concurrent/ConcurrentDictionary.cs (File Position 105461-105508)

runtime/src/libraries/System.Collections.Concurrent/src/System/Collections/Concurrent/ConcurrentDictionary.cs

Lines 2191 to 2195 in f21a266

	private struct VolatileNode
	{
	// Workaround for https://github.com/dotnet/runtime/issues/65789.
	// If we had a Node?[] array, to safely read from the array we'd need to do Volatile.Read(ref array[i]),
	// but that triggers an unnecessary ldelema, which in turn results in a call to CastHelpers.LdelemaRef.

• Publish NativeAOT compiler with NativeAOT #67742

File src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj (File Position 259-305)

runtime/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj

Lines 8 to 12 in f21a266

	<!-- BEGIN: Workaround for https://github.com/dotnet/runtime/issues/67742 -->
	<PropertyGroup Condition="'$(BuildingInsideVisualStudio)' != 'true'">
	<PublishDir>$(RuntimeBinDir)ilc-published/</PublishDir>

• required and GenerateReferenceAssemblySource #71559

File src/libraries/System.Net.Quic/src/System.Net.Quic.csproj (File Position 3689-3735)

runtime/src/libraries/System.Net.Quic/src/System.Net.Quic.csproj

Lines 41 to 45 in f21a266

	<ItemGroup Condition="'$(TargetPlatformIdentifier)' == ''">
	<Compile Include="System\Net\Quic\*.Unsupported.cs" />
	<!-- [ActiveIssue("https://github.com/dotnet/runtime/issues/71559")]: PNSE generator cannot handle required keyword, so excluding affected classes in ExcludeApiList.PNSE.txt and including real code for now. -->
	<Compile Include="System\Net\Quic\QuicListenerOptions.cs" />
	<Compile Include="System\Net\Quic\QuicConnectionOptions.cs" />

File src/libraries/System.Private.CoreLib/src/System/Collections/Generic/ValueListBuilder.cs (File Position 1220-1266)

runtime/src/libraries/System.Private.CoreLib/src/System/Collections/Generic/ValueListBuilder.cs

Lines 46 to 50 in f21a266

	int pos = _pos;
	// Workaround for https://github.com/dotnet/runtime/issues/72004
	Span<T> span = _span;
	if ((uint)pos < (uint)span.Length)

• IOException running NuGet-Migrations during tests in dotnet CLI first run #80619

File src/mono/wasm/Wasm.Build.Tests/data/RunScriptTemplate.sh (File Position 62-108)

runtime/src/mono/wasm/Wasm.Build.Tests/data/RunScriptTemplate.sh

Lines 1 to 5 in f21a266

	#!/usr/bin/env bash
	# create dummy console app to workaround https://github.com/dotnet/runtime/issues/80619
	(CONSOLE_TEMP_DIR="$(mktemp -d)"; "$DOTNET_ROOT/dotnet" new console -o "$CONSOLE_TEMP_DIR"; rm -rf "$CONSOLE_TEMP_DIR") || true

• Unnecessary Trim analysis warnings for internal static fields of a RequiresUnreferencedCode class #81864

File src/libraries/Microsoft.Extensions.Configuration.Xml/src/XmlStreamConfigurationProvider.cs (File Position 747-793)

runtime/src/libraries/Microsoft.Extensions.Configuration.Xml/src/XmlStreamConfigurationProvider.cs

Lines 19 to 23 in f21a266

	public class XmlStreamConfigurationProvider : StreamConfigurationProvider
	{
	// work around https://github.com/dotnet/runtime/issues/81864 by splitting this into a separate class.
	internal static class Consts
	{

File src/libraries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/XmlDecryptionTransform.cs (File Position 1185-1231)

runtime/src/libraries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/XmlDecryptionTransform.cs

Lines 24 to 28 in f21a266

	private XmlNamespaceManager? _nsm;
	// work around https://github.com/dotnet/runtime/issues/81864 by splitting this into a separate class.
	internal static class Consts
	{

File src/libraries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/XmlLicenseTransform.cs (File Position 796-842)

runtime/src/libraries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/XmlLicenseTransform.cs

Lines 18 to 22 in f21a266

	private IRelDecryptor? _relDecryptor;
	// work around https://github.com/dotnet/runtime/issues/81864 by splitting these into a separate class.
	internal static class Consts
	{

• Make non-file URL support optional in XmlUrlResolver #83495

File src/coreclr/tools/aot/AotCompilerCommon.props (File Position 350-396)

runtime/src/coreclr/tools/aot/AotCompilerCommon.props

Lines 8 to 12 in f21a266

	<ItemGroup>
	<!-- Replace this line with the documented property once https://github.com/dotnet/runtime/issues/83495 is fixed -->
	<RuntimeHostConfigurationOption Include="System.Xml.XmlResolver.IsNetworkingEnabledByDefault"
	Value="false"

Author:	deeprobin
Assignees:	-
Labels:	area-Meta, untriaged
Milestone:	-