[wasm][aot] build tries to cross compile unrelated dlls from the publish folder #46856

mdh1418 · 2021-01-12T15:08:34Z

In effort to run library tests with AOT compilation on CI #46633, there are a number of failures arising from #46651.

Test suite System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/System.Diagnostics.FileVersionInfo.Tests.csproj fails on MonoAOTCompiler task with

/Users/mdhwang/runtime_wasm_clean/src/mono/wasm/build/WasmApp.targets(43,5): error : Can not open image /Users/mdhwang/runtime_wasm_clean/artifacts/bin/System.Diagnostics.FileVersionInfo.Tests/net6.0-Browser-Release/browser-wasm/publish/NativeLibrary.dll [/Users/mdhwang/runtime_wasm_clean/src/libraries/System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/System.Diagnostics.FileVersionInfo.Tests.csproj]
/Users/mdhwang/runtime_wasm_clean/src/mono/wasm/build/WasmApp.targets(43,5): error : Precompiling failed for /Users/mdhwang/runtime_wasm_clean/artifacts/bin/System.Diagnostics.FileVersionInfo.Tests/net6.0-Browser-Release/browser-wasm/publish/NativeLibrary.dll: Error: Can not open image /Users/mdhwang/runtime_wasm_clean/artifacts/bin/System.Diagnostics.FileVersionInfo.Tests/net6.0-Browser-Release/browser-wasm/publish/NativeLibrary.dll [/Users/mdhwang/runtime_wasm_clean/src/libraries/System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/System.Diagnostics.FileVersionInfo.Tests.csproj]
/Users/mdhwang/runtime_wasm_clean/src/mono/wasm/build/WasmApp.targets(43,5): error :  [/Users/mdhwang/runtime_wasm_clean/src/libraries/System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/System.Diagnostics.FileVersionInfo.Tests.csproj]
/Users/mdhwang/runtime_wasm_clean/src/mono/wasm/build/WasmApp.targets(43,5): error :  [/Users/mdhwang/runtime_wasm_clean/src/libraries/System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/System.Diagnostics.FileVersionInfo.Tests.csproj]

System_diagnostics_fileversioninfo_fail.txt

Repro

Check out changes in #46651
./build.sh -os Browser -arch wasm -c Release
Remove

runtime/eng/testing/ILLink.Descriptor.xunit.xml

Lines 15 to 20 in f7f5046

    
           <!-- Temporary until https://github.com/mono/linker/issues/1713 is resolved --> 
        
           <assembly fullname="Microsoft.DotNet.RemoteExecutor"> 
        
             <type fullname="Microsoft.DotNet.RemoteExecutor.Program"> 
        
               <method signature="System.Int32 Main(System.String[])" /> 
        
             </type> 
        
           </assembly>

Modify

runtime/src/libraries/System.Private.CoreLib/src/System/IO/FileStream.Unix.cs

Line 256 in 9538bee

catch (Exception e) when (IsIoRelatedException(e) && !disposing)

to be an empty catch

catch
{
}

./dotnet.sh build /t:Test /p:TargetOS=Browser /p:TargetArchitecture=wasm /p:Configuration=Release /p:EnableAggressiveTrimming=true /p:RunAOTCompilation=true src/libraries/System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/System.Diagnostics.FileVersionInfo.Tests.csproj

The text was updated successfully, but these errors were encountered:

ghost · 2021-01-12T15:08:37Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

In effort to run library tests with AOT compilation on CI #46633, there are a number of failures arising from #46651.

Test suite System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/System.Diagnostics.FileVersionInfo.Tests.csproj fails on MonoAOTCompiler task with

/Users/mdhwang/runtime_wasm_clean/src/mono/wasm/build/WasmApp.targets(43,5): error : Can not open image /Users/mdhwang/runtime_wasm_clean/artifacts/bin/System.Diagnostics.FileVersionInfo.Tests/net6.0-Browser-Release/browser-wasm/publish/NativeLibrary.dll [/Users/mdhwang/runtime_wasm_clean/src/libraries/System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/System.Diagnostics.FileVersionInfo.Tests.csproj]
/Users/mdhwang/runtime_wasm_clean/src/mono/wasm/build/WasmApp.targets(43,5): error : Precompiling failed for /Users/mdhwang/runtime_wasm_clean/artifacts/bin/System.Diagnostics.FileVersionInfo.Tests/net6.0-Browser-Release/browser-wasm/publish/NativeLibrary.dll: Error: Can not open image /Users/mdhwang/runtime_wasm_clean/artifacts/bin/System.Diagnostics.FileVersionInfo.Tests/net6.0-Browser-Release/browser-wasm/publish/NativeLibrary.dll [/Users/mdhwang/runtime_wasm_clean/src/libraries/System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/System.Diagnostics.FileVersionInfo.Tests.csproj]
/Users/mdhwang/runtime_wasm_clean/src/mono/wasm/build/WasmApp.targets(43,5): error :  [/Users/mdhwang/runtime_wasm_clean/src/libraries/System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/System.Diagnostics.FileVersionInfo.Tests.csproj]
/Users/mdhwang/runtime_wasm_clean/src/mono/wasm/build/WasmApp.targets(43,5): error :  [/Users/mdhwang/runtime_wasm_clean/src/libraries/System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/System.Diagnostics.FileVersionInfo.Tests.csproj]

System_diagnostics_fileversioninfo_fail.txt

Repro

Check out changes in #46651
./build.sh -os Browser -arch wasm -c Release
Remove

runtime/eng/testing/ILLink.Descriptor.xunit.xml

Lines 15 to 20 in f7f5046

    
           <!-- Temporary until https://github.com/mono/linker/issues/1713 is resolved --> 
        
           <assembly fullname="Microsoft.DotNet.RemoteExecutor"> 
        
             <type fullname="Microsoft.DotNet.RemoteExecutor.Program"> 
        
               <method signature="System.Int32 Main(System.String[])" /> 
        
             </type> 
        
           </assembly>

Modify

runtime/src/libraries/System.Private.CoreLib/src/System/IO/FileStream.Unix.cs

Line 256 in 9538bee

catch (Exception e) when (IsIoRelatedException(e) && !disposing)

to be an empty catch

catch
{
}

./dotnet.sh build /t:Test /p:TargetOS=Browser /p:TargetArchitecture=wasm /p:Configuration=Release /p:EnableAggressiveTrimming=true /p:RunAOTCompilation=true src/libraries/System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/System.Diagnostics.FileVersionInfo.Tests.csproj

Author:	mdh1418
Assignees:	-
Labels:	`arch-wasm`
Milestone:	-

ghost · 2021-01-12T15:08:40Z

Tagging subscribers to this area: @tommcdon, @krwq
See info in area-owners.md if you want to be subscribed.

Issue Details

In effort to run library tests with AOT compilation on CI #46633, there are a number of failures arising from #46651.

Test suite System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/System.Diagnostics.FileVersionInfo.Tests.csproj fails on MonoAOTCompiler task with

/Users/mdhwang/runtime_wasm_clean/src/mono/wasm/build/WasmApp.targets(43,5): error : Can not open image /Users/mdhwang/runtime_wasm_clean/artifacts/bin/System.Diagnostics.FileVersionInfo.Tests/net6.0-Browser-Release/browser-wasm/publish/NativeLibrary.dll [/Users/mdhwang/runtime_wasm_clean/src/libraries/System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/System.Diagnostics.FileVersionInfo.Tests.csproj]
/Users/mdhwang/runtime_wasm_clean/src/mono/wasm/build/WasmApp.targets(43,5): error : Precompiling failed for /Users/mdhwang/runtime_wasm_clean/artifacts/bin/System.Diagnostics.FileVersionInfo.Tests/net6.0-Browser-Release/browser-wasm/publish/NativeLibrary.dll: Error: Can not open image /Users/mdhwang/runtime_wasm_clean/artifacts/bin/System.Diagnostics.FileVersionInfo.Tests/net6.0-Browser-Release/browser-wasm/publish/NativeLibrary.dll [/Users/mdhwang/runtime_wasm_clean/src/libraries/System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/System.Diagnostics.FileVersionInfo.Tests.csproj]
/Users/mdhwang/runtime_wasm_clean/src/mono/wasm/build/WasmApp.targets(43,5): error :  [/Users/mdhwang/runtime_wasm_clean/src/libraries/System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/System.Diagnostics.FileVersionInfo.Tests.csproj]
/Users/mdhwang/runtime_wasm_clean/src/mono/wasm/build/WasmApp.targets(43,5): error :  [/Users/mdhwang/runtime_wasm_clean/src/libraries/System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/System.Diagnostics.FileVersionInfo.Tests.csproj]

System_diagnostics_fileversioninfo_fail.txt

Repro

Check out changes in #46651
./build.sh -os Browser -arch wasm -c Release
Remove

runtime/eng/testing/ILLink.Descriptor.xunit.xml

Lines 15 to 20 in f7f5046

    
           <!-- Temporary until https://github.com/mono/linker/issues/1713 is resolved --> 
        
           <assembly fullname="Microsoft.DotNet.RemoteExecutor"> 
        
             <type fullname="Microsoft.DotNet.RemoteExecutor.Program"> 
        
               <method signature="System.Int32 Main(System.String[])" /> 
        
             </type> 
        
           </assembly>

Modify

runtime/src/libraries/System.Private.CoreLib/src/System/IO/FileStream.Unix.cs

Line 256 in 9538bee

catch (Exception e) when (IsIoRelatedException(e) && !disposing)

to be an empty catch

catch
{
}

./dotnet.sh build /t:Test /p:TargetOS=Browser /p:TargetArchitecture=wasm /p:Configuration=Release /p:EnableAggressiveTrimming=true /p:RunAOTCompilation=true src/libraries/System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/System.Diagnostics.FileVersionInfo.Tests.csproj

Author:	mdh1418
Assignees:	-
Labels:	`arch-wasm`, `area-System.Diagnostics`, `untriaged`
Milestone:	-

radical · 2021-01-12T19:08:49Z

This depends on a native library, which is why MonoAOTCompiler fails with it. Are these tests supported, or should be supported on wasm? These were disabled in c72d522 .

What is the expected behavior?

ghost · 2021-01-25T23:40:11Z

Tagging subscribers to this area: @eiriktsarpalis
See info in area-owners.md if you want to be subscribed.

Issue Details

In effort to run library tests with AOT compilation on CI #46633, there are a number of failures arising from #46651.

Test suite System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/System.Diagnostics.FileVersionInfo.Tests.csproj fails on MonoAOTCompiler task with

/Users/mdhwang/runtime_wasm_clean/src/mono/wasm/build/WasmApp.targets(43,5): error : Can not open image /Users/mdhwang/runtime_wasm_clean/artifacts/bin/System.Diagnostics.FileVersionInfo.Tests/net6.0-Browser-Release/browser-wasm/publish/NativeLibrary.dll [/Users/mdhwang/runtime_wasm_clean/src/libraries/System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/System.Diagnostics.FileVersionInfo.Tests.csproj]
/Users/mdhwang/runtime_wasm_clean/src/mono/wasm/build/WasmApp.targets(43,5): error : Precompiling failed for /Users/mdhwang/runtime_wasm_clean/artifacts/bin/System.Diagnostics.FileVersionInfo.Tests/net6.0-Browser-Release/browser-wasm/publish/NativeLibrary.dll: Error: Can not open image /Users/mdhwang/runtime_wasm_clean/artifacts/bin/System.Diagnostics.FileVersionInfo.Tests/net6.0-Browser-Release/browser-wasm/publish/NativeLibrary.dll [/Users/mdhwang/runtime_wasm_clean/src/libraries/System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/System.Diagnostics.FileVersionInfo.Tests.csproj]
/Users/mdhwang/runtime_wasm_clean/src/mono/wasm/build/WasmApp.targets(43,5): error :  [/Users/mdhwang/runtime_wasm_clean/src/libraries/System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/System.Diagnostics.FileVersionInfo.Tests.csproj]
/Users/mdhwang/runtime_wasm_clean/src/mono/wasm/build/WasmApp.targets(43,5): error :  [/Users/mdhwang/runtime_wasm_clean/src/libraries/System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/System.Diagnostics.FileVersionInfo.Tests.csproj]

System_diagnostics_fileversioninfo_fail.txt

Repro

Check out changes in #46651
./build.sh -os Browser -arch wasm -c Release
Remove

runtime/eng/testing/ILLink.Descriptor.xunit.xml

Lines 15 to 20 in f7f5046

    
           <!-- Temporary until https://github.com/mono/linker/issues/1713 is resolved --> 
        
           <assembly fullname="Microsoft.DotNet.RemoteExecutor"> 
        
             <type fullname="Microsoft.DotNet.RemoteExecutor.Program"> 
        
               <method signature="System.Int32 Main(System.String[])" /> 
        
             </type> 
        
           </assembly>

Modify

runtime/src/libraries/System.Private.CoreLib/src/System/IO/FileStream.Unix.cs

Line 256 in 9538bee

catch (Exception e) when (IsIoRelatedException(e) && !disposing)

to be an empty catch

catch
{
}

./dotnet.sh build /t:Test /p:TargetOS=Browser /p:TargetArchitecture=wasm /p:Configuration=Release /p:EnableAggressiveTrimming=true /p:RunAOTCompilation=true src/libraries/System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/System.Diagnostics.FileVersionInfo.Tests.csproj

Author:	mdh1418
Assignees:	-
Labels:	`arch-wasm`, `area-System.Diagnostics`, `area-System.Diagnostics.Process`
Milestone:	6.0.0

lambdageek · 2021-05-18T17:56:52Z

The problem is that NativeLibrary.dll is a win32 dll, not a .NET assembly. So when we pass it to MonoAOTCompiler, it can't open it and fails.

We should either:

change the Content line in this test file to include some metadata that will tell the build infrastructure not to pass this assembly to the AOT compiler, or
just skip this test

lambdageek · 2021-05-18T17:57:39Z

It also affects #52848. And probably ios device testing, too. basically anything that needs the AOT compiler

steveisok · 2021-05-21T00:58:27Z

In #52848 I defined a <NativeLibraries> itemgroup. That ends up being part of the items that are excluded from the aot compiler. If there's a better way, I'm all ears.

runtime/src/libraries/System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/System.Diagnostics.FileVersionInfo.Tests.csproj

Lines 22 to 26 in 227847c

    
           <ItemGroup Condition="'$(RunAOTCompilation)' == 'true'"> 
        
             <!-- Identifies native libraries that should be skipped during AOT --> 
        
             <NativeLibraries Include="NativeLibrary.dll" /> 
        
             <NativeLibraries Include="SecondNativeLibrary.dll" /> 
        
           </ItemGroup>

runtime/eng/testing/tests.mobile.targets

Lines 169 to 175 in 227847c

    
           <_AotExcludeAssemblies Include="$(PublishDir)System.Runtime.WindowsRuntime.dll" /> 
        
           <_AotExcludeAssemblies Include="@(NativeLibraries->'$(PublishDir)%(Identity)')" /> 
        
           <AotInputAssemblies Condition="'$(RunAOTCompilation)' == 'true'" Include="$(PublishDir)*.dll" Exclude="@(_AotExcludeAssemblies)"> 
        
             <AotArguments>@(MonoAOTCompilerDefaultAotArguments, ';')</AotArguments> 
        
             <ProcessArguments>@(MonoAOTCompilerDefaultProcessArguments, ';')</ProcessArguments> 
        
           </AotInputAssemblies>

lewing · 2021-07-31T19:31:07Z

@radical what is your plan here?

radical · 2021-08-01T00:10:47Z

Currently, we pick up all the files from the publish folder, where this assembly also ends up because it is in @(Content). I expect this to be fixed once we have the wasm targets taking the relevant list of referenced assemblies from earlier targets (eg. ResolveAssemblyReferences).

radical · 2021-09-08T17:14:08Z

This needs some more work (a bit involved) to integrate with Publish at a more granular level.

ilonatommy · 2022-06-14T07:06:10Z

@radical, any progress?

radical · 2022-06-14T15:42:08Z

@radical, any progress?

No. We should keep this for 7.0 milestone for now, but I'm not sure if we'll actually be able to get to it. This is dependent on better integration with publish.

radical · 2022-07-28T21:04:58Z

The original issue here - that of MonoAOTCompiler task trying to compile unmanaged dlls is fixed, as we skip those now.

runtime/src/tasks/AotCompilerTask/MonoAOTCompiler.cs

Lines 603 to 607 in d7c8bc1

    
           using PEReader reader = new(assemblyFile, PEStreamOptions.Default); 
        
           if (!reader.HasMetadata) 
        
           { 
        
               Log.LogMessage(MessageImportance.Low, $"Skipping unmanaged {assemblyPath} for AOT"); 
        
               continue;

The broader issue of handling publish assets better, is separate from this.

mdh1418 added the arch-wasm WebAssembly architecture label Jan 12, 2021

Dotnet-GitSync-Bot added area-System.Diagnostics untriaged New issue has not been triaged by the area owner labels Jan 12, 2021

lewing added this to the 6.0.0 milestone Jan 12, 2021

lewing removed the untriaged New issue has not been triaged by the area owner label Jan 12, 2021

radical changed the title ~~wasm AOT library test failure - Can not open image~~ [wasm] AOT: Native libraries with projects don't work Jan 12, 2021

noahfalk added the area-System.Diagnostics.Process label Jan 25, 2021

noahfalk removed the area-System.Diagnostics label Jan 25, 2021

lambdageek mentioned this issue May 18, 2021

Switch MacCatalyst interpreter runs to use AOT JustInterp #52848

Closed

lewing assigned radical Jun 18, 2021

radical changed the title ~~[wasm] AOT: Native libraries with projects don't work~~ [wasm][aot] build tries to cross compile unrelated dlls from the publish folder Jul 30, 2021

radical added area-Build-mono and removed area-System.Diagnostics.Process labels Jul 30, 2021

radical modified the milestones: 6.0.0, 7.0.0 Sep 8, 2021

lambdageek mentioned this issue Sep 20, 2021

BDN boilerplate project is not strong named for WASM AOT dotnet/performance#2026

Closed

radical mentioned this issue Jul 11, 2022

Rebucket tests that fail with NativeAOT and fix some #71819

Merged

radical closed this as completed Jul 28, 2022

ghost locked as resolved and limited conversation to collaborators Aug 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[wasm][aot] build tries to cross compile unrelated dlls from the publish folder #46856

[wasm][aot] build tries to cross compile unrelated dlls from the publish folder #46856

mdh1418 commented Jan 12, 2021

ghost commented Jan 12, 2021

Repro

ghost commented Jan 12, 2021

Repro

radical commented Jan 12, 2021

ghost commented Jan 25, 2021

Repro

lambdageek commented May 18, 2021

lambdageek commented May 18, 2021

steveisok commented May 21, 2021 •

edited

Loading

lewing commented Jul 31, 2021

radical commented Aug 1, 2021

radical commented Sep 8, 2021

ilonatommy commented Jun 14, 2022

radical commented Jun 14, 2022

radical commented Jul 28, 2022

[wasm][aot] build tries to cross compile unrelated dlls from the publish folder #46856

[wasm][aot] build tries to cross compile unrelated dlls from the publish folder #46856

Comments

mdh1418 commented Jan 12, 2021

Repro

ghost commented Jan 12, 2021

Repro

ghost commented Jan 12, 2021

Repro

radical commented Jan 12, 2021

ghost commented Jan 25, 2021

Repro

lambdageek commented May 18, 2021

lambdageek commented May 18, 2021

steveisok commented May 21, 2021 • edited Loading

lewing commented Jul 31, 2021

radical commented Aug 1, 2021

radical commented Sep 8, 2021

ilonatommy commented Jun 14, 2022

radical commented Jun 14, 2022

radical commented Jul 28, 2022

steveisok commented May 21, 2021 •

edited

Loading