-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebucket tests that fail with NativeAOT and fix some #71819
Conversation
Tagging subscribers to this area: @tommcdon Issue DetailsI went through the "These tests don't build" uber bucket - pretty much all of those tests do actually build fine.
Cc @dotnet/ilc-contrib
|
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
Cc @radical @radekdoulik on commit ceb7fd1. I had to hack around WasmApp.targets treating all *.dll files in the app (including The test in question has a |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
There are 1 failure each on Windows and Linux runs. I will disable these tests for now in tests.proj |
Currently, we are adding all the runtime/eng/testing/tests.wasm.targets Lines 253 to 254 in 3ac1629
And the content files are added for the VFS. Maybe we should remove those from |
Wasm failures are fixed by #71976, which was just merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for doing this and I will follow on the Linux failure separately
I went through the "These tests don't build" uber bucket - pretty much all of those tests do actually build fine.
Cc @dotnet/ilc-contrib