Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider tracing functionality when EventSource is disabled #65570

Open
deeprobin opened this issue Feb 18, 2022 · 0 comments
Open

Reconsider tracing functionality when EventSource is disabled #65570

deeprobin opened this issue Feb 18, 2022 · 0 comments

Comments

@deeprobin
Copy link
Contributor

deeprobin commented Feb 18, 2022

Follow-up issue for #43657


As described in #63902, it would be good to remove comments and workarounds that have already been fixed.

Would be great if someone would take another look at the following (and whether this can be removed or replaced with something better if necessary).

{
// A simple fix to avoid dependencies brought by this method if event source is disabled via a feature switch.
// Should be reconsidered when https://github.com/dotnet/runtime/issues/43657 is done.
if (!IsSupported)
{

/area System.Diagnostics.Tracing

@dotnet-issue-labeler dotnet-issue-labeler bot added area-Tracing-coreclr untriaged New issue has not been triaged by the area owner labels Feb 18, 2022
@tommcdon tommcdon added this to the Future milestone Feb 23, 2022
@tommcdon tommcdon removed the untriaged New issue has not been triaged by the area owner label Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants