Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "#if NET_NATIVE" to "#if uapaot" in S.P.DataContractSerialization #20131

Closed
shmao opened this issue Feb 7, 2017 · 6 comments
Closed
Labels
area-Serialization help wanted [up-for-grabs] Good issue for external contributors
Milestone

Comments

@shmao
Copy link
Contributor

shmao commented Feb 7, 2017

We need make changes to the following compilation directives,

  1. Remove USE_REFEMIT as we do not use it.
  2. Change NET_NATIVE to uapaot
@jkotas
Copy link
Member

jkotas commented Feb 7, 2017

We will also want to have AOT friendly builds for Console CoreRT apps. They are not called uapaot. I do not think it is a good idea to use #if uapaot for AOT friendly build.

Unless you can come up with a better, I think that NET_NATIVE is just fine.

@karelz
Copy link
Member

karelz commented Feb 7, 2017

cc @weshaggard

@weshaggard
Copy link
Member

We have been trying to root out all the NET_NATIVE defines (see https://github.com/dotnet/corefx/issues/5315) and update them to follow our guidelines https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/project-guidelines.md#define-naming-convention which are generally driven by the configuration they are unique to or a FEATURE if they are more tied to something not specific to a configuration. I didn't look too closely at the code in this case so I'm not sure which case it is but I would like to move away from NET_NATIVE.

@jkotas
Copy link
Member

jkotas commented Feb 7, 2017

FEATURE_FULL_AOT ?

@weshaggard
Copy link
Member

FEATURE_FULL_AOT would be fine if that is what best describes the code being ifdef'ed.

@shmao
Copy link
Contributor Author

shmao commented Apr 14, 2017

This was fixed by dotnet/corefx#16704

@shmao shmao closed this as completed Apr 14, 2017
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 2.0.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Serialization help wanted [up-for-grabs] Good issue for external contributors
Projects
None yet
Development

No branches or pull requests

5 participants