-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change "#if NET_NATIVE" to "#if uapaot" in S.P.DataContractSerialization #20131
Comments
We will also want to have AOT friendly builds for Console CoreRT apps. They are not called uapaot. I do not think it is a good idea to use Unless you can come up with a better, I think that |
cc @weshaggard |
We have been trying to root out all the NET_NATIVE defines (see https://github.com/dotnet/corefx/issues/5315) and update them to follow our guidelines https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/project-guidelines.md#define-naming-convention which are generally driven by the configuration they are unique to or a FEATURE if they are more tied to something not specific to a configuration. I didn't look too closely at the code in this case so I'm not sure which case it is but I would like to move away from NET_NATIVE. |
|
FEATURE_FULL_AOT would be fine if that is what best describes the code being ifdef'ed. |
This was fixed by dotnet/corefx#16704 |
We need make changes to the following compilation directives,
The text was updated successfully, but these errors were encountered: