Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused USE_REFEMIT define in System.Private.DataContractSerialization #41512

Closed
eerhardt opened this issue Aug 28, 2020 · 1 comment · Fixed by #41664
Closed

Remove unused USE_REFEMIT define in System.Private.DataContractSerialization #41512

eerhardt opened this issue Aug 28, 2020 · 1 comment · Fixed by #41664
Labels
area-Serialization

Comments

@eerhardt
Copy link
Member

#if USE_REFEMIT is used in a quite a few source files in DataContractSerialization, but it is never defined in a .csproj.

#20131 mentioned it should be removed as it is unused, but that issue was closed because the .NET Native piece of it was resolved, and this unused define was never removed.

We should remove it, so it doesn't continue cluttering up the code and causing confusion when changes need to be made in this area. (For example - #41476 (comment)).
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Aug 28, 2020
@eerhardt eerhardt mentioned this issue Aug 28, 2020
Merged
@seonyounggg
Copy link
Contributor

seonyounggg commented Aug 28, 2020 •
edited
Loading

Can I try to fix this issue?

This was referenced Aug 28, 2020
Closed
Merged
@HongGit HongGit removed the untriaged New issue has not been triaged by the area owner label Sep 1, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-Serialization
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unused USE_REFEMIT define in System.Private.DataContractSerialization
4 participants
@eerhardt @HongGit @Dotnet-GitSync-Bot @seonyounggg