-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Open
Labels
area-System.SecurityenhancementProduct code improvement that does NOT require public API changes/additionsProduct code improvement that does NOT require public API changes/additionsgood first issueIssue should be easy to implement, good for first-time contributorsIssue should be easy to implement, good for first-time contributorshelp wanted[up-for-grabs] Good issue for external contributors[up-for-grabs] Good issue for external contributorsin-prThere is an active PR which will close this issue when it is mergedThere is an active PR which will close this issue when it is mergedincrease-code-coverageTracking need to add more test and increase code coverage of a componentTracking need to add more test and increase code coverage of a component
Milestone
Description
Here are the main areas which need improvement:
-
SignedXml.CheckSignature(X509Certificate2 certificate, bool verifySignatureOnly)
- currently no coverage - sample code should be sufficient for now -
System.Security.Cryptography.Xml.XmlDecryptionTransform
- https://ci.dot.net/job/dotnet_corefx/job/master/job/code_coverage_windows/Code_Coverage_Report/System.Security.Cryptography.Xml_XmlDecryptionTransform.htm -
System.Security.Cryptography.Xml.SymmetricKeyWrap
- https://ci.dot.net/job/dotnet_corefx/job/master/job/code_coverage_windows/Code_Coverage_Report/System.Security.Cryptography.Xml_SymmetricKeyWrap.htm -
System.Security.Cryptography.Xml.KeyInfoClause
- https://ci.dot.net/job/dotnet_corefx/job/master/job/code_coverage_windows/Code_Coverage_Report/System.Security.Cryptography.Xml_KeyInfoClause.htm -
System.Security.Cryptography.Xml.EncryptedXml
- https://ci.dot.net/job/dotnet_corefx/job/master/job/code_coverage_windows/Code_Coverage_Report/System.Security.Cryptography.Xml_EncryptedXml.htm - only most common scenarios -
System.Security.Cryptography.Xml.EncryptionMethod
- https://ci.dot.net/job/dotnet_corefx/job/master/job/code_coverage_windows/Code_Coverage_Report/System.Security.Cryptography.Xml_EncryptionMethod.htm -
System.Security.Cryptography.Xml.CanonicalXmlEntityReference
- https://ci.dot.net/job/dotnet_corefx/job/master/job/code_coverage_windows/Code_Coverage_Report/System.Security.Cryptography.Xml_CanonicalXmlEntityReference.htm - at minimum one or two tests triggering use of this class
Guidelines:
- focus on writing tests which provide most value (rarely used scenarios can be targeted later)
- focus on public entry points
Copilot
Metadata
Metadata
Assignees
Labels
area-System.SecurityenhancementProduct code improvement that does NOT require public API changes/additionsProduct code improvement that does NOT require public API changes/additionsgood first issueIssue should be easy to implement, good for first-time contributorsIssue should be easy to implement, good for first-time contributorshelp wanted[up-for-grabs] Good issue for external contributors[up-for-grabs] Good issue for external contributorsin-prThere is an active PR which will close this issue when it is mergedThere is an active PR which will close this issue when it is mergedincrease-code-coverageTracking need to add more test and increase code coverage of a componentTracking need to add more test and increase code coverage of a component