Could not load file or assembly 'System.ValueTuple, Version=4.0.2.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' or one of its dependencies

[sandersaares]

1. Create a new .NET Framework 4.7.1 console app project.
2. Install BenchmarkDotNet NuGet package.
3. Observe that above resulted in <package id="System.ValueTuple" version="4.3.0" targetFramework="net471" /> in packages.config due to some dependency.
4. Paste the following code into Program.cs and excute the app.

using BenchmarkDotNet.Attributes;
using BenchmarkDotNet.Running;

namespace ConsoleApp3
{
    internal class Program
    {
        private static void Main(string[] args)
        {
            BenchmarkRunner.Run<Foo>();
        }
    }

    [ClrJob]
    public class Foo
    {
        [Benchmark]
        public void Bar()
        {

        }
    }
}

Expected result: app executes and performs some no-op benchmarks.

Actual result:

Unhandled Exception: System.IO.FileNotFoundException: Could not load file or assembly 'System.ValueTuple, Version=4.0.2.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' or one of its dependencies. The system cannot find the file specified. ---> System.IO.FileNotFoundException: Could not load file or assembly 'System.ValueTuple, Version=4.0.1.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' or one of its dependencies. The system cannot find the file specified.
   --- End of inner exception stack trace ---
   at BenchmarkDotNet.Running.BenchmarkConverter.GetParameterDefinitions(Type type)
   at BenchmarkDotNet.Running.BenchmarkConverter.MethodsToBenchmarksWithFullConfig(Type containingType, MethodInfo[] benchmarkMethods, ReadOnlyConfig fullConfig)
   at BenchmarkDotNet.Running.BenchmarkConverter.TypeToBenchmarks(Type type, IConfig config)
   at BenchmarkDotNet.Running.BenchmarkRunner.Run[T](IConfig config)
   at ConsoleApp3.Program.Main(String[] args) in C:\Source\ConsoleApp3\ConsoleApp3\Program.cs:line 15

I see the following automatically added to my app.config:

      <dependentAssembly>
        <assemblyIdentity name="System.ValueTuple" publicKeyToken="cc7b13ffcd2ddd51" culture="neutral" />
        <bindingRedirect oldVersion="0.0.0.0-4.0.2.0" newVersion="4.0.2.0" />
      </dependentAssembly>

I do not see ValueTuple in my bin directory.

[sandersaares]

If I upgrade NuGet packages to recent versions, it looks like the error goes away. Does this mean that 4.3.0 is not actually compatible with net471, despite getting installed? Does it mean the BenchmarkDotNet package owner should require a later one to work around this? What is the right way forward here, so installing the package will result in a successful runtime experience?

[karelz]

@joperezr is it a known issue?

[ViktorHofer]

cc @adamsitnik

[joperezr]

@sandersaares which version of VS are you using? do you mind sharing a msbuild.binlog of your build when the problem repros? In order to do this, run msbuild yourProject.csproj /t:rebuild /bl on a developer command prompt.

@joperezr is it a known issue?

This one is interesting as System.ValueTuple isn't one of the assemblies that we inject facades for when targeting 4.7.1. This looks a lot like the problem we fixed on 4.7.1 patch for ValueTuple where the unification table was wrong, but I don't think that this is the problem we are seeing here, since a binidng redirect was added, which seems to be the cause of the problem. the binlog should help understand why was that binding redirect generated.

[sandersaares]

I am using VS 15.8.6.

binlog.zip

[GSPP]

I'm tracking related issues and information in a list. They are related to System.Net.Http, System.Runtime, System.IO, System.ValueTuple, System.Buffers and others.

https://github.com/dotnet/corefx/issues/32587
https://github.com/dotnet/corefx/issues/32561
dotnet/standard#481
dotnet/standard#567
dotnet/standard#558
dotnet/standard#887
dotnet/standard#891
https://github.com/dotnet/corefx/issues/32610
https://github.com/dotnet/corefx/issues/30642
https://github.com/dotnet/corefx/issues/32757
dotnet/standard#895
dotnet/standard#877
dotnet/standard#521
dotnet/standard#295
dotnet/standard#476
dotnet/standard#184
dotnet/standard#936
dotnet/standard#941
https://github.com/dotnet/corefx/issues/33148
NuGet/Home#7440
https://github.com/dotnet/corefx/issues/31532
https://github.com/dotnet/corefx/issues/22781
https://github.com/dotnet/corefx/issues/23306
https://github.com/dotnet/corefx/issues/29622
https://github.com/dotnet/corefx/issues/9846
https://github.com/dotnet/corefx/issues/17522
https://github.com/dotnet/corefx/issues/25773

All of these have the same very few underlying issues.

.NET 4.7.2 helps with some but not all of these. You can look at my comments on some of these issues for some ideas on how to work around those problems. I also have a central list of ideas to try.

[joperezr]

Oh I see, this is a known issue with packages.config. What I think is going on here is that when you add one of your nuget package dependnecies, then the NuGet package manager is adding the binding redirect into your app.config. This is a bug since the NuGet package manager should never be emitting binding redirects as it doesn't have the full picture of all your references.

Can you try the exact same steps, but instead of adding the package depenendencies with VS, add them using <PackageReference ? Basically add the package reference by adding to your project the following:

<ItemGroup>
    <PackageReference Include="BenchmarkDotNet" Version="0.11.1" />
</ItemGroup>

I would expect that doing that should get rid of the error.

[sandersaares]

I confirm that adding a PackageReference successfully works around this defect.

Can you post a link to the mentioned NuGet issue report that I could watch?

[pavel-agarkov]

I had to manually put System.ValueTuple.dll into

C:\Windows\Microsoft.NET\assembly\GAC_MSIL\System.ValueTuple\v4.0_0.0.0.0__cc7b13ffcd2ddd51

in order for it to be automatically found in .Net 4.6.1 console app. No other recommendations helped.

[mayawarrier]

@pavel-agarkov Thanks, this is the only solution that worked.

I got the same error message with System.ValueTuple version 4.0.3.0. We're targeting .NET 4.7.2.

[chucklu]

I encounter this issue, and seems like the vs problem, and the nuget add the bindingRedirect automatically for me which make the build pass.
https://stackoverflow.com/questions/52859229/visual-studio-conflicts-between-reference-and-platform

Encountered conflict between 'Reference:System.ValueTuple, Version=4.0.3.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51, processorArchitecture=MSIL' and 'Platform:System.ValueTuple.dll'. Choosing 'Reference:System.ValueTuple, Version=4.0.3.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51, processorArchitecture=MSIL' because AssemblyVersion '4.0.3.0' is greater than '4.0.2.0'.

[sandersaares]

I have not encountered this in forever, so closing.