Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation / emit errors when ref configurations contain RIDs #29154

Closed
ViktorHofer opened this issue Apr 3, 2019 · 1 comment · Fixed by #69116
Closed

Add validation / emit errors when ref configurations contain RIDs #29154

ViktorHofer opened this issue Apr 3, 2019 · 1 comment · Fixed by #69116
Assignees
@ViktorHofer
Labels
area-Infrastructure-libraries
Milestone
Future

Comments

@ViktorHofer
Copy link
Member

Ref assemblies should be RIDless. We should emit an error if somebody tries to add a configuration with a RID.

cc @ericstj
@ericstj
Copy link
Member

ericstj commented Apr 3, 2019

Work here is to add a target that runs for reference assembly builds and errors when OSGroup != anyOS

@msftgits msftgits transferred this issue from dotnet/corefx Feb 1, 2020
@msftgits msftgits added this to the Future milestone Feb 1, 2020
@maryamariyan maryamariyan added the untriaged New issue has not been triaged by the area owner label Feb 23, 2020
@ViktorHofer ViktorHofer removed the untriaged New issue has not been triaged by the area owner label Jun 23, 2020
@ViktorHofer ViktorHofer mentioned this issue Oct 4, 2020
Closed
ViktorHofer added a commit that referenced this issue May 10, 2022
@ViktorHofer
Error if a reference assembly is platform specific
a7d5f9a 
Fixes #29154. I didn't introduce a new target to keep the validation cost as low as possible.
@ViktorHofer ViktorHofer mentioned this issue May 10, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label May 10, 2022
@ViktorHofer ViktorHofer self-assigned this May 10, 2022
@ViktorHofer ViktorHofer removed the help wanted [up-for-grabs] Good issue for external contributors label May 10, 2022
ViktorHofer added a commit that referenced this issue May 11, 2022
@ViktorHofer
Error if a reference assembly is platform specific (#69116)
5b5bd46 
Fixes #29154. I didn't introduce a new target to keep the validation cost as low as possible.
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label May 11, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ViktorHofer ViktorHofer

Labels
area-Infrastructure-libraries
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Error if a reference assembly is platform specific dotnet/runtime
4 participants
@maryamariyan @ViktorHofer @ericstj @msftgits