Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single-file: Generate bundles with deterministic IDs #3601

Closed
swaroop-sridhar opened this issue May 23, 2019 · 6 comments
Closed

Single-file: Generate bundles with deterministic IDs #3601

swaroop-sridhar opened this issue May 23, 2019 · 6 comments
Labels
area-HostModel Microsoft.NET.HostModel issues
Milestone

Comments

@swaroop-sridhar
Copy link
Contributor

The Bundler generates bundled apps with randomly generated bundle-IDs for each build.
Instead, this should be changed to use an ID based on the contents of the bundle.
This way, two builds on the same input generate identical output.

@swaroop-sridhar swaroop-sridhar self-assigned this May 23, 2019
@msftgits msftgits transferred this issue from dotnet/core-setup Jan 30, 2020
@msftgits msftgits added this to the Future milestone Jan 30, 2020
@maryamariyan maryamariyan added the untriaged New issue has not been triaged by the area owner label Feb 23, 2020
@jeffschwMSFT jeffschwMSFT removed area-Single-File untriaged New issue has not been triaged by the area owner labels Feb 24, 2020
@swaroop-sridhar swaroop-sridhar removed their assignment Sep 8, 2020
@wjch-krl
Copy link

Is this something that is planned for fixing in nearest future? If not, will you accept contribution for this?

@JanKrivanek
Copy link
Member

JanKrivanek added a commit to JanKrivanek/runtime that referenced this issue May 18, 2021
vitek-karas pushed a commit that referenced this issue May 25, 2021
#3601
Bundling should generate id based on the content in order to secure unique but reproducible ids
@vitek-karas
Copy link
Member

Fixed by #52930.

@nioncode
Copy link

@vitek-karas Thanks for merging the fix. Is there a roadmap for when a version with the fix will be released?

@vitek-karas
Copy link
Member

This should go into the Preview 6 of .NET 6. It will take a couple of days to get to https://github.com/dotnet/installer where you can download a nightly build before the Preview 6 is released.

@vitek-karas
Copy link
Member

Note that this only affects the SDK, not the runtime. So you can use the latest .NET 6 SDK, but still target 3.1 or 5.0 for the app itself.

@ghost ghost locked as resolved and limited conversation to collaborators Jun 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-HostModel Microsoft.NET.HostModel issues
Projects
None yet
Development

No branches or pull requests

8 participants