Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Console tests failing on iOS #36878

Closed
4 tasks
mdh1418 opened this issue May 22, 2020 · 6 comments · Fixed by #57220
Closed
4 tasks

System.Console tests failing on iOS #36878

mdh1418 opened this issue May 22, 2020 · 6 comments · Fixed by #57220
Milestone

Comments

@mdh1418
Copy link
Member

mdh1418 commented May 22, 2020

Several tests from System.Console fail on iOS:

System.Console.Tests:

  • TermInfo.TermInfoVerification
  • TermInfo.VerifyInstalledTermInfosParse
  • TermInfo.TryingToLoadTermThatDoesNotExistDoesNotThrow
  • TermInfo.VerifyTermInfoSupportsNewAndLegacyNcurses

XML of failing tests

PlatformNotSupportedException

CancelKeyPressTests.CanAddAndRemoveHandler
ReadAndWrite.OutputEncodingPreamble
ReadAndWrite.ReadAndReadLine
ReadAndWrite.OutputEncoding
SetIn.SetInReadLine
SetIn.SetInThrowsOnNull
Color.RoundtrippingColor
Color.RedirectedOutputDoesNotUseAnsiSequences
Color.InvalidColors
ConsoleEncoding.TestEncoding
ConsoleEncoding.TestValidEncodings
SyncTextReader.ReadAsync
SyncTextReader.ReadBlockAsync
SyncTextReader.ReadLineAsync
SyncTextReader.Read
SyncTextReader.ReadToEnd
SyncTextReader.ReadBlock
SyncTextReader.Peek
SyncTextReader.ReadToEndAsync
TimeOut.OpenStandardXXX_ReadTimeOut
TimeOut.OpenStandardXXX_WriteTimeOut
TimeOut.OpenStandardXXX_CanTimeOut
ThreadSafety.SetStandardXXXCanBeCalledConcurrently
ThreadSafety.ReadMayBeCalledConcurrently
ThreadSafety.OpenStandardXXXCanBeCalledConcurrently
WindowAndCursorProps.GetCursorPosition_Invoke_ReturnsExpected
WindowAndCursorProps.CursorVisible_SetUnixRedirected_Nop
WindowAndCursorProps.CursorTop_SetInvalid_ThrowsArgumentOutOfRangeException
WindowAndCursorProps.CursorLeft_SetInvalid_ThrowsArgumentOutOfRangeException
WindowAndCursorProps.LargestWindowHeight_UnixGet_ReturnsExpected
WindowAndCursorProps.WindowHeight_GetUnix_Success
WindowAndCursorProps.WindowWidth_GetUnix_Success
WindowAndCursorProps.BufferWidth_GetUnix_ReturnsWindowWidth
WindowAndCursorProps.SetCursorPosition_Invoke_Success
WindowAndCursorProps.CursorSize_GetUnix_ReturnsExpected
WindowAndCursorProps.LargestWindowWidth_UnixGet_ReturnsExpected
WindowAndCursorProps.BufferHeight_GetUnix_ReturnsWindowHeight
WindowAndCursorProps.CursorTop_Set_GetReturnsExpected
WindowAndCursorProps.CursorLeft_Set_GetReturnsExpected

@ghost
Copy link

ghost commented May 22, 2020

Tagging subscribers to this area: @eiriktsarpalis
Notify danmosemsft if you want to be subscribed.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label May 22, 2020
@danmoseley
Copy link
Member

Every single failure is PlatformNotSupportedException Operation is not supported on this platform.

@mdh1418
Copy link
Member Author

mdh1418 commented Jun 12, 2020

Reran the tests on iOS and ignored PlatformNotSupportedExceptions this time. Updated this issue again, but the failures are System.ArgumentNullException : Value cannot be null. (Parameter 'type') which don't seem iOS specific.

@mdh1418 mdh1418 removed the os-ios Apple iOS label Jun 12, 2020
@danmoseley
Copy link
Member

System.ArgumentNullException : Value cannot be null. (Parameter 'type')]]></message>
          <stack-trace><![CDATA[   at System.Reflection.IntrospectionExtensions.GetTypeInfo(Type type)
   at TermInfo.ReadTermInfoDatabase(String term)
   at TermInfo.TermInfoVerification(String termToTest, String expectedForeground, String expectedBackground, Int32 colorValue)
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
    private const string TerminfoType = "System.TermInfo";
    private const string TerminfoDatabaseType = TerminfoType + "+Database";
... ...
MethodInfo readDbMethod = typeof(Console).GetTypeInfo().Assembly.GetType(TerminfoDatabaseType).GetTypeInfo().GetDeclaredMethods(ReadDatabaseMethod).Where(m => m.GetParameters().Count() == 1).Single();

I guess GetType failed on System.TermInfo+Database

@adamsitnik adamsitnik removed the untriaged New issue has not been triaged by the area owner label Jun 24, 2020
@adamsitnik adamsitnik added this to the 6.0.0 milestone Jun 24, 2020
@marek-safar marek-safar added the os-ios Apple iOS label Jun 24, 2020
@adamsitnik adamsitnik modified the milestones: 6.0.0, 7.0.0 Aug 11, 2021
@adamsitnik
Copy link
Member

I am moving this to 7.0

@danmoseley
Copy link
Member

@mdh1418 is this still actually an issue?

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 11, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 11, 2021
@adamsitnik adamsitnik modified the milestones: 7.0.0, 6.0.0 Aug 12, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants