Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libraries][mobile] Skip TermInfo tests on Android, iOS, MacCatalyst,… #57220

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

mdh1418
Copy link
Member

@mdh1418 mdh1418 commented Aug 11, 2021

… and tvOS

Fixes #36878
Fixes #37465

When investigating TermInfo test failures, MethodInfo readDbMethod = typeof(Console).GetTypeInfo().Assembly.GetType(TerminfoDatabaseType).GetTypeInfo().GetDeclaredMethods(ReadDatabaseMethod).Where(m => m.GetParameters().Count() == 1).Single(); runs into ArgumentNullException at the second occurrence of GetTypeInfo() possibly due to TerminfoDatabaseType being trimmed out?

private const string TerminfoType = "System.TermInfo";
private const string TerminfoDatabaseType = TerminfoType + "+Database";

In any case, TermInfo.cs from src/libraries/System.Console/src/System/TermInfo.cs is not compiled for mobile

<Compile Include="System\TermInfo.cs" />
.

Because mobile doesn't have terminal (sans adb), PNSE TermInfo test for mobile.

@ghost
Copy link

ghost commented Aug 11, 2021

Tagging subscribers to this area: @dotnet/area-system-console
See info in area-owners.md if you want to be subscribed.

Issue Details

… and tvOS

Fixes #36878
Fixes #37465

When investigating TermInfo test failures, MethodInfo readDbMethod = typeof(Console).GetTypeInfo().Assembly.GetType(TerminfoDatabaseType).GetTypeInfo().GetDeclaredMethods(ReadDatabaseMethod).Where(m => m.GetParameters().Count() == 1).Single(); runs into ArgumentNullException at the second occurrence of GetTypeInfo() possibly due to TerminfoDatabaseType being trimmed out?

private const string TerminfoType = "System.TermInfo";
private const string TerminfoDatabaseType = TerminfoType + "+Database";

In any case, TermInfo.cs from src/libraries/System.Console/src/System/TermInfo.cs is not compiled for mobile

<Compile Include="System\TermInfo.cs" />
.

Because mobile doesn't have terminal (sans adb), PNSE TermInfo test for mobile.

Author: mdh1418
Assignees: -
Labels:

area-System.Console

Milestone: -

@mdh1418 mdh1418 merged commit 129dcdd into dotnet:main Aug 11, 2021
@mdh1418 mdh1418 deleted the mobile_skip_terminfotests branch August 11, 2021 19:33
@adamsitnik adamsitnik added this to the 6.0.0 milestone Aug 12, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.Console.Tests fail on Android System.Console tests failing on iOS
3 participants