-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Func eval unreliable in .NET 5 due to Tiered JIT #37278
Comments
cc @kouvel |
kouvel
added a commit
to kouvel/runtime
that referenced
this issue
Jul 29, 2020
- Mostly reverted the previous workaround for the issue (commit fc06054) - Added a forbid-suspend-for-debugger region in preemptive GC mode - Added a crst holder type that acquires a lock and enters the forbid region - Where the slot backpatching lock would be taken where cooperative GC mode may be entered inside that lock, the new crst holder is used - When a suspend for debugger is requested, a thread in preemptive GC mode that is in the forbid region is considered not yet suspended and is synched later similarly to threads in cooperative GC mode Fixes dotnet#37278
kouvel
added a commit
that referenced
this issue
Aug 4, 2020
…40060) - Mostly reverted the previous workaround for the issue (commit fc06054) - Added a forbid-suspend-for-debugger region in preemptive GC mode - Added a crst holder type that acquires a lock and enters the forbid region - Where the slot backpatching lock would be taken where cooperative GC mode may be entered inside that lock, the new crst holder is used - When a suspend for debugger is requested, a thread in preemptive GC mode that is in the forbid region is considered not yet suspended and is synched later similarly to threads in cooperative GC mode Fixes #37278
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this issue
Aug 10, 2020
…otnet#40060) - Mostly reverted the previous workaround for the issue (commit fc06054) - Added a forbid-suspend-for-debugger region in preemptive GC mode - Added a crst holder type that acquires a lock and enters the forbid region - Where the slot backpatching lock would be taken where cooperative GC mode may be entered inside that lock, the new crst holder is used - When a suspend for debugger is requested, a thread in preemptive GC mode that is in the forbid region is considered not yet suspended and is synched later similarly to threads in cooperative GC mode Fixes dotnet#37278
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
Debugger func eval tests are flaky on .NET 5. After much investigation, the problem is this call to MethodDescBackpatchInfoTracker::IsLockOwnedByAnyThread.
That lock is owned by this thread:
Where I think the lock is acquired here:
runtime/src/coreclr/src/vm/tieredcompilation.cpp
Line 453 in 0960210
Regression?
Seems to be a new problem in .NET 5
The text was updated successfully, but these errors were encountered: