Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break up AdvSimd test #37282

Closed
BruceForstall opened this issue Jun 1, 2020 · 5 comments · Fixed by #37859
Closed

Break up AdvSimd test #37282

BruceForstall opened this issue Jun 1, 2020 · 5 comments · Fixed by #37859
Assignees
Labels
arch-arm64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI test-bug Problem in test source code (most likely)
Milestone

Comments

@BruceForstall
Copy link
Member

This test is comprised of over 1200 .cs files. As a result, it regularly times out in GCStress runs, an issue tracked by #33948.

Note that the CI has a 60 minute per-test timeout and 240 minute per-collection timeout for GCStress jobs (see eng\common\templates\runtimes\run-test-job.yml).

This test should be broken up to keep it to a manageable size that would run GCStress in less time.

@BruceForstall BruceForstall added arch-arm64 test-bug Problem in test source code (most likely) area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Jun 1, 2020
@BruceForstall BruceForstall added this to the 5.0 milestone Jun 1, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Jun 1, 2020
@BruceForstall BruceForstall removed the untriaged New issue has not been triaged by the area owner label Jun 1, 2020
@tannergooding
Copy link
Member

Splitting up the tests is rather trivial. It would be helpful if there was some metric for how long 1 test takes so we can use that as a basis for the maximum number of tests per test executable for the HWIntrinsics.

@jkotas
Copy link
Member

jkotas commented Jun 13, 2020

This is timing out in regular CI legs too.

CoreCLR Pri0 Runtime Tests Run Windows_NT arm64 checked failed in #37847 with:

...
        Ending test case at 6/12/2020 10:42:40 PM
        Beginning test case SubtractWideningUpper.Vector128.UInt64.Vector128.UInt32 at 6/12/2020 10:42:40 PM
        Random seed: 20010415; set environment variable CORECLR_SEED to this value to repro
        
        Beginning scenario: RunBasicScenario_UnsafeRead
        Beginning scenario: RunBasicScenario_Load
        Beginning scenario: RunReflectionScenario_UnsafeRead
        Beginning scenario: RunReflectionScenario_Load
        Beginning scenario: RunClsVarScenario
        Beginning scenario: RunClsVarScenario_Load
        Beginning scenario: RunLclVarScenario_UnsafeRead
        Beginning scenario: RunLclVarScenario_Load
        
        cmdLine:C:\dotnetbuild\work\55450822-3e52-430d-bb2d-051374610326\Work\28d8d220-2224-4e20-aa33-5d7c7c805200\Exec\JIT\HardwareIntrinsics\Arm\AdvSimd\AdvSimd_ro\AdvSimd_ro.cmd Timed Out
        Test Harness Exitcode is : -100

I am going to disable the test. It is affecting large number of CoreCLR PRs.

@tannergooding
Copy link
Member

I'll get up a PR to fix this today.

@jkotas
Copy link
Member

jkotas commented Jun 13, 2020

Ok, I will wait for your PR.

@tannergooding
Copy link
Member

Fix should be here: #37859

@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-arm64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI test-bug Problem in test source code (most likely)
Projects
None yet
5 participants