-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test failure: JIT/HardwareIntrinsics/Arm/AdvSimd/AdvSimd_r/AdvSimd_r.sh #33948
Comments
CC. @echesakovMSFT, @CarolEidt |
failed again in job: runtime-coreclr gcstress-extra 20200412.1 Error message
|
@tannergooding Your change #37859 broke the AdvSimd into 4 parts. However, it looks like that's not sufficient. A recent still timed out
in
This, of course, is a very slow kind of run. |
@BruceForstall @tannergooding I will fix this - I am going to split the AdvSimd tests by intrinsic method name - the current way of splitting (as done in #37859) has another big problem - you can't merge two PRs adding hardware intrinsics tests without rebasing one of them on top on another - they will almost certainly conflict in AdvSimd_Part*_r.proj file. |
There is a downside to splitting by as fine grained as by method name in that it will increase build time and the number of build artifacts that exist. It will also increase runtime costs as the JIT will have to restart and recompile the same methods over and over which might cause other timeouts to be hit. |
I will do measurements and come back with numbers. |
I have draft PR #38599 that does splitting by method name @tannergooding Regarding your concerns
It shouldn't increase either build time or the number of build artifacts since I build only one executable AdvSimd.dll and create many .cmd files that run this executable with arguments that are space separated test names. Judging by Kusto telemetry I don't see the dramatic increase in the tests running time either. However, in the PR the HWIntrinsic tests have failed on win-x86 with timeout - so I will need to dig further to see what is going on. Tanner, do you have any concerns with that approach assuming I can figure out what fails on win-x86? |
Provided it isn't significantly increasing the build or run time. I don't have a problem. |
I still see Part0 and Part3 time out, as above: |
@echesakovMSFT, it looks like your draft PR didn't get merged, was there usability concerns? Should we just lower the number of tests per project for now so they can run without timing out? |
@tannergooding I found some issues with the approach - I will work on the issue this week. |
test failed in job: runtime-coreclr gcstress-extra 20200321.1
Error message
category:correctness
theme:testing
skill-level:expert
cost:medium
The text was updated successfully, but these errors were encountered: