Split and group HardwareIntrinsics Arm tests by method name #40177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dotnet-GitSync-Bot
added
the
area-CodeGen-coreclr
… and AdvSimd.Arm64/
…n GenerateTests.csx
…ems in testgrouping.proj
echesakov
force-pushed
the
Runtime_33948
branch
from
2cb6d2a to
ff03618
Compare
|
cc @dotnet/jit-contrib |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change seems to resolve #33948 (timeouts during runtime-coreclr gcstress-extra) and also addresses another concern I expressed in #33948 (comment) (ability to work on HardwareIntrinsics tests without requiring to rebase if someone merges another change to the tests).
However, it does increase the cumulative running time of the tests based on my analysis of Kusto telemetry.
I tried to mitigate the slowdown by allowing the tests to be split across multiple Helix agents - I separated them based on sub-folders of HardwareIntrinsics/. Perhaps, the finer tuning could be done here as well.
Overall, I am not satisfied with what this change does to the tests running time.
At this point, I am reluctant to make a change that just decreases a number of tests per group as per @tannergooding suggestion that will help to mitigate #33948. In the long term, we should come up with a better solution to address "merge-ability" concern.