Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Enable System.Net.WebSockets.Tests.WebSocketTests class #38807

Closed
MaximLipnin opened this issue Jul 6, 2020 · 1 comment · Fixed by #40004
Closed

[wasm] Enable System.Net.WebSockets.Tests.WebSocketTests class #38807

MaximLipnin opened this issue Jul 6, 2020 · 1 comment · Fixed by #40004
Labels
arch-wasm WebAssembly architecture area-System.Net
Milestone
5.0.0

Comments

@MaximLipnin
Copy link
Contributor

At the moment System.Net.WebSockets.Tests crashes with:

  dbug: test[0]
        ABORT: Assertion failed: undefined
  dbug: test[0]
        Stacktrace: 
  dbug: test[0]
  dbug: test[0]
        Error
  dbug: test[0]
            at Object.onAbort (runtime.js:160:13)
  dbug: test[0]
            at abort (dotnet.js:1:14661)
  dbug: test[0]
            at assert (dotnet.js:1:7330)
  dbug: test[0]
            at Object.createSocket (dotnet.js:1:83832)
  dbug: test[0]
            at ___sys_socketcall (dotnet.js:1:98804)
  dbug: test[0]
            at socket (<anonymous>:wasm-function[1040]:0x215eb)
  dbug: test[0]
            at SystemNative_Socket (<anonymous>:wasm-function[5651]:0xf3837)
  dbug: test[0]
            at do_icall (<anonymous>:wasm-function[5389]:0xe858b)
  dbug: test[0]
            at do_icall_wrapper (<anonymous>:wasm-function[1703]:0x48356)
  dbug: test[0]
            at interp_exec_method (<anonymous>:wasm-function[1224]:0x29de8)
  dbug: test[0]
            at interp_runtime_invoke (<anonymous>:wasm-function[4964]:0xcf318)
  dbug: test[0]
            at mono_jit_runtime_invoke (<anonymous>:wasm-function[4467]:0xb917c)
  dbug: test[0]
            at do_runtime_invoke (<anonymous>:wasm-function[1702]:0x4829f)
  dbug: test[0]
            at mono_runtime_invoke_checked (<anonymous>:wasm-function[346]:0xac01)
  dbug: test[0]
            at mono_runtime_try_invoke_array (<anonymous>:wasm-function[4225]:0xae4b0)
  dbug: test[0]
            at ves_icall_InternalInvoke (<anonymous>:wasm-function[3525]:0x95710)
  dbug: test[0]
            at ves_icall_InternalInvoke_raw (<anonymous>:wasm-function[3524]:0x951d9)
  dbug: test[0]
            at do_icall (<anonymous>:wasm-function[5389]:0xe858b)
  dbug: test[0]
            at do_icall_wrapper (<anonymous>:wasm-function[1703]:0x48356)
  dbug: test[0]
            at interp_exec_method (<anonymous>:wasm-function[1224]:0x29de8)
  dbug: test[0]
            at interp_runtime_invoke (<anonymous>:wasm-function[4964]:0xcf318)
  dbug: test[0]
            at mono_jit_runtime_invoke (<anonymous>:wasm-function[4467]:0xb917c)
  dbug: test[0]
            at do_runtime_invoke (<anonymous>:wasm-function[1702]:0x4829f)
  dbug: test[0]
            at mono_runtime_try_invoke (<anonymous>:wasm-function[425]:0xd5a5)
  dbug: test[0]
            at mono_runtime_invoke (<anonymous>:wasm-function[4230]:0xae815)
  dbug: test[0]
            at mono_wasm_invoke_method (<anonymous>:wasm-function[4036]:0xa8bea)
  dbug: test[0]
            at Module._mono_wasm_invoke_method (dotnet.js:1:187283)
  dbug: test[0]
            at Object.init (runtime.js:366:15)
  dbug: test[0]
            at runtime.js:245:9
  dbug: test[0]
            at dotnet.js:1:128739

@vargaz made some fix for that emscripten-core/emscripten#11482. Among others, it should be included to the emscripten release version which we could bump in dotnet/runtime. So the respective tests could be enabled.
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-System.Net untriaged New issue has not been triaged by the area owner labels Jul 6, 2020
@ghost
Copy link

ghost commented Jul 6, 2020

Tagging subscribers to this area: @dotnet/ncl
Notify danmosemsft if you want to be subscribed.

@MaximLipnin MaximLipnin changed the title [wasm] Enable System.Net.WebSockets.Tests [wasm] Enable System.Net.WebSockets.Tests.WebSocketTests class Jul 6, 2020
This was referenced Jul 6, 2020
Merged
Merged
@karelz karelz added the arch-wasm WebAssembly architecture label Jul 17, 2020
@MaximLipnin MaximLipnin mentioned this issue Jul 28, 2020
Merged
akoeplinger pushed a commit that referenced this issue Jul 29, 2020
@MaximLipnin
[wasm] Re-enable some tests in the System.Net.WebSockets.Tests namesp…
6ab00b4 
…ace (#40004)

There is no repro for #38807 at the moment so the related tests have been enabled.
Two tests have been disabled due to PNSE (see #39346).

Fixes: #38807 

The test run result: `Tests run: 177, Errors: 0, Failures: 0, Skipped: 0.`
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this issue Aug 10, 2020
@MaximLipnin @Jacksondr5
[wasm] Re-enable some tests in the System.Net.WebSockets.Tests namesp…
6f99b23 
…ace (dotnet#40004)

There is no repro for dotnet#38807 at the moment so the related tests have been enabled.
Two tests have been disabled due to PNSE (see dotnet#39346).

Fixes: dotnet#38807 

The test run result: `Tests run: 177, Errors: 0, Failures: 0, Skipped: 0.`
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
@karelz karelz removed the untriaged New issue has not been triaged by the area owner label Oct 20, 2022
carlossanlop pushed a commit to carlossanlop/maintenance-packages that referenced this issue Jan 26, 2024
@MaximLipnin
[wasm] Re-enable some tests in the System.Net.WebSockets.Tests namesp…
ff22654 
…ace (#40004)

There is no repro for dotnet/runtime#38807 at the moment so the related tests have been enabled.
Two tests have been disabled due to PNSE (see dotnet/runtime#39346).

Fixes: dotnet/runtime#38807 

The test run result: `Tests run: 177, Errors: 0, Failures: 0, Skipped: 0.`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-System.Net
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

[wasm] Re-enable some tests in the System.Net.WebSockets.Tests namespace MaximLipnin/runtime
3 participants
@MaximLipnin @karelz @Dotnet-GitSync-Bot