Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim OSPlatformAttributes from WASM apps #40163

Closed
eerhardt opened this issue Jul 30, 2020 · 1 comment · Fixed by #41799
Closed

Trim OSPlatformAttributes from WASM apps #40163

eerhardt opened this issue Jul 30, 2020 · 1 comment · Fixed by #41799
Labels
area-System.Runtime linkable-framework Issues associated with delivering a linker friendly framework
Milestone
5.0.0

Comments

@eerhardt
Copy link
Member

The new attributes that inherit from OSPlatformAttribute that were introduced with #33331 are only needed for build-time analysis. They are not necessary at runtime. We should add these attributes to the list of attributes we remove for linked WASM apps:

runtime/src/mono/netcore/System.Private.CoreLib/src/ILLink/ILLink.LinkAttributes.wasm.xml

Lines 2 to 7 in a5e2249

<assembly fullname="System.Private.CoreLib">
<!-- System -->
<type fullname="System.CLSCompliantAttribute">
<attribute internal="RemoveAttributeInstances" />
</type>
<type fullname="System.ObsoleteAttribute">

cc @marek-safar @layomia
@eerhardt eerhardt added area-System.Runtime linkable-framework Issues associated with delivering a linker friendly framework labels Jul 30, 2020
@eerhardt eerhardt added this to the 6.0.0 milestone Jul 30, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Jul 30, 2020
@eerhardt eerhardt removed the untriaged New issue has not been triaged by the area owner label Jul 30, 2020
@marek-safar marek-safar modified the milestones: 6.0.0, 5.0.0 Aug 27, 2020
@jeffhandley
Copy link
Member

@marek-safar I'm assuming your team will field this but please let me know if you need anything from my team. Thanks.

marek-safar added a commit to marek-safar/runtime that referenced this issue Sep 3, 2020
@marek-safar
Remove OSPlatformAttribute attributes from wasm linked output
6cd4372 
Fixes dotnet#40163
@marek-safar marek-safar mentioned this issue Sep 3, 2020
Merged
github-actions bot pushed a commit that referenced this issue Sep 3, 2020
@marek-safar
Remove OSPlatformAttribute attributes from wasm linked output
b17d0b8 
Fixes #40163
jkotas pushed a commit that referenced this issue Sep 3, 2020
@marek-safar
Remove OSPlatformAttribute attributes from wasm linked output (#41799)
06d5a5e 
Fixes #40163
danmoseley pushed a commit that referenced this issue Sep 10, 2020
@github-actions @marek-safar
Remove OSPlatformAttribute attributes from wasm linked output (#41806)
ec19efd 
Fixes #40163

Co-authored-by: Marek Safar <marek.safar@gmail.com>
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Runtime linkable-framework Issues associated with delivering a linker friendly framework
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Remove OSPlatformAttribute attributes from wasm linked output marek-safar/runtime
4 participants
@marek-safar @jeffhandley @eerhardt @Dotnet-GitSync-Bot