Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failure: JIT\\jit64\\opt\\cse\\HugeField1\\HugeField1.cmd #43818

Closed
v-haren opened this issue Oct 26, 2020 · 1 comment
Closed

Test failure: JIT\\jit64\\opt\\cse\\HugeField1\\HugeField1.cmd #43818

v-haren opened this issue Oct 26, 2020 · 1 comment
Assignees
@markples
Labels
area-ILTools-coreclr
Milestone
8.0.0

Comments

@v-haren
Copy link

v-haren commented Oct 26, 2020

failed in job: runtime-coreclr ilasm 20201024.1

CoreCLR Windows_NT x86 Checked ilasmroundtrip @ Windows.10.Amd64.Open

Error message

Return code:      1
Raw output file:      C:\h\w\A4CC0933\w\B77F09A2\e\JIT\jit64\Reports\JIT.jit64\opt\cse\HugeField1\HugeField1.output.txt
Raw output:
BEGIN EXECUTION
C:\h\w\A4CC0933\p\ildasm.exe /raweh /out=HugeField1.dasm.il HugeField1.dll
C:\h\w\A4CC0933\p\ilasm.exe /output=HugeField1.asm.dll  HugeField1.dasm.il
EXECUTION OF ILASM - FAILED 3
Test Harness Exitcode is : 1
To run the test:
> set CORE_ROOT=C:\h\w\A4CC0933\p
> C:\h\w\A4CC0933\w\B77F09A2\e\JIT\jit64\opt\cse\HugeField1\HugeField1.cmd
Expected: True
Actual:   False


Stack trace
   at JIT_jit64._opt_cse_HugeField1_HugeField1_._opt_cse_HugeField1_HugeField1_cmd() in F:\workspace\_work\1\s\artifacts\tests\coreclr\Windows_NT.x86.Checked\TestWrappers\JIT.jit64\JIT.jit64.XUnitWrapper.cs:line 22062
@v-haren v-haren added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 26, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Oct 26, 2020
@BruceForstall BruceForstall added area-ILTools-coreclr and removed area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI untriaged New issue has not been triaged by the area owner labels Oct 26, 2020
@BruceForstall BruceForstall added this to the 6.0.0 milestone Oct 26, 2020
@JulieLeeMSFT JulieLeeMSFT modified the milestones: 6.0.0, Future Aug 13, 2021
@markples markples mentioned this issue Oct 4, 2022
Merged
@JulieLeeMSFT JulieLeeMSFT assigned markples and unassigned EgorBo Oct 4, 2022
@JulieLeeMSFT JulieLeeMSFT modified the milestones: Future, 8.0.0 Oct 4, 2022
markples added a commit that referenced this issue Oct 5, 2022
@markples
[ilasm] Lazily allocate memory in Indx256 (#76590)
324bd24 
Indx256 is a trie (or prefix tree) used to map labels to instructions.  It is very space-intensive because it allocates 256-element arrays for child nodes.  This is a localized fix to lazily allocate the child arrays and to split them into two 128-element arrays to handle common cases such as ildasm's output (IL_<hex>).  A more aggressive change to a different data structure would save much more memory but should probably include an analysis of why a trie was originally used.

Fixes #38515, #38529, #43818, and #73139.  I don't think hugeExpr1 (#38515) is going to get picked up by our current testing since the ilasmroundtrip run doesn't turn off tiered compilation, but I did check its behavior on x86 locally.
@markples
Copy link
Member

markples commented Oct 5, 2022

Fixed in #76590

@markples markples closed this as completed Oct 5, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@markples markples

Labels
area-ILTools-coreclr
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
6 participants
@EgorBo @BruceForstall @markples @v-haren @Dotnet-GitSync-Bot @JulieLeeMSFT