-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Span overload for Socket.ReceiveMessageFrom #43933
Labels
api-approved
API was approved in API review, it can be implemented
area-System.Net.Sockets
help wanted
[up-for-grabs] Good issue for external contributors
Milestone
Comments
Tagging subscribers to this area: @dotnet/ncl |
Triage: Should be simple to do once the API is formally reviewed. |
Looks good as proposed namespace System.Net.Sockets
{
public partial class Socket : IDisposable
{
public int ReceiveMessageFrom(Span<byte> buffer, ref System.Net.Sockets.SocketFlags socketFlags, ref System.Net.EndPoint remoteEP, out System.Net.Sockets.IPPacketInformation ipPacketInformation);
}
} |
ovebastiansen
added a commit
to ovebastiansen/runtime
that referenced
this issue
Jan 29, 2021
antonfirsov
pushed a commit
that referenced
this issue
Feb 2, 2021
* adding span version of ReceiveMessageFrom fix #43933 * Started using new testsetup for the receivemessagefrom * removed code duplication in socketpal.windows * removed unused buffers parameter * adding non-zero offset to the ReceiveMessageFrom test * added documentation * offset fix for EAP tests * fixing pr comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
api-approved
API was approved in API review, it can be implemented
area-System.Net.Sockets
help wanted
[up-for-grabs] Good issue for external contributors
We apparently missed this one in #938.
Proposed API
The text was updated successfully, but these errors were encountered: