-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure the BCL supports hot reloading, especially around reflection #45023
Comments
@stephentoub is there more detail here? When we discussed it, the need for changes in the core libraries was hypothetical, perhaps we have more now? cc @steveharter |
I don't know what @terrajobst had in mind here. 😄 The only thing I'm aware of in this space is potentially being able to invalidate various caches in the libraries when some kind of change is made, via some form of runtime callback, and reflection is ripe with caches that would qualify (e.g. if you add a value to an enum, it'd be nice if subsequent use of reflection to list enum names would include the new value). |
What would that look like -- an event one can subscribe to on AppDomain (that still seems to be the closest place to a location for global events) ? |
More important question is how would people write reliable and performant code with mutable reflection model. Programming against mutable object models is incredibly hard to do in reliable and performant way. It is one of the reason why Edit&Continue does not expose the edits in the reflection APIs today. |
Perhaps @steveharter can help us in January to figure out whether there's anything here or this can be closed? I'd rather it not sit around without more clarity. |
We need end-to-end spec with details how the different hot reloading modes are going to work, where each of them ends and their implementation architecture. This specific issue is a potential part of the EnC hot reloading mode. We need to draw a boundary around the limits of EnC reloading mode before we can tell what makes sense to do here. FWIW, I expect that this issue is going to be cut because of #45023 (comment). |
@DamianEdwards @stephentoub is there a person who owns this spec? |
|
Hi folks, @tmat and I would love to meet with all of you to discuss this. I will setup a quick chat and we can circle back here once we've talked. |
@terrajobst / @stephentoub - Did anything end up surfacing from the Libraries perspective on this that still needs to be addressed, or can this be closed? |
Nothing beyond what I already did has surfaced as being needed. As planned, we'll deal with additional clearing needs as one-offs as feedback dictates. |
Makes sense. Thanks! |
TBD
The text was updated successfully, but these errors were encountered: