Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace OSX_ARM64_ABI define with a runtime flag. #45501

Closed
2 of 3 tasks
sandreenko opened this issue Dec 2, 2020 · 1 comment · Fixed by #68319
Closed
2 of 3 tasks

Replace OSX_ARM64_ABI define with a runtime flag. #45501

sandreenko opened this issue Dec 2, 2020 · 1 comment · Fixed by #68319
Assignees
@jakobbotsch
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
7.0.0

Comments

@sandreenko
Copy link
Contributor

sandreenko commented Dec 2, 2020 •
edited by jakobbotsch
Loading

  • Delete DEBUG_ARG_SLOTS code. It was added to check that the previous behavior for supported platforms was preserved with Apple Arm64 changes. Once we get a ci and pass all tests on arm64 apple we should get rid of it, so we don't have any special fields in jit internal structures for !OSX_ARM64_ABI.

  • Replace OSX_ARM64_ABI usages with runtime flag, something like #ifdef ARM64 && UNIX -> checkVMflag;

  • Revert changes from Add OSX arm64 jit. #45467
@sandreenko sandreenko added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 2, 2020
@sandreenko sandreenko added this to the 6.0.0 milestone Dec 2, 2020
@sandreenko sandreenko self-assigned this Dec 2, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Dec 2, 2020
@sandreenko
Copy link
Contributor Author

cc @davidwrighton

@sandreenko sandreenko removed the untriaged New issue has not been triaged by the area owner label Dec 2, 2020
@sandreenko sandreenko mentioned this issue Dec 15, 2020
Merged
@AntonLapounov AntonLapounov mentioned this issue Jan 23, 2021
Merged
@sandreenko sandreenko modified the milestones: 6.0.0, Future Mar 29, 2021
@jakobbotsch jakobbotsch modified the milestones: Future, 7.0.0 Apr 21, 2022
jakobbotsch added a commit to jakobbotsch/runtime that referenced this issue Apr 21, 2022
@jakobbotsch
Remove DEBUG_ARG_SLOTS
9f7232e 
This mainly served to assert consistency between the by-byte and by-slot
values while macOS arm64 ABI support was implemented. Now that this is
done we can get rid of all code related to this.

Fix dotnet#45501
@jakobbotsch jakobbotsch mentioned this issue Apr 21, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Apr 21, 2022
jakobbotsch added a commit that referenced this issue Apr 22, 2022
@jakobbotsch
Remove DEBUG_ARG_SLOTS (#68319)
77f0df7 
This mainly served to assert consistency between the by-byte and by-slot
values while macOS arm64 ABI support was implemented. Now that this is
done we can get rid of all code related to this.

Fix #45501
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Apr 22, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jakobbotsch jakobbotsch

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Remove DEBUG_ARG_SLOTS jakobbotsch/runtime
3 participants
@jakobbotsch @sandreenko @Dotnet-GitSync-Bot