[wasm] EnableAggressiveTrimming causing failing tests - System.Diagnostics.Tests.ActivityTest

[mdh1418]

In effort to run library tests with AOT compilation on CI #46633, there are a number of failures arising from #46651.

Test suite System.Diagnostics.DiagnosticSource/tests/TestWithConfigSwitches/System.Diagnostics.DiagnosticSource.Switches.Tests.csproj fails with

  fail: [FAIL] System.Diagnostics.Tests.ActivityTests.ActivityIdNonHierarchicalOverflow
  info: Assert.InRange() Failure
  info: Range:  (55 - 56)
  info: Actual: 27
  info:
  fail: [FAIL] System.Diagnostics.Tests.ActivityTests.IdFormat_ZeroTraceIdAndSpanIdWithHierarchicalFormat
  info: Assert.Equal() Failure
  info: Expected: Hierarchical
  info: Actual:   W3C
  info:
  fail: [FAIL] System.Diagnostics.Tests.ActivityTests.IdFormat_HierarchicalIsDefault
  info: Assert.Equal() Failure
  info: Expected: Hierarchical
  info: Actual:   W3C
  info:
  fail: [FAIL] System.Diagnostics.Tests.ActivityTests.IdGenerationInternalParent
  info: System.PlatformNotSupportedException : Cannot wait on monitors on this runtime.
  info:
  info: Finished:    System.Diagnostics.DiagnosticSource.Switches.Tests.dll

System_diagnostics_diagnosticsource_switches_fail.txt

Repro:
Check out changes in #46651
./build.sh -os Browser -arch wasm -c Release
Remove

runtime/eng/testing/ILLink.Descriptor.xunit.xml

Lines 15 to 20 in f7f5046

	<!-- Temporary until https://github.com/mono/linker/issues/1713 is resolved -->
	<assembly fullname="Microsoft.DotNet.RemoteExecutor">
	<type fullname="Microsoft.DotNet.RemoteExecutor.Program">
	<method signature="System.Int32 Main(System.String[])" />
	</type>
	</assembly>

Modify

runtime/src/libraries/System.Private.CoreLib/src/System/IO/FileStream.Unix.cs

Line 256 in 9538bee

catch (Exception e) when (IsIoRelatedException(e) && !disposing)

to be an empty catch

catch
{
}

./dotnet.sh build /t:Test /p:TargetOS=Browser /p:TargetArchitecture=wasm /p:Configuration=Release /p:EnableAggressiveTrimming=true /p:RunAOTCompilation=true src/libraries/System.Diagnostics.DiagnosticSource/tests/TestWithConfigSwitches/System.Diagnostics.DiagnosticSource.Switches.Tests.csproj

[ghost]

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

---

In effort to run library tests with AOT compilation on CI #46633, there are a number of failures arising from #46651.

Test suite System.Diagnostics.DiagnosticSource/tests/TestWithConfigSwitches/System.Diagnostics.DiagnosticSource.Switches.Tests.csproj fails with

  fail: [FAIL] System.Diagnostics.Tests.ActivityTests.ActivityIdNonHierarchicalOverflow
  info: Assert.InRange() Failure
  info: Range:  (55 - 56)
  info: Actual: 27
  info:
  fail: [FAIL] System.Diagnostics.Tests.ActivityTests.IdFormat_ZeroTraceIdAndSpanIdWithHierarchicalFormat
  info: Assert.Equal() Failure
  info: Expected: Hierarchical
  info: Actual:   W3C
  info:
  fail: [FAIL] System.Diagnostics.Tests.ActivityTests.IdFormat_HierarchicalIsDefault
  info: Assert.Equal() Failure
  info: Expected: Hierarchical
  info: Actual:   W3C
  info:
  fail: [FAIL] System.Diagnostics.Tests.ActivityTests.IdGenerationInternalParent
  info: System.PlatformNotSupportedException : Cannot wait on monitors on this runtime.
  info:
  info: Finished:    System.Diagnostics.DiagnosticSource.Switches.Tests.dll

System_diagnostics_diagnosticsource_switches_fail.txt

Repro:
Check out changes in #46651
./build.sh -os Browser -arch wasm -c Release
Remove

runtime/eng/testing/ILLink.Descriptor.xunit.xml

Lines 15 to 20 in f7f5046

	<!-- Temporary until https://github.com/mono/linker/issues/1713 is resolved -->
	<assembly fullname="Microsoft.DotNet.RemoteExecutor">
	<type fullname="Microsoft.DotNet.RemoteExecutor.Program">
	<method signature="System.Int32 Main(System.String[])" />
	</type>
	</assembly>

Modify

runtime/src/libraries/System.Private.CoreLib/src/System/IO/FileStream.Unix.cs

Line 256 in 9538bee

catch (Exception e) when (IsIoRelatedException(e) && !disposing)

to be an empty catch

catch
{
}

./dotnet.sh build /t:Test /p:TargetOS=Browser /p:TargetArchitecture=wasm /p:Configuration=Release /p:EnableAggressiveTrimming=true /p:RunAOTCompilation=true src/libraries/System.Diagnostics.DiagnosticSource/tests/TestWithConfigSwitches/System.Diagnostics.DiagnosticSource.Switches.Tests.csproj

Author:	mdh1418
Assignees:	-
Labels:	arch-wasm, area-Infrastructure-libraries
Milestone:	-

[radical]

[FAIL] System.Diagnostics.Tests.ActivityTests.IdGenerationInternalParent

• this needs to be disabled with IsThreadingSupported ([wasm] Disable `System.Diagnostics.Tests.ActivityTests.IdGenerationIn… #46875)

Others I can reproduce with /p:EnableAggressiveTrimming=true, and no AOT compilation.