-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PGO considerations for finally cloning #48925
Labels
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
dotnet-issue-labeler
bot
added
the
untriaged
New issue has not been triaged by the area owner
label
Mar 1, 2021
AndyAyersMS
added
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
and removed
untriaged
New issue has not been triaged by the area owner
labels
Mar 1, 2021
See also #48850 (comment) |
AndyAyersMS
added a commit
to AndyAyersMS/runtime
that referenced
this issue
Mar 4, 2021
Update `impImportLeave` to propagate IBC counts to new blocks. Fix profile weights during callfinally chain merging. Scale profile weights for cloned finallys. Choose the continuation path based on profile weight. Make sure to keep handler entry hot. Partial fix for dotnet#48925.
AndyAyersMS
added a commit
that referenced
this issue
Mar 5, 2021
Update `impImportLeave` to propagate IBC counts to new blocks. Fix profile weights during callfinally chain merging. Scale profile weights for cloned finallys. Choose the continuation path based on profile weight. Make sure to keep handler entry hot. Partial fix for #48925.
Will defer the rest for now. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Current finally cloning algorithm is roughly:
With PGO data, we should reconsider:
At a minimum, we should do the rescaling.
category:cq
theme:profile-feedback
The text was updated successfully, but these errors were encountered: