Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WASM] _BeforeWasmBuildApp requires EMSDK_PATH to be configured #50801

Closed
pranavkm opened this issue Apr 6, 2021 · 2 comments · Fixed by #50810
Closed

[WASM] _BeforeWasmBuildApp requires EMSDK_PATH to be configured #50801

pranavkm opened this issue Apr 6, 2021 · 2 comments · Fixed by #50810
Assignees
@radical
Labels
area-Infrastructure-mono untriaged New issue has not been triaged by the area owner

Comments

@pranavkm
Copy link
Contributor

pranavkm commented Apr 6, 2021

Looks like 6.0-preview3 changes haven't been ported to main:

6.0-preview3: https://github.com/dotnet/runtime/blob/release/6.0-preview3/src/mono/wasm/build/WasmApp.targets#L196-L199
main: https://github.com/dotnet/runtime/blob/main/src/mono/wasm/build/WasmApp.targets#L201-L204
@dotnet-issue-labeler dotnet-issue-labeler bot added area-Infrastructure-mono untriaged New issue has not been triaged by the area owner labels Apr 6, 2021
@ghost
Copy link

ghost commented Apr 6, 2021

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Looks like 6.0-preview3 changes haven't been ported to main:

6.0-preview3: https://github.com/dotnet/runtime/blob/release/6.0-preview3/src/mono/wasm/build/WasmApp.targets#L196-L199
main: https://github.com/dotnet/runtime/blob/main/src/mono/wasm/build/WasmApp.targets#L201-L204

Author: pranavkm
Assignees: -
Labels:

area-Infrastructure-mono, untriaged
Milestone: -

@pranavkm
Copy link
Contributor Author

pranavkm commented Apr 6, 2021

FYI @lewing \ @radical

@pranavkm pranavkm mentioned this issue Apr 6, 2021
Closed
@radical radical self-assigned this Apr 6, 2021
radical added a commit to radical/runtime that referenced this issue Apr 6, 2021
@radical
[wasm] Remove unncessary condition for EMSDK
f593473 
We check for `emsdk` is much more granular way now, and at the points
where it will actually be used. So, remove these stale early checks for
`emsdk`.

Fixes dotnet#50801
@radical radical mentioned this issue Apr 6, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Apr 6, 2021
radical added a commit that referenced this issue Apr 7, 2021
@radical
[wasm] Remove unncessary condition for EMSDK (#50810)
181f788 
We check for `emsdk` is much more granular way now, and at the points
where it will actually be used. So, remove these stale early checks for
`emsdk`.

Fixes #50801
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Apr 7, 2021
@ghost ghost locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@radical radical

Labels
area-Infrastructure-mono untriaged New issue has not been triaged by the area owner
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[wasm] Remove unncessary check for EMSDK_PATH radical/runtime
2 participants
@radical @pranavkm