-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System.IO.MemoryMappedFiles.Tests Fails on iOS/tvOS/Wasm #51375
Comments
Tagging subscribers to this area: @carlossanlop Issue DetailsSystem.IO.MemoryMappedFiles.Tests
|
Affected by dotnet#51375
Affected by dotnet#51375
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsSystem.IO.MemoryMappedFiles.Tests
|
I cannot reproduce for Wasm. Can I ask you @radekdoulik to check them on OSX? (https://github.com/ilonatommy/runtime/tree/enable-memoryMappedFilesTests-51375) |
* Use new docker images * Silence warnings * Bump dependencies * Bump emscripten version * Update dependencies * Fix linking * Move the link fix to default link response file To make tests build * Disable one more test Affected by #51375 * Ignore link errors coming from native refs This avoids this error, where the linker seems more strict now: ``` [] EXEC : error : undefined symbol: _ZNKSt3__220__vector_base_commonILb1EE20__throw_length_errorEv (referenced by top-level compiled C/C++ code) [/datadisks/disk1/work/BDDD0A63/w/A3D60932/e/blz_nativeref_aot_Debug/blz_nativeref_aot_Debug.csproj] [] EXEC : warning : Link with `-sLLD_REPORT_UNDEFINED` to get more information on undefined symbols [/datadisks/disk1/work/BDDD0A63/w/A3D60932/e/blz_nativeref_aot_Debug/blz_nativeref_aot_Debug.csproj] [] EXEC : warning : To disable errors for undefined symbols use `-sERROR_ON_UNDEFINED_SYMBOLS=0` [/datadisks/disk1/work/BDDD0A63/w/A3D60932/e/blz_nativeref_aot_Debug/blz_nativeref_aot_Debug.csproj] [] EXEC : warning : __ZNKSt3__220__vector_base_commonILb1EE20__throw_length_errorEv may need to be added to EXPORTED_FUNCTIONS if it arrives from a system library [/datadisks/disk1/work/BDDD0A63/w/A3D60932/e/blz_nativeref_aot_Debug/blz_nativeref_aot_Debug.csproj] [] EXEC : error : undefined symbol: _ZNKSt3__221__basic_string_commonILb1EE20__throw_length_errorEv (referenced by top-level compiled C/C++ code) [/datadisks/disk1/work/BDDD0A63/w/A3D60932/e/blz_nativeref_aot_Debug/blz_nativeref_aot_Debug.csproj] [] EXEC : warning : __ZNKSt3__221__basic_string_commonILb1EE20__throw_length_errorEv may need to be added to EXPORTED_FUNCTIONS if it arrives from a system library [/datadisks/disk1/work/BDDD0A63/w/A3D60932/e/blz_nativeref_aot_Debug/blz_nativeref_aot_Debug.csproj] [] EXEC : error : Aborting compilation due to previous errors [/datadisks/disk1/work/BDDD0A63/w/A3D60932/e/blz_nativeref_aot_Debug/blz_nativeref_aot_Debug.csproj] [] emcc : error : '/datadisks/disk1/work/BDDD0A63/w/A3D60932/e/dotnet-workload/packs/Microsoft.NET.Runtime.Emscripten.3.1.12.Node.linux-x64/7.0.0-preview.6.22308.2/tools/bin/node ``` * Avoid another linker error in tests * Disable failing test * Try to use emscripten_force_exit in mono_wasm_exit * Bump docker image to get newer v8 * Fix remaining conflict * Use 3.1.12 icu again, it was lost with merge * Revert "Try to use emscripten_force_exit in mono_wasm_exit" This reverts commit bdba37b. * Revert "Ignore link errors coming from native refs" This reverts commit f2bfa1f. * [wasm] Don't run tests on windows with v8 - We are only interested in testing with v8 on linux This changes: 1. All the AOT tests to run with browser on windows 2. Library tests (interpreter) will run with browser, and nodejs * Fix System.Net.Http.Functional.Tests failing due to trimming .. on Windows/AOT: * [wasm] Fix windows/tests/aot timeout to be same for running on browser .. as for v8. * Disable failing tests - issue#71877 Co-authored-by: Radek Doulik <radekdoulik@google.com> Co-authored-by: Ankit Jain <radical@gmail.com>
@mdh1418 I can take a look at iOS failure. /cc: @SamMonoRT |
The tests are passing both locally on a device and on tvOS CI pipeline. @ilonatommy If they are passing on the WASM as well, I suggest we close this issue. |
Wasm tests are failing when the host is browser, so in Edit: iOS is failing on CI, so we cannot unblock the tests yet. |
System.IO.MemoryMappedFiles.Tests
System.IO.MemoryMappedFiles.Tests.MemoryMappedFileTests_CreateFromFile.ValidArgumentCombinationsWithPath_ModeCreate
System.IO.MemoryMappedFiles.Tests.MemoryMappedFileTests_CreateFromFile.ValidArgumentCombinationsWithStream
System.IO.MemoryMappedFiles.Tests.MemoryMappedFileTests_CreateFromFile.ValidArgumentCombinationsWithPath_ModesOpenOrCreate
System.IO.MemoryMappedFiles.Tests.MemoryMappedFileTests_CreateFromFile.ValidArgumentCombinationsWithPath_ModeCreateNew
System.IO.MemoryMappedFiles.Tests.MemoryMappedFileTests_CreateNew.ValidArgumentCombinations
System.IO.MemoryMappedFiles.Tests.MemoryMappedViewStreamTests.InvalidArguments
System.IO.MemoryMappedFiles.Tests.MemoryMappedViewAccessorTests.InvalidArguments
The text was updated successfully, but these errors were encountered: