Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.IO.MemoryMappedFiles.Tests Fails on iOS/tvOS/Wasm #51375

Open
mdh1418 opened this issue Apr 16, 2021 · 6 comments
Open

System.IO.MemoryMappedFiles.Tests Fails on iOS/tvOS/Wasm #51375

mdh1418 opened this issue Apr 16, 2021 · 6 comments
Assignees
Labels
arch-wasm WebAssembly architecture area-System.IO disabled-test The test is disabled in source code against the issue os-ios Apple iOS os-tvos Apple tvOS
Milestone

Comments

@mdh1418
Copy link
Member

mdh1418 commented Apr 16, 2021

System.IO.MemoryMappedFiles.Tests
System.IO.MemoryMappedFiles.Tests.MemoryMappedFileTests_CreateFromFile.ValidArgumentCombinationsWithPath_ModeCreate
System.IO.MemoryMappedFiles.Tests.MemoryMappedFileTests_CreateFromFile.ValidArgumentCombinationsWithStream
System.IO.MemoryMappedFiles.Tests.MemoryMappedFileTests_CreateFromFile.ValidArgumentCombinationsWithPath_ModesOpenOrCreate
System.IO.MemoryMappedFiles.Tests.MemoryMappedFileTests_CreateFromFile.ValidArgumentCombinationsWithPath_ModeCreateNew
System.IO.MemoryMappedFiles.Tests.MemoryMappedFileTests_CreateNew.ValidArgumentCombinations
System.IO.MemoryMappedFiles.Tests.MemoryMappedViewStreamTests.InvalidArguments
System.IO.MemoryMappedFiles.Tests.MemoryMappedViewAccessorTests.InvalidArguments

System.IO.MemoryMappedFiles.Tests.dll   Failed: 7

Test collection for System.IO.MemoryMappedFiles.Tests.dll
System.IO.MemoryMappedFiles.Tests.MemoryMappedFileTests_CreateFromFile.ValidArgumentCombinationsWithPath_ModeCreate
    Assert.InRange() Failure\r\nRange:  (1 - 2147483647)\r\nActual: -1
System.IO.MemoryMappedFiles.Tests.MemoryMappedFileTests_CreateFromFile.ValidArgumentCombinationsWithStream
    Assert.InRange() Failure\r\nRange:  (1 - 2147483647)\r\nActual: -1
System.IO.MemoryMappedFiles.Tests.MemoryMappedFileTests_CreateFromFile.ValidArgumentCombinationsWithPath_ModesOpenOrCreate
    Assert.InRange() Failure\r\nRange:  (1 - 2147483647)\r\nActual: -1
System.IO.MemoryMappedFiles.Tests.MemoryMappedFileTests_CreateFromFile.ValidArgumentCombinationsWithPath_ModeCreateNew
    Assert.InRange() Failure\r\nRange:  (1 - 2147483647)\r\nActual: -1
System.IO.MemoryMappedFiles.Tests.MemoryMappedFileTests_CreateNew.ValidArgumentCombinations
    Assert.InRange() Failure\r\nRange:  (1 - 2147483647)\r\nActual: -1
System.IO.MemoryMappedFiles.Tests.MemoryMappedViewStreamTests.InvalidArguments
    Assert.InRange() Failure\r\nRange:  (1 - 2147483647)\r\nActual: -1
System.IO.MemoryMappedFiles.Tests.MemoryMappedViewAccessorTests.InvalidArguments
    Assert.InRange() Failure\r\nRange:  (1 - 2147483647)\r\nActual: -1
@mdh1418 mdh1418 added os-ios Apple iOS os-tvos Apple tvOS labels Apr 16, 2021
@mdh1418 mdh1418 added this to the 6.0.0 milestone Apr 16, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.IO untriaged New issue has not been triaged by the area owner labels Apr 16, 2021
@ghost
Copy link

ghost commented Apr 16, 2021

Tagging subscribers to this area: @carlossanlop
See info in area-owners.md if you want to be subscribed.

Issue Details

System.IO.MemoryMappedFiles.Tests
System.IO.MemoryMappedFiles.Tests.MemoryMappedFileTests_CreateFromFile.ValidArgumentCombinationsWithPath_ModeCreate
System.IO.MemoryMappedFiles.Tests.MemoryMappedFileTests_CreateFromFile.ValidArgumentCombinationsWithStream
System.IO.MemoryMappedFiles.Tests.MemoryMappedFileTests_CreateFromFile.ValidArgumentCombinationsWithPath_ModesOpenOrCreate
System.IO.MemoryMappedFiles.Tests.MemoryMappedFileTests_CreateFromFile.ValidArgumentCombinationsWithPath_ModeCreateNew
System.IO.MemoryMappedFiles.Tests.MemoryMappedFileTests_CreateNew.ValidArgumentCombinations
System.IO.MemoryMappedFiles.Tests.MemoryMappedViewStreamTests.InvalidArguments
System.IO.MemoryMappedFiles.Tests.MemoryMappedViewAccessorTests.InvalidArguments

System.IO.MemoryMappedFiles.Tests.dll   Failed: 7

Test collection for System.IO.MemoryMappedFiles.Tests.dll
System.IO.MemoryMappedFiles.Tests.MemoryMappedFileTests_CreateFromFile.ValidArgumentCombinationsWithPath_ModeCreate
    Assert.InRange() Failure\r\nRange:  (1 - 2147483647)\r\nActual: -1
System.IO.MemoryMappedFiles.Tests.MemoryMappedFileTests_CreateFromFile.ValidArgumentCombinationsWithStream
    Assert.InRange() Failure\r\nRange:  (1 - 2147483647)\r\nActual: -1
System.IO.MemoryMappedFiles.Tests.MemoryMappedFileTests_CreateFromFile.ValidArgumentCombinationsWithPath_ModesOpenOrCreate
    Assert.InRange() Failure\r\nRange:  (1 - 2147483647)\r\nActual: -1
System.IO.MemoryMappedFiles.Tests.MemoryMappedFileTests_CreateFromFile.ValidArgumentCombinationsWithPath_ModeCreateNew
    Assert.InRange() Failure\r\nRange:  (1 - 2147483647)\r\nActual: -1
System.IO.MemoryMappedFiles.Tests.MemoryMappedFileTests_CreateNew.ValidArgumentCombinations
    Assert.InRange() Failure\r\nRange:  (1 - 2147483647)\r\nActual: -1
System.IO.MemoryMappedFiles.Tests.MemoryMappedViewStreamTests.InvalidArguments
    Assert.InRange() Failure\r\nRange:  (1 - 2147483647)\r\nActual: -1
System.IO.MemoryMappedFiles.Tests.MemoryMappedViewAccessorTests.InvalidArguments
    Assert.InRange() Failure\r\nRange:  (1 - 2147483647)\r\nActual: -1

<table>
  <tr>
    <th align="left">Author:</th>
    <td>mdh1418</td>
  </tr>
  <tr>
    <th align="left">Assignees:</th>
    <td>-</td>
  </tr>
  <tr>
    <th align="left">Labels:</th>
    <td>

`area-System.IO`, `os-ios`, `os-tvos`, `untriaged`

</td>
  </tr>
  <tr>
    <th align="left">Milestone:</th>
    <td>6.0.0</td>
  </tr>
</table>
</details>

@adamsitnik adamsitnik removed the untriaged New issue has not been triaged by the area owner label Jul 1, 2021
@adamsitnik adamsitnik modified the milestones: 6.0.0, 7.0.0 Jul 22, 2021
radekdoulik added a commit to radekdoulik/runtime that referenced this issue May 13, 2022
radekdoulik added a commit to radekdoulik/runtime that referenced this issue Jun 14, 2022
@radical radical changed the title System.IO.MemoryMappedFiles.Tests Fails on iOS/tvOS System.IO.MemoryMappedFiles.Tests Fails on iOS/tvOS/Wasm Jun 23, 2022
@radical radical added the WASM label Jun 23, 2022
@danmoseley danmoseley added arch-wasm WebAssembly architecture and removed WASM labels Jun 28, 2022
@ghost
Copy link

ghost commented Jun 28, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

System.IO.MemoryMappedFiles.Tests
System.IO.MemoryMappedFiles.Tests.MemoryMappedFileTests_CreateFromFile.ValidArgumentCombinationsWithPath_ModeCreate
System.IO.MemoryMappedFiles.Tests.MemoryMappedFileTests_CreateFromFile.ValidArgumentCombinationsWithStream
System.IO.MemoryMappedFiles.Tests.MemoryMappedFileTests_CreateFromFile.ValidArgumentCombinationsWithPath_ModesOpenOrCreate
System.IO.MemoryMappedFiles.Tests.MemoryMappedFileTests_CreateFromFile.ValidArgumentCombinationsWithPath_ModeCreateNew
System.IO.MemoryMappedFiles.Tests.MemoryMappedFileTests_CreateNew.ValidArgumentCombinations
System.IO.MemoryMappedFiles.Tests.MemoryMappedViewStreamTests.InvalidArguments
System.IO.MemoryMappedFiles.Tests.MemoryMappedViewAccessorTests.InvalidArguments

System.IO.MemoryMappedFiles.Tests.dll   Failed: 7

Test collection for System.IO.MemoryMappedFiles.Tests.dll
System.IO.MemoryMappedFiles.Tests.MemoryMappedFileTests_CreateFromFile.ValidArgumentCombinationsWithPath_ModeCreate
    Assert.InRange() Failure\r\nRange:  (1 - 2147483647)\r\nActual: -1
System.IO.MemoryMappedFiles.Tests.MemoryMappedFileTests_CreateFromFile.ValidArgumentCombinationsWithStream
    Assert.InRange() Failure\r\nRange:  (1 - 2147483647)\r\nActual: -1
System.IO.MemoryMappedFiles.Tests.MemoryMappedFileTests_CreateFromFile.ValidArgumentCombinationsWithPath_ModesOpenOrCreate
    Assert.InRange() Failure\r\nRange:  (1 - 2147483647)\r\nActual: -1
System.IO.MemoryMappedFiles.Tests.MemoryMappedFileTests_CreateFromFile.ValidArgumentCombinationsWithPath_ModeCreateNew
    Assert.InRange() Failure\r\nRange:  (1 - 2147483647)\r\nActual: -1
System.IO.MemoryMappedFiles.Tests.MemoryMappedFileTests_CreateNew.ValidArgumentCombinations
    Assert.InRange() Failure\r\nRange:  (1 - 2147483647)\r\nActual: -1
System.IO.MemoryMappedFiles.Tests.MemoryMappedViewStreamTests.InvalidArguments
    Assert.InRange() Failure\r\nRange:  (1 - 2147483647)\r\nActual: -1
System.IO.MemoryMappedFiles.Tests.MemoryMappedViewAccessorTests.InvalidArguments
    Assert.InRange() Failure\r\nRange:  (1 - 2147483647)\r\nActual: -1

<table>
  <tr>
    <th align="left">Author:</th>
    <td>mdh1418</td>
  </tr>
  <tr>
    <th align="left">Assignees:</th>
    <td>-</td>
  </tr>
  <tr>
    <th align="left">Labels:</th>
    <td>

`arch-wasm`, `area-System.IO`, `os-ios`, `os-tvos`

</td>
  </tr>
  <tr>
    <th align="left">Milestone:</th>
    <td>7.0.0</td>
  </tr>
</table>
</details>

@ilonatommy
Copy link
Member

I cannot reproduce for Wasm. Can I ask you @radekdoulik to check them on OSX? (https://github.com/ilonatommy/runtime/tree/enable-memoryMappedFilesTests-51375)

radical added a commit that referenced this issue Jul 9, 2022
* Use new docker images
* Silence warnings
* Bump dependencies
* Bump emscripten version
* Update dependencies
* Fix linking
* Move the link fix to default link response file

To make tests build
* Disable one more test
Affected by #51375

* Ignore link errors coming from native refs
This avoids this error, where the linker seems more strict now:
```
      [] EXEC : error : undefined symbol: _ZNKSt3__220__vector_base_commonILb1EE20__throw_length_errorEv (referenced by top-level compiled C/C++ code) [/datadisks/disk1/work/BDDD0A63/w/A3D60932/e/blz_nativeref_aot_Debug/blz_nativeref_aot_Debug.csproj]
      [] EXEC : warning : Link with `-sLLD_REPORT_UNDEFINED` to get more information on undefined symbols [/datadisks/disk1/work/BDDD0A63/w/A3D60932/e/blz_nativeref_aot_Debug/blz_nativeref_aot_Debug.csproj]
      [] EXEC : warning : To disable errors for undefined symbols use `-sERROR_ON_UNDEFINED_SYMBOLS=0` [/datadisks/disk1/work/BDDD0A63/w/A3D60932/e/blz_nativeref_aot_Debug/blz_nativeref_aot_Debug.csproj]
      [] EXEC : warning : __ZNKSt3__220__vector_base_commonILb1EE20__throw_length_errorEv may need to be added to EXPORTED_FUNCTIONS if it arrives from a system library [/datadisks/disk1/work/BDDD0A63/w/A3D60932/e/blz_nativeref_aot_Debug/blz_nativeref_aot_Debug.csproj]
      [] EXEC : error : undefined symbol: _ZNKSt3__221__basic_string_commonILb1EE20__throw_length_errorEv (referenced by top-level compiled C/C++ code) [/datadisks/disk1/work/BDDD0A63/w/A3D60932/e/blz_nativeref_aot_Debug/blz_nativeref_aot_Debug.csproj]
      [] EXEC : warning : __ZNKSt3__221__basic_string_commonILb1EE20__throw_length_errorEv may need to be added to EXPORTED_FUNCTIONS if it arrives from a system library [/datadisks/disk1/work/BDDD0A63/w/A3D60932/e/blz_nativeref_aot_Debug/blz_nativeref_aot_Debug.csproj]
      [] EXEC : error : Aborting compilation due to previous errors [/datadisks/disk1/work/BDDD0A63/w/A3D60932/e/blz_nativeref_aot_Debug/blz_nativeref_aot_Debug.csproj]
      [] emcc : error : '/datadisks/disk1/work/BDDD0A63/w/A3D60932/e/dotnet-workload/packs/Microsoft.NET.Runtime.Emscripten.3.1.12.Node.linux-x64/7.0.0-preview.6.22308.2/tools/bin/node
```
* Avoid another linker error in tests
* Disable failing test
* Try to use emscripten_force_exit in mono_wasm_exit

* Bump docker image to get newer v8
* Fix remaining conflict
* Use 3.1.12 icu again, it was lost with merge
* Revert "Try to use emscripten_force_exit in mono_wasm_exit"

This reverts commit bdba37b.

* Revert "Ignore link errors coming from native refs"
This reverts commit f2bfa1f.

* [wasm] Don't run tests on windows with v8
- We are only interested in testing with v8 on linux

This changes:
1. All the AOT tests to run with browser on windows
2. Library tests (interpreter) will run with browser, and nodejs

* Fix System.Net.Http.Functional.Tests failing due to trimming
.. on Windows/AOT:
* [wasm] Fix windows/tests/aot timeout to be same for running on browser
.. as for v8.
* Disable failing tests - issue#71877

Co-authored-by: Radek Doulik <radekdoulik@google.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
@lewing lewing modified the milestones: 7.0.0, 8.0.0 Jul 26, 2022
@ilonatommy ilonatommy removed their assignment Mar 27, 2023
@kotlarmilos
Copy link
Member

@mdh1418 I can take a look at iOS failure.

/cc: @SamMonoRT

@kotlarmilos kotlarmilos self-assigned this May 19, 2023
@kotlarmilos
Copy link
Member

The tests are passing both locally on a device and on tvOS CI pipeline. @ilonatommy If they are passing on the WASM as well, I suggest we close this issue.

@ghost ghost added in-pr There is an active PR which will close this issue when it is merged and removed in-pr There is an active PR which will close this issue when it is merged labels Jun 6, 2023
@ilonatommy
Copy link
Member

ilonatommy commented Jun 7, 2023

Wasm tests are failing when the host is browser, so in WasmTestOnBrowser scenario. For V8/node are fine, so they can be enabled.

Edit: iOS is failing on CI, so we cannot unblock the tests yet.

@kotlarmilos kotlarmilos removed their assignment Jul 12, 2023
@kotlarmilos kotlarmilos modified the milestones: 8.0.0, 9.0.0 Jul 13, 2023
@kotlarmilos kotlarmilos self-assigned this Jul 13, 2023
@kotlarmilos kotlarmilos added the disabled-test The test is disabled in source code against the issue label Jul 13, 2023
@kotlarmilos kotlarmilos modified the milestones: 9.0.0, Future Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-wasm WebAssembly architecture area-System.IO disabled-test The test is disabled in source code against the issue os-ios Apple iOS os-tvos Apple tvOS
Projects
None yet
Development

No branches or pull requests

7 participants