-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Logging Source Generator to MS.Extensions.Logging.Abstractions #52222
Comments
Tagging subscribers to this area: @maryamariyan Issue DetailsLibrary authors today can use the However, in order to use the new Logging source generation feature, they now need to reference We should move the source generator and attribute to
|
@eerhardt OK to work on this without discussing over API review meetings? |
If we have consensus with stakeholders, I think this could be an "email only" API review. None of the API shape would change, just which assembly it is contained in. I guess I would get buy-off with all the stakeholders before working on it. |
+1 on this moving |
Seems fine to me. Moving things is fine in previews without type-forwards. I don’t even think there is a case where folks would notice the move, since there is no scenario for runtime consumption nor design-time binary consumption of the type from it's old location. |
* Move Logging Generator and LoggerMessageAttribute to Logging.Abstractions Fixes: #52222
Library authors today can use the
LoggerMessage.Define
APIs and log messages by only referencingMicrosoft.Extensions.Logging.Abstractions
.However, in order to use the new Logging source generation feature, they now need to reference
Microsoft.Extensions.Logging
as well.We should move the source generator and attribute to
Microsoft.Extensions.Logging.Abstractions
, so library authors don't need to change their references to use this new feature.The text was updated successfully, but these errors were encountered: