Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Logging Source Generator to MS.Extensions.Logging.Abstractions #52222

Closed
eerhardt opened this issue May 3, 2021 · 5 comments · Fixed by #52256
Closed

Move Logging Source Generator to MS.Extensions.Logging.Abstractions #52222

eerhardt opened this issue May 3, 2021 · 5 comments · Fixed by #52256

Comments

@eerhardt
Copy link
Member

eerhardt commented May 3, 2021

Library authors today can use the LoggerMessage.Define APIs and log messages by only referencing Microsoft.Extensions.Logging.Abstractions.

However, in order to use the new Logging source generation feature, they now need to reference Microsoft.Extensions.Logging as well.

We should move the source generator and attribute to Microsoft.Extensions.Logging.Abstractions, so library authors don't need to change their references to use this new feature.

@ghost
Copy link

ghost commented May 3, 2021

Tagging subscribers to this area: @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details

Library authors today can use the LoggerMessage.Define APIs and log messages by only referencing Microsoft.Extensions.Logging.Abstractions.

However, in order to use the new Logging source generation feature, they now need to reference Microsoft.Extensions.Logging as well.

We should move the source generator and attribute to Microsoft.Extensions.Logging.Abstractions, so library authors don't need to change their references to use this new feature.

Author: eerhardt
Assignees: -
Labels:

area-Extensions-Logging

Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label May 3, 2021
@maryamariyan maryamariyan added this to the 6.0.0 milestone May 3, 2021
@maryamariyan maryamariyan removed the untriaged New issue has not been triaged by the area owner label May 3, 2021
@maryamariyan
Copy link
Member

@eerhardt OK to work on this without discussing over API review meetings?

@eerhardt
Copy link
Member Author

eerhardt commented May 4, 2021

If we have consensus with stakeholders, I think this could be an "email only" API review. None of the API shape would change, just which assembly it is contained in.

I guess I would get buy-off with all the stakeholders before working on it.

@davidfowl
Copy link
Member

+1 on this moving

maryamariyan added a commit to maryamariyan/runtime that referenced this issue May 4, 2021
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label May 4, 2021
@ericstj
Copy link
Member

ericstj commented May 4, 2021

Seems fine to me. Moving things is fine in previews without type-forwards. I don’t even think there is a case where folks would notice the move, since there is no scenario for runtime consumption nor design-time binary consumption of the type from it's old location.

maryamariyan added a commit that referenced this issue May 5, 2021
* Move Logging Generator and LoggerMessageAttribute to Logging.Abstractions

Fixes: #52222
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label May 5, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants