Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metadata-update] Add support for deltas with CustomAttributes modifications #52993

Closed
lambdageek opened this issue May 19, 2021 · 3 comments · Fixed by #79044
Closed

[metadata-update] Add support for deltas with CustomAttributes modifications #52993

lambdageek opened this issue May 19, 2021 · 3 comments · Fixed by #79044
Assignees
Labels
area-EnC-mono Hot Reload for WebAssembly, iOS/Android, etc
Milestone

Comments

@lambdageek
Copy link
Member

lambdageek commented May 19, 2021

For methods/classes/etc.

In mono_custom_attrs_from_index_checked we need to do a proper iteration that uses a metadata-update aware bounds check, at least. (see the FIXME).

Note that normally the CustomAttribtues table is assumed sorted by the Parent column and assumed contiguous for a given parent. So if we add new attributes for an existing parent or new parents that are out of order with respect to the existing table, we will need some lookaside table on a slow path.

The correlated CoreCLR issue is #53066 (and in particular the comments with some tables that show what can go wrong)

Contributes to #57365

@lambdageek lambdageek added the area-EnC-mono Hot Reload for WebAssembly, iOS/Android, etc label May 19, 2021
@lambdageek lambdageek added this to the 6.0.0 milestone May 19, 2021
@lambdageek lambdageek self-assigned this May 19, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label May 19, 2021
@marek-safar marek-safar removed the untriaged New issue has not been triaged by the area owner label Jun 2, 2021
@lambdageek
Copy link
Member Author

We would also need to support deletion of custom attributes, perhaps using the EnCLog Delete function code #53635

@lambdageek lambdageek changed the title [metadata-update] Add support for adding custom attributes [metadata-update] Add support for deltas with CustomAttributes modifications Jun 2, 2021
@lambdageek
Copy link
Member Author

In particular, we may need to be able to consume the various annotations that get emitted for nullability.

@lambdageek lambdageek modified the milestones: 6.0.0, 7.0.0 Aug 13, 2021
@SamMonoRT SamMonoRT modified the milestones: 7.0.0, 8.0.0 Aug 12, 2022
lambdageek added a commit to lambdageek/runtime that referenced this issue Nov 30, 2022
…r async

The async test was marked with the CustomAttributes tracking issue, but it's
actually unrelated.

Fixes dotnet#52993
@lambdageek
Copy link
Member Author

This is actually done - we already say we support the capability. There were just some tests that haven't been enabled. I have a PR to remove the ActiveIssues

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Nov 30, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Dec 1, 2022
lambdageek added a commit that referenced this issue Dec 1, 2022
…r async (#79044)

The async test was marked with the CustomAttributes tracking issue, but it's
actually unrelated.

Fixes #52993
@ghost ghost locked as resolved and limited conversation to collaborators Dec 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-EnC-mono Hot Reload for WebAssembly, iOS/Android, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants