Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventSourceActivity doesn't seem to be used anywhere #53177

Closed
vitek-karas opened this issue May 24, 2021 · 3 comments · Fixed by #55575
Closed

EventSourceActivity doesn't seem to be used anywhere #53177

vitek-karas opened this issue May 24, 2021 · 3 comments · Fixed by #55575

Comments

@vitek-karas
Copy link
Member

The EventSourceActivity class doesn't seem to be used by anything in CoreLib. Since we run linker on corelib during build, the class is actually removed from the product and can't be used by tests or product - which sort of proves that it's not needed.
Should we remove it?

@ghost
Copy link

ghost commented May 24, 2021

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
See info in area-owners.md if you want to be subscribed.

Issue Details

The EventSourceActivity class doesn't seem to be used by anything in CoreLib. Since we run linker on corelib during build, the class is actually removed from the product and can't be used by tests or product - which sort of proves that it's not needed.
Should we remove it?

Author: vitek-karas
Assignees: -
Labels:

area-System.Diagnostics.Tracing

Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label May 24, 2021
@tommcdon tommcdon removed the untriaged New issue has not been triaged by the area owner label May 24, 2021
@tommcdon tommcdon added this to the 6.0.0 milestone May 24, 2021
@noahfalk
Copy link
Member

This code looks dead to me. I'd say remove it unless @brianrob responds back with a hidden use-case.

cc @josalem

@brianrob
Copy link
Member

Looks dead to me as well. This looks like it was part of the TraceLogging work, and I know that there was some pull-back of the public facing surface at this time, so that's probably what happened here. Let's remove it.

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 13, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 13, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants