Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure Interop\\LayoutClass\\LayoutClassTest\\LayoutClassTest.cmd #54316

Closed
VincentBu opened this issue Jun 17, 2021 · 9 comments
Closed
Assignees
Labels
arch-arm32 arch-arm64 arch-x64 arch-x86 area-crossgen2-coreclr blocking-outerloop Blocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs os-linux Linux OS (any supported distro) os-mac-os-x macOS aka OSX os-windows untriaged New issue has not been triaged by the area owner

Comments

@VincentBu
Copy link
Contributor

Run: runtime-coreclr outerloop 20210616.5

Failed test:

R2R-CG2 windows x86 Checked no_tiered_compilation @ Windows.10.Amd64.Open

- Interop\\LayoutClass\\LayoutClassTest\\LayoutClassTest.cmd

Error message:

Could Not Find C:\h\w\B55F09AF\w\B2BF099E\e\Interop\LayoutClass\LayoutClassTest\LayoutClassNative.dll.rsp
Could Not Find C:\h\w\B55F09AF\w\B2BF099E\e\Interop\LayoutClass\LayoutClassTest\LayoutClassTest.dll.rsp
Could Not Find C:\h\w\B55F09AF\w\B2BF099E\e\Interop\LayoutClass\LayoutClassTest\TestLibrary.dll.rsp

Assert failure(PID 3660 [0x00000e4c], Thread: 4572 [0x11dc]): Verify_FieldOffset 'PInvokeTests.SeqDerivedClass.a' Field offset 8!=4(actual) || baseOffset 8!=8(actual)

CORECLR! LoadDynamicInfoEntry + 0xB34 (0x7069d3d4)
CORECLR! Module::FixupNativeEntry + 0x1A0 (0x705d66e0)
CORECLR! Module::FixupDelayListAux<Module ,int (__thiscall Module::)(CORCOMPILE_IMPORT_SECTION *,unsigned long,unsigned long *)> + 0x34A (0x7079b4e8)
CORECLR! ReadyToRunInfo::GetEntryPoint + 0x223 (0x7079c910)
CORECLR! MethodDesc::GetPrecompiledR2RCode + 0x9A (0x70727045)
CORECLR! MethodDesc::GetPrecompiledCode + 0x8C (0x70726e66)
CORECLR! MethodDesc::PrepareILBasedCode + 0x243 (0x707293e8)
CORECLR! MethodDesc::PrepareCode + 0xB0 (0x70729173)
CORECLR! CodeVersionManager::PublishVersionableCodeIfNecessary + 0x25D (0x7061e3a0)
CORECLR! MethodDesc::DoPrestub + 0x6D9 (0x70724698)
File: D:\workspace_work\1\s\src\coreclr\vm\jitinterface.cpp Line: 14251
Image: C:\h\w\B55F09AF\p\corerun.exe

Return code:      1
Raw output file:      C:\h\w\B55F09AF\w\B2BF099E\uploads\Reports\Interop.LayoutClass\LayoutClassTest\LayoutClassTest.output.txt
Raw output:
BEGIN EXECUTION
LayoutClassNative.dll
LayoutClassTest.dll
TestLibrary.dll
3 file(s) copied.
Response file: C:\h\w\B55F09AF\w\B2BF099E\e\Interop\LayoutClass\LayoutClassTest\LayoutClassNative.dll.rsp
C:\h\w\B55F09AF\w\B2BF099E\e\Interop\LayoutClass\LayoutClassTest\IL-CG2\LayoutClassNative.dll
-o:C:\h\w\B55F09AF\w\B2BF099E\e\Interop\LayoutClass\LayoutClassTest\LayoutClassNative.dll
--targetarch:x86
--verify-type-and-field-layout
-r:C:\h\w\B55F09AF\p\System..dll
-r:C:\h\w\B55F09AF\p\Microsoft..dll
-r:C:\h\w\B55F09AF\p\mscorlib.dll
-r:C:\h\w\B55F09AF\p\netstandard.dll
-O
" "dotnet" "C:\h\w\B55F09AF\p\crossgen2\crossgen2.dll" @"C:\h\w\B55F09AF\w\B2BF099E\e\Interop\LayoutClass\LayoutClassTest\LayoutClassNative.dll.rsp"   -r:C:\h\w\B55F09AF\w\B2BF099E\e\Interop\LayoutClass\LayoutClassTest\IL-CG2*.dll"
No input files are loadable
Response file: C:\h\w\B55F09AF\w\B2BF099E\e\Interop\LayoutClass\LayoutClassTest\LayoutClassTest.dll.rsp
C:\h\w\B55F09AF\w\B2BF099E\e\Interop\LayoutClass\LayoutClassTest\IL-CG2\LayoutClassTest.dll
-o:C:\h\w\B55F09AF\w\B2BF099E\e\Interop\LayoutClass\LayoutClassTest\LayoutClassTest.dll
--targetarch:x86
--verify-type-and-field-layout
-r:C:\h\w\B55F09AF\p\System..dll
-r:C:\h\w\B55F09AF\p\Microsoft..dll
-r:C:\h\w\B55F09AF\p\mscorlib.dll
-r:C:\h\w\B55F09AF\p\netstandard.dll
-O
" "dotnet" "C:\h\w\B55F09AF\p\crossgen2\crossgen2.dll" @"C:\h\w\B55F09AF\w\B2BF099E\e\Interop\LayoutClass\LayoutClassTest\LayoutClassTest.dll.rsp"   -r:C:\h\w\B55F09AF\w\B2BF099E\e\Interop\LayoutClass\LayoutClassTest\IL-CG2*.dll -r:C:\h\w\B55F09AF\w\B2BF099E\e\Interop\LayoutClass\LayoutClassTest\IL-CG2*.dll"
Emitting R2R PE file: C:\h\w\B55F09AF\w\B2BF099E\e\Interop\LayoutClass\LayoutClassTest\LayoutClassTest.dll
Response file: C:\h\w\B55F09AF\w\B2BF099E\e\Interop\LayoutClass\LayoutClassTest\TestLibrary.dll.rsp
C:\h\w\B55F09AF\w\B2BF099E\e\Interop\LayoutClass\LayoutClassTest\IL-CG2\TestLibrary.dll
-o:C:\h\w\B55F09AF\w\B2BF099E\e\Interop\LayoutClass\LayoutClassTest\TestLibrary.dll
--targetarch:x86
--verify-type-and-field-layout
-r:C:\h\w\B55F09AF\p\System..dll
-r:C:\h\w\B55F09AF\p\Microsoft..dll
-r:C:\h\w\B55F09AF\p\mscorlib.dll
-r:C:\h\w\B55F09AF\p\netstandard.dll
-O
" "dotnet" "C:\h\w\B55F09AF\p\crossgen2\crossgen2.dll" @"C:\h\w\B55F09AF\w\B2BF099E\e\Interop\LayoutClass\LayoutClassTest\TestLibrary.dll.rsp"   -r:C:\h\w\B55F09AF\w\B2BF099E\e\Interop\LayoutClass\LayoutClassTest\IL-CG2*.dll -r:C:\h\w\B55F09AF\w\B2BF099E\e\Interop\LayoutC


Stack trace
   at Interop_LayoutClass._LayoutClassTest_LayoutClassTest_._LayoutClassTest_LayoutClassTest_cmd() in Interop.LayoutClass.XUnitWrapper.dll:token 0x6000004+0x284
@jkoritzinsky
Copy link
Member

cc: @trylek

@trylek trylek self-assigned this Jun 17, 2021
@trylek
Copy link
Member

trylek commented Jun 17, 2021

Apparently we need to adjust Crossgen2 in accordance with Jeremy's runtime change

#54235

I'll take a look, thankfully it's just one test failing consistently the same way on all platforms, that should be easy to fix.

@BruceForstall BruceForstall added the blocking-outerloop Blocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs label Jun 17, 2021
@BruceForstall
Copy link
Member

There's another test failing. Same issue, different result, or not?

https://dev.azure.com/dnceng/public/_build/results?buildId=1191223&view=ms.vss-test-web.build-test-results-tab&runId=35762252&paneView=debug

R2R-CG2 windows x64 Checked no_tiered_compilation

(and other legs)

Interop\COM\NETClients\ComDisabled\NETClientComDisabled\NETClientComDisabled.cmd

   Interop\COM\NETClients\ComDisabled\NETClientComDisabled\NETClientComDisabled.cmd [FAIL]
      Could Not Find C:\h\w\A9AB0918\w\A6780901\e\Interop\COM\NETClients\ComDisabled\NETClientComDisabled\COMNativeServer.dll.rsp
      Could Not Find C:\h\w\A9AB0918\w\A6780901\e\Interop\COM\NETClients\ComDisabled\NETClientComDisabled\NETClientComDisabled.dll.rsp
      Could Not Find C:\h\w\A9AB0918\w\A6780901\e\Interop\COM\NETClients\ComDisabled\NETClientComDisabled\TestLibrary.dll.rsp
      Unhandled exception. System.NotSupportedException: Built-in COM has been disabled via a feature switch. See https://aka.ms/dotnet-illink/com for more information.
         at NetClient.Program.ActivateServer() in NETClientComDisabled.dll:token 0x600007f+0x0
         at NetClient.Program.Main(String[] doNotUse) in NETClientComDisabled.dll:token 0x600007e+0xb
      
      Return code:      1
      Raw output file:      C:\h\w\A9AB0918\w\A6780901\uploads\Reports\Interop.COM\NETClients\ComDisabled\NETClientComDisabled\NETClientComDisabled.output.txt
      Raw output:
      BEGIN EXECUTION
      COMNativeServer.dll
      NETClientComDisabled.dll
      TestLibrary.dll
              3 file(s) copied.
      Response file: C:\h\w\A9AB0918\w\A6780901\e\Interop\COM\NETClients\ComDisabled\NETClientComDisabled\\COMNativeServer.dll.rsp
      C:\h\w\A9AB0918\w\A6780901\e\Interop\COM\NETClients\ComDisabled\NETClientComDisabled\IL-CG2\COMNativeServer.dll
      -o:C:\h\w\A9AB0918\w\A6780901\e\Interop\COM\NETClients\ComDisabled\NETClientComDisabled\\COMNativeServer.dll
      --targetarch:x64
      --verify-type-and-field-layout
      -r:C:\h\w\A9AB0918\p\System.*.dll
      -r:C:\h\w\A9AB0918\p\Microsoft.*.dll
      -r:C:\h\w\A9AB0918\p\mscorlib.dll
      -r:C:\h\w\A9AB0918\p\netstandard.dll
      -O
      " "dotnet" "C:\h\w\A9AB0918\p\crossgen2\crossgen2.dll" @"C:\h\w\A9AB0918\w\A6780901\e\Interop\COM\NETClients\ComDisabled\NETClientComDisabled\\COMNativeServer.dll.rsp"   -r:C:\h\w\A9AB0918\w\A6780901\e\Interop\COM\NETClients\ComDisabled\NETClientComDisabled\IL-CG2\*.dll"
      No input files are loadable
      Response file: C:\h\w\A9AB0918\w\A6780901\e\Interop\COM\NETClients\ComDisabled\NETClientComDisabled\\NETClientComDisabled.dll.rsp
      C:\h\w\A9AB0918\w\A6780901\e\Interop\COM\NETClients\ComDisabled\NETClientComDisabled\IL-CG2\NETClientComDisabled.dll
      -o:C:\h\w\A9AB0918\w\A6780901\e\Interop\COM\NETClients\ComDisabled\NETClientComDisabled\\NETClientComDisabled.dll
      --targetarch:x64
      --verify-type-and-field-layout
      -r:C:\h\w\A9AB0918\p\System.*.dll
      -r:C:\h\w\A9AB0918\p\Microsoft.*.dll
      -r:C:\h\w\A9AB0918\p\mscorlib.dll
      -r:C:\h\w\A9AB0918\p\netstandard.dll
      -O
      " "dotnet" "C:\h\w\A9AB0918\p\crossgen2\crossgen2.dll" @"C:\h\w\A9AB0918\w\A6780901\e\Interop\COM\NETClients\ComDisabled\NETClientComDisabled\\NETClientComDisabled.dll.rsp"   -r:C:\h\w\A9AB0918\w\A6780901\e\Interop\COM\NETClients\ComDisabled\NETClientComDisabled\IL-CG2\*.dll -r:C:\h\w\A9AB0918\w\A6780901\e\Interop\COM\NETClients\ComDisabled\NETClientComDisabled\IL-CG2\*.dll"
      Emitting R2R PE file: C:\h\w\A9AB0918\w\A6780901\e\Interop\COM\NETClients\ComDisabled\NETClientComDisabled\\NETClientComDisabled.dll
      Response file: C:\h\w\A9AB0918\w\A6780901\e\Interop\COM\NETClients\ComDisabled\NETClientComDisabled\\TestLibrary.dll.rsp
      C:\h\w\A9AB0918\w\A6780901\e\Interop\COM\NETClients\ComDisabled\NETClientComDisabled\IL-CG2\TestLibrary.dll
      -o:C:\h\w\A9AB0918\w\A6780901\e\Interop\COM\NETClients\ComDisabled\NETClientComDisabled\\TestLibrary.dll
      --targetarch:x64
      --verify-type-and-field-layout
      -r:C:\h\w\A9AB0918\p\System.*.dll
      -r:C:\h\w\A9AB0918\p\Microsoft.*.dll
      -r:C:\h\w\A9AB0918\p\mscorlib.dll
      -r:C:\h\w\A9AB0918\p\netstandard.dll
      -O
      " "dotnet" "C:\h\w\A9AB0918\p\crossgen2\crossgen2.dll" @"C:\h\w\A9AB0918\w\A6780901\e\Interop\COM\NETClients\ComDisabled\NETClientComDisabled\\TestLibrary.dll.rsp"   -r:C:\h\w\A9AB0918\w\A6780901\e\Interop\COM\NETClients\ComDisabled\NETClientComDisabled\IL-CG2\*.dll -r:C:\h\w\A9AB0918\w\A6780901\e\Interop\COM\NETClients\ComDisabled\NETClientComDisabled\IL-CG2\*.dll -r:C:\h\w\A9AB0918\w\A6780901\e\Interop\COM\NETClients\ComDisabled\NETClientComDisabled\IL-CG2\*.dll"
      Emitting R2R PE file: C:\h\w\A9AB0918\w\A6780901\e\Interop\COM\NETClients\ComDisabled\NETClientComDisabled\\TestLibrary.dll
       "C:\h\w\A9AB0918\p\corerun.exe" -p "System.Runtime.InteropServices.BuiltInComInterop.IsSupported=false" NETClientComDisabled.dll 
      Expected: 100
      Actual: -532462766
      END EXECUTION - FAILED
      FAILED

@trylek
Copy link
Member

trylek commented Jun 17, 2021

Hmm, I have no idea whatsoever how this could be related to CG2, please let me know if that's something we need to investigate in its context.

@trylek
Copy link
Member

trylek commented Jun 17, 2021

/cc @dotnet/crossgen-contrib

@jkotas
Copy link
Member

jkotas commented Jun 17, 2021

System.NotSupportedException: Built-in COM has been disabled via a feature switch.

This is different issue. cc @LakshanF

@BruceForstall
Copy link
Member

ok, I created #54379 for the other issue.

@mangod9
Copy link
Member

mangod9 commented Jul 20, 2021

Is there any issue which still needs fixing in crossgen2?

@trylek
Copy link
Member

trylek commented Jul 20, 2021

I believe this bug was fixed with #53424; I have double-checked that it's not blocked in issues.targets and it passes locally on Windows x86 release as of the most recent dotnet/runtime main.

@trylek trylek closed this as completed Jul 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-arm32 arch-arm64 arch-x64 arch-x86 area-crossgen2-coreclr blocking-outerloop Blocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs os-linux Linux OS (any supported distro) os-mac-os-x macOS aka OSX os-windows untriaged New issue has not been triaged by the area owner
Projects
None yet
Development

No branches or pull requests

6 participants