Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QUIC: support CipherSuitesPolicy #55378

Closed
wfurt opened this issue Jul 9, 2021 · 2 comments · Fixed by #67239
Closed

QUIC: support CipherSuitesPolicy #55378

wfurt opened this issue Jul 9, 2021 · 2 comments · Fixed by #67239
Labels
area-System.Net.Quic enhancement Product code improvement that does NOT require public API changes/additions
Milestone

Comments

@wfurt
Copy link
Member

wfurt commented Jul 9, 2021

This was originally tracked in #49574. Since microsoft/msquic#1430 is done, we should be able to implement it. QUIC only support three cipher suites and requires TLS 1.3. So unlike general SslStream where one may want to eliminate or selectively add weak cipher the value is low for QUIC.

The CipherSuitesPolicy is currently ignored if set. We could possibly throw PNSP to make it more obvious that it is not supported at the moment.

@wfurt wfurt added this to the Future milestone Jul 9, 2021
@ghost
Copy link

ghost commented Jul 9, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

This was originally tracked in #49574. Since microsoft/msquic#1430 is done, we should be able to implement it. QUIC only support three cipher suites and requires TLS 1.3. So unlike general SslStream where one may want to eliminate or selectively add weak cipher the value is low for QUIC.

The CipherSuitesPolicy is currently ignored if set. We could possibly throw PNSP to make it more obvious that it is not supported at the moment.

Author: wfurt
Assignees: -
Labels:

area-System.Net.Quic

Milestone: Future

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jul 9, 2021
@ManickaP ManickaP removed the untriaged New issue has not been triaged by the area owner label Jul 9, 2021
@karelz karelz added the enhancement Product code improvement that does NOT require public API changes/additions label Oct 26, 2021
@karelz karelz modified the milestones: Future, 7.0.0 Oct 26, 2021
@karelz
Copy link
Member

karelz commented Oct 26, 2021

Triage: We need to either throw or work correctly. No-op is not sufficient for 7.0 (current status).
Something sets it by default - either our tests, or HttpClient.
Work is small, so we should just do it.

@ManickaP ManickaP self-assigned this Feb 16, 2022
@ManickaP ManickaP removed their assignment Mar 23, 2022
@rzikm rzikm self-assigned this Mar 23, 2022
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Mar 28, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Apr 6, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 6, 2022
@rzikm rzikm removed their assignment May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net.Quic enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants