Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Cipher Suite Allow List #1430

Merged
merged 6 commits into from
Apr 4, 2021
Merged

Support Cipher Suite Allow List #1430

merged 6 commits into from
Apr 4, 2021

Conversation

anrossi
Copy link
Contributor

@anrossi anrossi commented Apr 3, 2021

Add support to Schannel and OpenSSL to explicitly indicate which TLS1.3 cipher suites to use. Closes #109

src/inc/msquic.h Outdated Show resolved Hide resolved
@nibanks nibanks merged commit e1f7169 into main Apr 4, 2021
@nibanks nibanks deleted the anrossi/cipher-suite-config branch April 4, 2021 15:34
@rzikm
Copy link
Member

rzikm commented Mar 28, 2022

Hi, @anrossi, was there a specific reason to not support TLS_AES_128_CCM_SHA256? it is listed among the TLS 1.3 cipher suites and QUIC-TLS RFC only prohibits TLS_AES_128_CCM_8_SHA256:

QUIC can use any of the cipher suites defined in [TLS13] with the
exception of TLS_AES_128_CCM_8_SHA256. A cipher suite MUST NOT be
negotiated unless a header protection scheme is defined for the
cipher suite. This document defines a header protection scheme for
all cipher suites defined in [TLS13] aside from
TLS_AES_128_CCM_8_SHA256. These cipher suites have a 16-byte
authentication tag and produce an output 16 bytes larger than their
input.

@anrossi
Copy link
Contributor Author

anrossi commented Mar 31, 2022

@rzikm Historically, we've supported AES-GCM and ChaCha20-Poly1305 because those were the algorithms in both TLS libraries we were originally using. There wasn't a pressing need to support AES-CCM, so we haven't done the crypto work to add support.
If someone came to us asking to support AES-CCM, or had a PR adding support, we'd do the work/accept it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Option for Ciphers to QUIC_CREDENTIAL_CONFIG
3 participants