Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QUIC] Merge several version of stream SendAsync #55818

Closed
ManickaP opened this issue Jul 16, 2021 · 1 comment · Fixed by #68772
Closed

[QUIC] Merge several version of stream SendAsync #55818

ManickaP opened this issue Jul 16, 2021 · 1 comment · Fixed by #68772
Assignees
@rzikm
Labels
area-System.Net.Quic enhancement Product code improvement that does NOT require public API changes/additions
Milestone
7.0.0

Comments

@ManickaP
Copy link
Member

ManickaP commented Jul 16, 2021 •
edited by karelz
Loading

Why do we have 3 version of sending? We should unite as much as possible.
Are we even testing all of them?
One of them is for Kestrel - SendReadOnlySequenceAsync

Source: Code review session
@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.Net.Quic untriaged New issue has not been triaged by the area owner labels Jul 16, 2021
@ghost
Copy link

ghost commented Jul 16, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Why do we have 3 version of sending? We should unite as much as possible.
Are we even testing all of them?
One of them is for Kestrel - SendReadOnlySequenceAsync

Author: ManickaP
Assignees: -
Labels:

area-System.Net.Quic, untriaged
Milestone: -

@ManickaP ManickaP added this to the Future milestone Jul 16, 2021
@ManickaP ManickaP removed the untriaged New issue has not been triaged by the area owner label Jul 16, 2021
@ManickaP ManickaP mentioned this issue Jul 16, 2021
Closed
@karelz karelz added the enhancement Product code improvement that does NOT require public API changes/additions label Nov 16, 2021
@karelz karelz modified the milestones: Future, 7.0.0 Nov 16, 2021
@rzikm rzikm self-assigned this May 2, 2022
@rzikm rzikm mentioned this issue May 2, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label May 2, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label May 24, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rzikm rzikm

Labels
area-System.Net.Quic enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Merge several version of MsQuicStream SendAsync code rzikm/dotnet-runtime
3 participants
@karelz @ManickaP @rzikm