notes #55666
Closed
notes #55666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManickaP
added
the
NO-MERGE
|
Tagging subscribers to this area: @dotnet/ncl Issue Details
|
|
thanks for taking notes @ManickaP. Should? we merge it to keep it with the code? |
I'll transform the comment like notes into real comments and the ones which are pointing out problems into issues. We should not merge this PR. I'll make a different one. Let's not pollute our code base with meeting notes. |
ManickaP
commented
Jul 16, 2021
| @@ -30,7 +32,11 @@ internal sealed class MsQuicStream : QuicStreamProvider | |||
|
|
|||
| private sealed class State | |||
| { | |||
| // CR: We could laverage DangerousAddRef to handle relation between connection and stream and properly order calls to close. | |||
| @@ -50,6 +56,7 @@ private sealed class State | |||
| // set when ReadState.PendingRead: | |||
| public Memory<byte> ReceiveUserBuffer; | |||
| public CancellationTokenRegistration ReceiveCancellationRegistration; | |||
| // CR: Potentially we could get rid of back reference to the parent object since we don't care about keeping them alive while async msquic call is happening. | |||
| @@ -65,12 +72,16 @@ private sealed class State | |||
| // Resettable completions to be used for multiple calls to send. | |||
| public readonly ResettableCompletionSource<uint> SendResettableCompletionSource = new ResettableCompletionSource<uint>(); | |||
|
|
|||
| // CR: We should get rid off it, we're not interested in it. | |||
| public ShutdownWriteState ShutdownWriteState; | ||
|
|
||
| // Set once writes have been shutdown. | ||
| // CR: We should get rid of this |
| public readonly TaskCompletionSource ShutdownWriteCompletionSource = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously); | ||
|
|
||
| // CR: Shutdown should be merged into CloseAsync. |
| @@ -286,6 +307,8 @@ private CancellationTokenRegistration HandleWriteStartState(CancellationToken ca | |||
| } | |||
|
|
|||
| // if token was already cancelled, this would execute synchronously | |||
| // CR: we need to track the registration and dispose it even in case of exception thrown outside of this method. | |||
| @@ -318,6 +341,7 @@ private CancellationTokenRegistration HandleWriteStartState(CancellationToken ca | |||
| throw new QuicStreamAbortedException(_state.SendErrorCode); | |||
| } | |||
|
|
|||
| // CR: this should be some other exception, we should throw OCE unless CT has been fired. | |||
| @@ -555,6 +579,7 @@ private void StartShutdown(QUIC_STREAM_SHUTDOWN_FLAGS flags, long errorCode) | |||
| QuicExceptionHelpers.ThrowIfFailed(status, "StreamShutdown failed."); | |||
| } | |||
|
|
|||
| // CR: We should get rid of this | |||
| @@ -1146,6 +1171,8 @@ private static void CleanupSendState(State state) | |||
| } | |||
|
|
|||
| // TODO prevent overlapping sends or consider supporting it. | |||
| // CR: Why do we have 3 version of sending? We should unite as much as possible. | |||
| @@ -1200,6 +1227,7 @@ private static void CleanupSendState(State state) | |||
| return _state.SendResettableCompletionSource.GetTypelessValueTask(); | |||
| } | |||
|
|
|||
| // CR: for kestrel | |||
ManickaP
force-pushed
the
mapichov/code_review
branch
2 times, most recently
from
53eb5cc
to
e672c47
Compare
|
And comments are here: #55819 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @geoffkizer @CarnaViire @wfurt