Minor QUIC API changes

[geoffkizer]

Remove ShutdownWriteCompleted()
Rename Shutdown() to CompleteWrites()

[dotnet-issue-labeler]

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

[ghost]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Remove ShutdownWriteComplete()
Rename Shutdown() to CompleteWrites()

Author:	geoffkizer
Assignees:	-
Labels:	area-System.Net, new-api-needs-documentation
Milestone:	-

[wfurt]

/azp run

[azure-pipelines]

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

[wfurt]

/azp run runtime

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[JamesNK]

While you're changing API, could you add Async suffic to the async methods? e.g. ShutdownCompleted -> ShutdownCompletedAsync.

[wfurt]

Shutdown has pretty standard meaning but we may do something different here. SslStream has ShutdownAsync.

The check and azp seems busted ;(

[geoffkizer]

The check and azp seems busted ;(

And what a perfect time for it, too :)

[geoffkizer]

ShutdownCompleted -> ShutdownCompletedAsync.

We are still discussing whether ShutdownCompleted will go away entirely and be replaced by CloseAsync.

If it doesn't, we can certainly look at renaming this.

[ghost]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Remove ShutdownWriteCompleted()
Rename Shutdown() to CompleteWrites()

Author:	geoffkizer
Assignees:	-
Labels:	area-System.Net.Quic, new-api-needs-documentation
Milestone:	-

[karelz]

I thought we decided to push QUIC APIs updates to .NET 7, unless they are must-have for our functional and reliability goals in .NET 6.
@geoffkizer is this one necessary?

We need to keep in mind that while renames are good clean up, it has affect on ASP.NET side as they need to react. Given where we are in the release (almost past platform complete as of today), that may be problematic.
Let's talk about it in today's meeting more ...

[karelz]

Triage: We are fine with removing the dead code.
The renames are not complete and we will need more in .NET 7, let's wait with them all for .NET 7.

[geoffkizer]

We need to keep in mind that while renames are good clean up, it has affect on ASP.NET side as they need to react. Given where we are in the release (almost past platform complete as of today), that may be problematic.

I discussed this previously with @JamesNK and he said it was fine to do. In fact as you can see, he's asking for more API renames above :)

[geoffkizer]

Okay, I punted the Shutdown rename and reposted this PR here: #55981