-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Perf] Changes: about 10k size increase in system.test.json.dll #55937
Comments
Tagging subscribers to 'size-reduction': @eerhardt, @SamMonoRT, @marek-safar Issue DetailsDescriptionabout 10k size increase in system.test.json.dll ConfigurationAll Regression?yes DataRun Information
|
This issue doesn't have as much information as previous issues.
|
Tagging subscribers to this area: @eiriktsarpalis, @layomia Issue DetailsDescriptionabout 10k size increase in system.test.json.dll ConfigurationAll Regression?yes DataRun Information
|
This could very well be #55108, as it is in the before and after commit range. |
The reported size regression is an expected side-effect of new features being added to the serializer. I have submitted #55991 which somewhat mitigates the issue (contributing ~2K of uncompressed size reduction, ~100B compressed). After conversation with @eerhardt, I'm going to close this issue as by-design. |
Description
about 10k size increase in system.test.json.dll
Configuration
All
Regression?
yes
Data
Run Information
![graph](https://camo.githubusercontent.com/92b822b6b73de2ad9d5322c5220b17a72e4e6bf94930eba50509a5e0adccd7de/68747470733a2f2f707673636d6475706c6f61642e626c6f622e636f72652e77696e646f77732e6e65742f6175746f66696c657265706f72742f6175746f66696c657265706f7274732f30375f31375f323032312f726566732f68656164732f6d61696e5f7836345f7562756e747525323031382e30345f436f6d70696c6174696f6e4d6f64653d7761736d5f52756e4b696e643d626c617a6f725f7363656e6172696f735f52656772657373696f6e2f534f442532302d2532304d696e696d756d253230426c617a6f7225323054656d706c6174652532302d2532305075626c6973685f312e706e67)
![graph](https://camo.githubusercontent.com/9dffd6fbbea31f82bf7fd3e0a20951b95108c0d8d0cc1b1bddc54516004f9840/68747470733a2f2f707673636d6475706c6f61642e626c6f622e636f72652e77696e646f77732e6e65742f6175746f66696c657265706f72742f6175746f66696c657265706f7274732f30375f31375f323032312f726566732f68656164732f6d61696e5f7836345f7562756e747525323031382e30345f436f6d70696c6174696f6e4d6f64653d7761736d5f52756e4b696e643d626c617a6f725f7363656e6172696f735f52656772657373696f6e2f534f442532302d2532304d696e696d756d253230426c617a6f7225323054656d706c6174652532302d2532305075626c6973685f322e706e67)
![graph](https://camo.githubusercontent.com/8d49a5e5676456e624e24118463de75b7d92fed55a24fe0d1488fd52c817baf3/68747470733a2f2f707673636d6475706c6f61642e626c6f622e636f72652e77696e646f77732e6e65742f6175746f66696c657265706f72742f6175746f66696c657265706f7274732f30375f31375f323032312f726566732f68656164732f6d61696e5f7836345f7562756e747525323031382e30345f436f6d70696c6174696f6e4d6f64653d7761736d5f52756e4b696e643d626c617a6f725f7363656e6172696f735f52656772657373696f6e2f534f442532302d2532304d696e696d756d253230426c617a6f7225323054656d706c6174652532302d2532305075626c6973685f332e706e67)
![graph](https://camo.githubusercontent.com/49bd0bcd5b128e09dd83942cd954d6a9c3a8f2ef3d6fa16f6a1bc1bd7c9f9674/68747470733a2f2f707673636d6475706c6f61642e626c6f622e636f72652e77696e646f77732e6e65742f6175746f66696c657265706f72742f6175746f66696c657265706f7274732f30375f31375f323032312f726566732f68656164732f6d61696e5f7836345f7562756e747525323031382e30345f436f6d70696c6174696f6e4d6f64653d7761736d5f52756e4b696e643d626c617a6f725f7363656e6172696f735f52656772657373696f6e2f534f442532302d2532304d696e696d756d253230426c617a6f7225323054656d706c6174652532302d2532305075626c6973685f342e706e67)
![graph](https://camo.githubusercontent.com/b70b414831fdc8c1840e94a6f707afbaa5ff82a0f3e80421bdd58e9c9b9aad06/68747470733a2f2f707673636d6475706c6f61642e626c6f622e636f72652e77696e646f77732e6e65742f6175746f66696c657265706f72742f6175746f66696c657265706f7274732f30375f31375f323032312f726566732f68656164732f6d61696e5f7836345f7562756e747525323031382e30345f436f6d70696c6174696f6e4d6f64653d7761736d5f52756e4b696e643d626c617a6f725f7363656e6172696f735f52656772657373696f6e2f534f442532302d2532304d696e696d756d253230426c617a6f7225323054656d706c6174652532302d2532305075626c6973685f352e706e67)
![graph](https://camo.githubusercontent.com/1998a3e9d69422d6b6907a98083087e996f0fccd6c9f7d99d70576dfc7101467/68747470733a2f2f707673636d6475706c6f61642e626c6f622e636f72652e77696e646f77732e6e65742f6175746f66696c657265706f72742f6175746f66696c657265706f7274732f30375f31375f323032312f726566732f68656164732f6d61696e5f7836345f7562756e747525323031382e30345f436f6d70696c6174696f6e4d6f64653d7761736d5f52756e4b696e643d626c617a6f725f7363656e6172696f735f52656772657373696f6e2f534f442532302d2532304d696e696d756d253230426c617a6f7225323054656d706c6174652532302d2532305075626c6973685f362e706e67)
![graph](https://camo.githubusercontent.com/55b0a7fc399c868b2902b4fdcaf3ce17aed9141a5777d7effdc8ed3c8dd30989/68747470733a2f2f707673636d6475706c6f61642e626c6f622e636f72652e77696e646f77732e6e65742f6175746f66696c657265706f72742f6175746f66696c657265706f7274732f30375f31375f323032312f726566732f68656164732f6d61696e5f7836345f7562756e747525323031382e30345f436f6d70696c6174696f6e4d6f64653d7761736d5f52756e4b696e643d626c617a6f725f7363656e6172696f735f52656772657373696f6e2f534f442532302d2532304d696e696d756d253230426c617a6f7225323054656d706c6174652532302d2532305075626c6973685f372e706e67)
![graph](https://camo.githubusercontent.com/38afa5077c3793f4fe70c31f8956bd0e987a8a91eae1aaa584ab8f25a006c90a/68747470733a2f2f707673636d6475706c6f61642e626c6f622e636f72652e77696e646f77732e6e65742f6175746f66696c657265706f72742f6175746f66696c657265706f7274732f30375f31375f323032312f726566732f68656164732f6d61696e5f7836345f7562756e747525323031382e30345f436f6d70696c6174696f6e4d6f64653d7761736d5f52756e4b696e643d626c617a6f725f7363656e6172696f735f52656772657373696f6e2f534f442532302d2532304d696e696d756d253230426c617a6f7225323054656d706c6174652532302d2532305075626c6973685f382e706e67)
![graph](https://camo.githubusercontent.com/6f4904ca0d7e006f3144ff30f3e8b58d46eb2b1e05e6fab8077e8d7e9390a8c5/68747470733a2f2f707673636d6475706c6f61642e626c6f622e636f72652e77696e646f77732e6e65742f6175746f66696c657265706f72742f6175746f66696c657265706f7274732f30375f31375f323032312f726566732f68656164732f6d61696e5f7836345f7562756e747525323031382e30345f436f6d70696c6174696f6e4d6f64653d7761736d5f52756e4b696e643d626c617a6f725f7363656e6172696f735f52656772657373696f6e2f534f442532302d2532304d696e696d756d253230426c617a6f7225323054656d706c6174652532302d2532305075626c6973685f392e706e67)
![graph](https://camo.githubusercontent.com/989d1f205df63ec731080fa5326126984e8ae50a5179453bdaa62cbfdb4b0b04/68747470733a2f2f707673636d6475706c6f61642e626c6f622e636f72652e77696e646f77732e6e65742f6175746f66696c657265706f72742f6175746f66696c657265706f7274732f30375f31375f323032312f726566732f68656164732f6d61696e5f7836345f7562756e747525323031382e30345f436f6d70696c6174696f6e4d6f64653d7761736d5f52756e4b696e643d626c617a6f725f7363656e6172696f735f52656772657373696f6e2f534f442532302d2532304d696e696d756d253230426c617a6f7225323054656d706c6174652532302d2532305075626c6973685f31302e706e67)
Repro: git clone https://github.com/dotnet/performance.git python3 .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'SOD - Minimum Blazor Template - Publish*'Historical Data in Reporting System
The text was updated successfully, but these errors were encountered: