Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUIC] Do not call msquic in a lock #59345

Closed
ManickaP opened this issue Sep 20, 2021 · 1 comment · Fixed by #67037
Closed

[QUIC] Do not call msquic in a lock #59345

ManickaP opened this issue Sep 20, 2021 · 1 comment · Fixed by #67037
Assignees
Milestone

Comments

@ManickaP
Copy link
Member

ManickaP commented Sep 20, 2021

Check all places where we call msquic and make sure we're not doing that in a lock since it can cause a deadlock.
For example:


Add asserts before msquic calls that the lock is not taken, e.g.:

uint status = MsQuicApi.Api.StreamReceiveSetEnabledDelegate(_state.Handle, enabled: true);

@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.Net.Quic untriaged New issue has not been triaged by the area owner labels Sep 20, 2021
@ghost
Copy link

ghost commented Sep 20, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Check all places where we call msquic and make sure we're not doing that in a lock since it can cause a deadlock.
For example:


Author: ManickaP
Assignees: -
Labels:

untriaged, area-System.Net.Quic

Milestone: -

@karelz karelz added this to the 7.0.0 milestone Sep 21, 2021
@karelz karelz added bug and removed untriaged New issue has not been triaged by the area owner labels Sep 21, 2021
@rzikm rzikm assigned rzikm and unassigned CarnaViire Mar 23, 2022
rzikm added a commit to rzikm/dotnet-runtime that referenced this issue Mar 23, 2022
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Mar 23, 2022
rzikm added a commit that referenced this issue Mar 29, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Mar 29, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Apr 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants