-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use generic math in System.Numerics.Vectors test utils #60365
Comments
Tagging subscribers to this area: @dotnet/area-system-numerics Issue DetailsSee #60335 (comment), it could simplify the code a lot.
|
@akoeplinger Hi, I would like to work on the issue and I have already done some research. I have trouble with adding the System.Runtime.Experimental reference to the project so I could use the generic math. Could you give me a hint how to do that the right way? |
@SkiFoD, you should just need to add a reference to the <!-- it's a reference assembly, but the project system doesn't know that - include it during compilation, but don't publish it -->
<ProjectReference Include="$(LibrariesProjectRoot)System.Runtime.Experimental\ref\System.Runtime.Experimental.csproj" IncludeAssets="compile" Private="false" /> This is how its handle in the corresponding test project for |
@tannergooding Thank you! I have some more questions. Is it ok to wrap the Util.cs with pragmas that disables CA2252 or is there a better way to get rid of the warnings? |
You'll need to annotate the type with These will go away once we start stabilizing the feature and confirm it will no longer be preview in the corresponding .NET release. |
See #60335 (comment), it could simplify the code a lot.
The text was updated successfully, but these errors were encountered: