-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unexpected TimeSeriesLimitReached after HistogramLimitReached #60752
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
I think Line 305 in 565f3ee
|
I make PR for this issue(#61199) |
CC @noahfalk |
This is already fixed by the linked PR. Thanks to @itn3000 for helping with this issue. |
Description
Unexpected TimeSeriesLimitReached after HistogramLimitReached and trying to add more histogram instrument,
and no more Instrument can be added in session.
Reproduction Steps
MaxTimeSeries > MaxHistograms
(temporarily setMaxTimeSeries=3
,MaxHistograms=2
)System.Diagnostics.Metrics.Meter
Histogram.Record
3 times with different tag values(temporarily, "t1=1", "t1=2", "t1=3")Histogram.Record
with tag value which is same as last record(temporarily, "t1=3")sample program is following
https://gist.github.com/itn3000/9001546f1a0a9bcd53b7bc0ae4184bbd
Expected behavior
raise "HistogramLimitReached" only, no "TimeSeriesLimitReached".
and another Instrument like
Counter<T>
can be started to listen after "HistogramLimitReached".Actual behavior
raise "HistogramLimitReached" and "TimeSeriesLimitReached".
and no more Instrument can be started to listen after "TimeSeriesLimitReached"
Regression?
No response
Known Workarounds
Histogram.Record
which not listening(if it can)Configuration
Other information
I suspect around the "CheckTimeSeriesAllowed" and "CheckHistramAllowed"(currentTimeSeries is increased even if after reaching MaxHistograms?)
runtime/src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/AggregationManager.cs
Lines 305 to 307 in 565f3ee
The text was updated successfully, but these errors were encountered: