Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible typo: "This method is intended for compiler user..." #62248

Closed
JamesNK opened this issue Dec 1, 2021 · 4 comments · Fixed by #62982
Closed

Possible typo: "This method is intended for compiler user..." #62248

JamesNK opened this issue Dec 1, 2021 · 4 comments · Fixed by #62982
Labels
area-System.Runtime.CompilerServices documentation Documentation bug or enhancement, does not impact product or test code help wanted [up-for-grabs] Good issue for external contributors
Milestone
Future

Comments

@JamesNK
Copy link
Member

JamesNK commented Dec 1, 2021

For example:

runtime/src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/TaskAwaiter.cs

Line 81 in 57bfe47

/// <remarks>This method is intended for compiler user rather than use directly in code.</remarks>

Should this say "for compiler usage"? That makes more sense to me.

If it is a typo then it is replicated in quite a few places.
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Dec 1, 2021
@JamesNK
Copy link
Member Author

JamesNK commented Dec 1, 2021

cc @stephentoub

@stephentoub
Copy link
Member

Should this say "for compiler usage"?

It was intended to say "use" rather than "user".

@buyaa-n buyaa-n added documentation Documentation bug or enhancement, does not impact product or test code help wanted [up-for-grabs] Good issue for external contributors and removed untriaged New issue has not been triaged by the area owner labels Dec 8, 2021
@buyaa-n buyaa-n added this to the Future milestone Dec 8, 2021
@slask
Copy link
Contributor

slask commented Dec 18, 2021 •
edited
Loading

Hi. I want to start contributing to .net, can I pick this up? cc @stephentoub

slask added a commit to slask/runtime that referenced this issue Dec 18, 2021
@slask
Fixed typo in remarks section of OnCompleted
0ba62bb 
Fix dotnet#62248
@slask slask mentioned this issue Dec 18, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Dec 18, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Dec 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jan 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Runtime.CompilerServices documentation Documentation bug or enhancement, does not impact product or test code help wanted [up-for-grabs] Good issue for external contributors
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Fixed typo in remarks section of OnCompleted slask/runtime
5 participants
@JamesNK @stephentoub @slask @jeffschwMSFT @buyaa-n