[wasm] Missing support for building native libraries as part of tests

[radical]

[wasm] New interop DisabledRuntimeMarshalling* tests failing

Build, and Log:

Interop/DisabledRuntimeMarshalling/DisabledRuntimeMarshalling_NativeAssemblyDisabled/DisabledRuntimeMarshalling_NativeAssemblyDisabled.sh 
...
      System.DllNotFoundException: DisabledRuntimeMarshallingNative
         at DisabledRuntimeMarshalling.PInvokeAssemblyMarshallingDisabled.DelegatesFromExternalAssembly.StructWithDefaultNonBlittableFields_DoesNotMarshal()
         at Program.<Main>$(String[] args)
      Expected: 100
      Actual: 101
...

DisabledRuntimeMarshalling_Disabled_NativeTypeInAssembly/DisabledRuntimeMarshalling_Disabled_NativeTypeInAssembly.sh
DisabledRuntimeMarshalling_Disabled_NativeTypeInAssembly_ro/DisabledRuntimeMarshalling_Disabled_NativeTypeInAssembly_ro.sh [FAIL]
DisabledRuntimeMarshalling_Disabled_NativeAssemblyEnabled/DisabledRuntimeMarshalling_Disabled_NativeAssemblyEnabled.sh
DisabledRuntimeMarshalling_Disabled_NativeAssemblyDisabled/DisabledRuntimeMarshalling_Disabled_NativeAssemblyDisabled.sh

The test was added in #63320

[ghost]

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Build, and Log:

...
      System.DllNotFoundException: DisabledRuntimeMarshallingNative
         at DisabledRuntimeMarshalling.PInvokeAssemblyMarshallingDisabled.DelegatesFromExternalAssembly.StructWithDefaultNonBlittableFields_DoesNotMarshal()
         at Program.<Main>$(String[] args)
      Expected: 100
      Actual: 101
...

The test was added in #63320

Author:	radical
Assignees:	-
Labels:	arch-wasm, blocking-clean-ci
Milestone:	-

[jkoritzinsky]

This test fails for the same reason on Wasm as many of the other interop tests: We don’t have the test build configured to support native library building or references for any of the “mobile” platforms or wasm.

[danmoseley]

test was disabled, so removing 'blocking-clean-ci'

[radical]

update: I got the native code to compile for the runtime tests. Now, these need to be linked in to each of the test assemblies, which will need relinking dotnet.wasm, adding to the build time.

[radical]

I'm able to relink now, with some changes to WasmTestRunner.proj, which fails with:

/workspaces/runtime/artifacts/tests/coreclr/Browser.wasm.Release/Tests/Core_Root/build/WasmApp.Native.targets(286,5):
error : Parameter types of pinvoke callback method 'System.Boolean CheckStructWithShortAndBoolManaged(DisabledRuntimeMarshallingNative+StructWithShortAndBool, System.Int16, System.Boolean)' needs to be blittable. 
[/workspaces/runtime/artifacts/tests/coreclr/Browser.wasm.Release/Tests/Core_Root/wasm-test-runner/WasmTestRunner.proj]

[lewing]

@radical what is the status of this one?

[radical]

@radical what is the status of this one?

This is incomplete, and won't be finished for 8.0 .

[fanyang-mono]

This prevented a newly added test for nested struct with PInvoke from running with wasm. Furthermore, this issue appears to extend to all PInvoke tests on the WASM platform, serving as a significant obstacle in the comprehensive testing of PInvoke functionality for WASM.

[lewing]

@jeffschwMSFT @steveisok thoughts on where this should land?

[steveisok]

@jeffschwMSFT @steveisok thoughts on where this should land?

On balance, I think it should stay on your team. My reasoning is that the test infra is so specialized, you'll have to be involved regardless.