-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate assembly macros #64253
Comments
cc @directhex (regarding #62594 (comment)), for some reason the outerloop armv6 failure is caused by /pal/ variant
but not the nativeaot one:
(although both components are bulilding; maybe it's unreachable code 🤔) |
It would definitely be nice to deduplicate. My only concern is that we currently have zero testing for NativeAOT ARM64 (outside of just building it), so I would rather not make big changes to ARM64 files right now. ARM64 testing is on my TODO list for the coming weeks.
NativeAOT is only building on ARM64 and x64: runtime/src/coreclr/CMakeLists.txt Lines 137 to 142 in a5cf724
It might be buildable on ARM32, but this was scoped down to what we really need in the initial move from runtimelab. |
In CoreRT, we copied a few assembly macros from CoreCLR repo. Those macros were later modified in coreclr then in runtime repos. Now that NativeAOT and PAL code exist in the same repo, is it feasible to deduplicate that code?
cc @MichalStrehovsky, @jkotas, @janvorli
The text was updated successfully, but these errors were encountered: