Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHandler_SslProtocols_Test #64941

Closed
runfoapp bot opened this issue Feb 7, 2022 · 14 comments · Fixed by #65020
Closed

System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHandler_SslProtocols_Test #64941

runfoapp bot opened this issue Feb 7, 2022 · 14 comments · Fixed by #65020

Comments

@runfoapp
Copy link

runfoapp bot commented Feb 7, 2022

SocketsHttpHandler_HttpClientHandler_SslProtocols_Test are all failing. Example failure:

System.ComponentModel.Win32Exception : The client and server cannot communicate, because they do not possess a common algorithm.
      Stack Trace:
        /_/src/libraries/Common/src/Interop/Windows/SspiCli/SSPIWrapper.cs(138,0): at System.Net.SSPIWrapper.AcquireCredentialsHandle(ISSPIInterface secModule, String package, CredentialUse intent, SCH_CREDENTIALS* scc)
        /_/src/libraries/System.Net.Security/src/System/Net/Security/SslStreamPal.Windows.cs(590,0): at System.Net.Security.SslStreamPal.AcquireCredentialsHandle(CredentialUse credUsage, SCH_CREDENTIALS* secureCredential)
        /_/src/libraries/System.Net.Security/src/System/Net/Security/SslStreamPal.Windows.cs(292,0): at System.Net.Security.SslStreamPal.AcquireCredentialsHandleSchCredentials(SslStreamCertificateContext certificateContext, SslProtocols protocols, EncryptionPolicy policy, Boolean isServer)
        /_/src/libraries/System.Net.Security/src/System/Net/Security/SslStreamPal.Windows.cs(144,0): at System.Net.Security.SslStreamPal.AcquireCredentialsHandle(SslStreamCertificateContext certificateContext, SslProtocols protocols, EncryptionPolicy policy, Boolean isServer)
        /_/src/libraries/System.Net.Security/src/System/Net/Security/SecureChannel.cs(719,0): at System.Net.Security.SecureChannel.AcquireServerCredentials(Byte[]& thumbPrint)
        /_/src/libraries/System.Net.Security/src/System/Net/Security/SecureChannel.cs(788,0): at System.Net.Security.SecureChannel.GenerateToken(ReadOnlySpan`1 inputBuffer, Byte[]& output)
        /_/src/libraries/System.Net.Security/src/System/Net/Security/SecureChannel.cs(751,0): at System.Net.Security.SecureChannel.NextMessage(ReadOnlySpan`1 incomingBuffer)
        /_/src/libraries/System.Net.Security/src/System/Net/Security/SslStream.Implementation.cs(558,0): at System.Net.Security.SslStream.ProcessBlob(Int32 frameSize)
        /_/src/libraries/System.Net.Security/src/System/Net/Security/SslStream.Implementation.cs(524,0): at System.Net.Security.SslStream.ReceiveBlobAsync[TIOAdapter](TIOAdapter adapter)
        /_/src/libraries/System.Net.Security/src/System/Net/Security/SslStream.Implementation.cs(369,0): at System.Net.Security.SslStream.ForceAuthenticationAsync[TIOAdapter](TIOAdapter adapter, Boolean receiveFirst, Byte[] reAuthenticationData, Boolean isApm)
        /_/src/libraries/Common/tests/System/Net/Http/LoopbackServer.cs(474,0): at System.Net.Test.Common.LoopbackServer.Connection.CreateAsync(SocketWrapper socket, Stream stream, Options httpOptions)
        /_/src/libraries/Common/tests/System/Net/Http/LoopbackServer.cs(155,0): at System.Net.Test.Common.LoopbackServer.EstablishConnectionAsync()
        /_/src/libraries/Common/tests/System/Net/Http/LoopbackServer.cs(159,0): at System.Net.Test.Common.LoopbackServer.AcceptConnectionAsync(Func`2 funcAsync)
        /_/src/libraries/Common/tests/System/Net/Http/LoopbackServer.cs(199,0): at System.Net.Test.Common.LoopbackServer.AcceptConnectionSendResponseAndCloseAsync(HttpStatusCode statusCode, String additionalHeaders, String content)
        /_/src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.SslProtocols.cs(295,0): at System.Net.Http.Functional.Tests.HttpClientHandler_SslProtocols_Test.<>c__DisplayClass12_0.<<GetAsync_AllowedClientSslVersionDiffersFromServer_ThrowsException>b__0>d.MoveNext()
        --- End of stack trace from previous location ---
        /_/src/libraries/Common/tests/System/Net/Http/LoopbackServer.cs(103,0): at System.Net.Test.Common.LoopbackServer.CreateServerAsync(Func`2 funcAsync, Options options)
        /_/src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.SslProtocols.cs(289,0): at 

Runfo Tracking Issue: System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHandler_SslProtocols_Test

Build Definition Kind Run Name Console Core Dump Test Results Run Client
1599891 runtime-extra-platforms PR 64330 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1599891 runtime-extra-platforms PR 64330 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1599891 runtime-extra-platforms PR 64330 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1599891 runtime-extra-platforms PR 64330 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1599891 runtime-extra-platforms PR 64330 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1599891 runtime-extra-platforms PR 64330 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1599818 runtime-extra-platforms PR 64567 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1599818 runtime-extra-platforms PR 64567 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1599818 runtime-extra-platforms PR 64567 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1599818 runtime-extra-platforms PR 64567 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1599818 runtime-extra-platforms PR 64567 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1599818 runtime-extra-platforms PR 64567 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1599183 runtime-extra-platforms Rolling net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1599183 runtime-extra-platforms Rolling net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1599183 runtime-extra-platforms Rolling net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1599183 runtime-extra-platforms Rolling net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1599183 runtime-extra-platforms Rolling net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1599183 runtime-extra-platforms Rolling net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1599120 runtime-extra-platforms PR 64330 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1599120 runtime-extra-platforms PR 64330 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1599120 runtime-extra-platforms PR 64330 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1599120 runtime-extra-platforms PR 64330 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1599120 runtime-extra-platforms PR 64330 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1599120 runtime-extra-platforms PR 64330 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598986 runtime-extra-platforms PR 64452 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598986 runtime-extra-platforms PR 64452 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598986 runtime-extra-platforms PR 64452 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598986 runtime-extra-platforms PR 64452 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598986 runtime-extra-platforms PR 64452 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598986 runtime-extra-platforms PR 64452 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598876 runtime-extra-platforms PR 60905 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598876 runtime-extra-platforms PR 60905 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598876 runtime-extra-platforms PR 60905 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598876 runtime-extra-platforms PR 60905 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598876 runtime-extra-platforms PR 60905 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598876 runtime-extra-platforms PR 60905 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598876 runtime-extra-platforms PR 60905 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598876 runtime-extra-platforms PR 60905 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598876 runtime-extra-platforms PR 60905 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598876 runtime-extra-platforms PR 60905 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598876 runtime-extra-platforms PR 60905 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598876 runtime-extra-platforms PR 60905 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598876 runtime-extra-platforms PR 60905 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598876 runtime-extra-platforms PR 60905 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598876 runtime-extra-platforms PR 60905 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598876 runtime-extra-platforms PR 60905 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598698 runtime-extra-platforms PR 64923 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598698 runtime-extra-platforms PR 64923 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598698 runtime-extra-platforms PR 64923 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598698 runtime-extra-platforms PR 64923 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598698 runtime-extra-platforms PR 64923 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598698 runtime-extra-platforms PR 64923 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598596 runtime-extra-platforms PR 63546 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598596 runtime-extra-platforms PR 63546 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598596 runtime-extra-platforms PR 63546 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598596 runtime-extra-platforms PR 63546 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598596 runtime-extra-platforms PR 63546 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598596 runtime-extra-platforms PR 63546 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598596 runtime-extra-platforms PR 63546 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598596 runtime-extra-platforms PR 63546 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598596 runtime-extra-platforms PR 63546 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598596 runtime-extra-platforms PR 63546 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598596 runtime-extra-platforms PR 63546 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598596 runtime-extra-platforms PR 63546 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598596 runtime-extra-platforms PR 63546 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598596 runtime-extra-platforms PR 63546 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598596 runtime-extra-platforms PR 63546 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598596 runtime-extra-platforms PR 63546 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598024 runtime-extra-platforms PR 64830 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598024 runtime-extra-platforms PR 64830 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598024 runtime-extra-platforms PR 64830 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598024 runtime-extra-platforms PR 64830 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598024 runtime-extra-platforms PR 64830 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598024 runtime-extra-platforms PR 64830 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598024 runtime-extra-platforms PR 64830 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598024 runtime-extra-platforms PR 64830 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598024 runtime-extra-platforms PR 64830 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598024 runtime-extra-platforms PR 64830 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598024 runtime-extra-platforms PR 64830 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598024 runtime-extra-platforms PR 64830 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598024 runtime-extra-platforms PR 64830 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598024 runtime-extra-platforms PR 64830 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598024 runtime-extra-platforms PR 64830 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1598024 runtime-extra-platforms PR 64830 net7.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1597924 runtime-extra-platforms PR 64330 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1597924 runtime-extra-platforms PR 64330 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1597924 runtime-extra-platforms PR 64330 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1597924 runtime-extra-platforms PR 64330 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1597924 runtime-extra-platforms PR 64330 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1597924 runtime-extra-platforms PR 64330 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1597924 runtime-extra-platforms PR 64330 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1597924 runtime-extra-platforms PR 64330 net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1597902 runtime-extra-platforms Rolling net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1597902 runtime-extra-platforms Rolling net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1597902 runtime-extra-platforms Rolling net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1597902 runtime-extra-platforms Rolling net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1597902 runtime-extra-platforms Rolling net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1597902 runtime-extra-platforms Rolling net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1597902 runtime-extra-platforms Rolling net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py
1597902 runtime-extra-platforms Rolling net7.0-windows-Release-x64-CoreCLR_release-Windows.Amd64.Server2022.Open console.log runclient.py

Displaying 100 of 212 results

Build Result Summary

Day Hit Count Week Hit Count Month Hit Count
8 24 24
@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.Net.Http untriaged New issue has not been triaged by the area owner labels Feb 7, 2022
@ghost
Copy link

ghost commented Feb 7, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Runfo Creating Tracking Issue (data being generated)

Author: runfoapp[bot]
Assignees: -
Labels:

area-System.Net.Http, untriaged

Milestone: -

@elinor-fung elinor-fung changed the title System.Net.Http.Functional.Tests.PlatformHandler_HttpClientHandler_SslProtocols_Test System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHandler_SslProtocols_Test Feb 7, 2022
@elinor-fung
Copy link
Member

Seems like this started happening only on Server2022. The queues were moved to Server2022 with #64827 and #64919.

@dotnet/ncl is there something about Server2022 that needs a change in the product or tests to work properly?

@wfurt
Copy link
Member

wfurt commented Feb 7, 2022

I don't know how the servers are configured. This may need #64923 left out from #64919.
cc: @safern

@wfurt
Copy link
Member

wfurt commented Feb 8, 2022

It seems like the Helix machine has Tls 1.0 and 1.1 explicitly disabled. #64923 will be definitely needed. Makes me wonder why #64919 did not see it.

https://dev.azure.com/dnceng/public/_build/results?buildId=1597463&view=logs&jobId=55b384d0-d6b0-5894-fd8a-d754d713246e&j=55b384d0-d6b0-5894-fd8a-d754d713246e&t=8dcacd81-cb5e-5ac9-93e5-c3f19b19e19b

does not seems to have any 2022 entries unless I missed something.

Related to https://github.com/dotnet/core-eng/issues/15394

cc: @MattGal

@MattGal
Copy link
Member

MattGal commented Feb 8, 2022

It seems like the Helix machine has Tls 1.0 and 1.1 explicitly disabled. #64923 will be definitely needed. Makes me wonder why #64919 did not see it.

https://dev.azure.com/dnceng/public/_build/results?buildId=1597463&view=logs&jobId=55b384d0-d6b0-5894-fd8a-d754d713246e&j=55b384d0-d6b0-5894-fd8a-d754d713246e&t=8dcacd81-cb5e-5ac9-93e5-c3f19b19e19b

does not seems to have any 2022 entries unless I missed something.

Related to dotnet/core-eng#15394

cc: @MattGal

Well that's odd. While it is indeed related to https://github.com/dotnet/core-eng/issues/15394, I've received exception to not make any changes to test machines and none have been made. It may be a "secure-by-default" thing on newer Windows SKUs... if you can provide the correlation id of a run with problems or even better the Queue id that's always helpful to start with. Reaching out on Teams to get more info.

@wfurt
Copy link
Member

wfurt commented Feb 8, 2022

image

This is Fromm machine running helix-repro subscription.
While that is not ideal, #64923 should make the tests pass (e.g. skip as needed)

@MattGal
Copy link
Member

MattGal commented Feb 8, 2022

This is Fromm machine running helix-repro subscription.

Unfortunately since I'm not you I can't tell what image you're using. If you're asking us to change this it does represent a change from previous but I'll also need to know what image(s) you think should be this way.

@safern
Copy link
Member

safern commented Feb 8, 2022

Makes me wonder why #64919 did not see it.

I believe is because I didn't run the extra-platforms-pipeline 🤦

@elinor-fung
Copy link
Member

Some of the tests in the most recent rolling build - which has #64923 - are still failing the same way. Maybe there is some more environment detection that needs to be handled?

@elinor-fung
Copy link
Member

Or maybe some tests need to be updated to use the platform detection checks? For example

  • GetAsync_AllowedClientSslVersionDiffersFromServer_ThrowsException: still failing
    • I don't see a support check
  • GetAsync_AllowedSSLVersion_Succeeds: no longer failing
    • uses SslProtocolSupport.SupportedSslProtocols

@wfurt
Copy link
Member

wfurt commented Feb 8, 2022

I did not see HTTP failures in the posted link.

@wfurt
Copy link
Member

wfurt commented Feb 8, 2022

but looking at the test: yes, it should check if given versions are supported instead assuming it.

@elinor-fung
Copy link
Member

I did not see HTTP failures in the posted link.

Apparently the failures didn't show in the summary/timeline (no idea why). But the tests tab shows failures in HTTP, Security, and Quic - direct link to one of the failing test results: https://dev.azure.com/dnceng/public/_build/results?buildId=1599183&view=ms.vss-test-web.build-test-results-tab&runId=44675088&resultId=189644

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Feb 8, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Feb 9, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Mar 11, 2022
@karelz karelz added this to the 6.0.x milestone Apr 8, 2022
@karelz
Copy link
Member

karelz commented Apr 8, 2022

Fixed in 7.0 (main) in PR #65020 and in 6.0.3 in PR #65046.

@karelz karelz removed the untriaged New issue has not been triaged by the area owner label Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants