Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Android to r23b image #64567

Merged
merged 10 commits into from
Feb 8, 2022
Merged

Update Android to r23b image #64567

merged 10 commits into from
Feb 8, 2022

Conversation

directhex
Copy link
Contributor

Let's give this a full CI run, see if anything broke

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned directhex Jan 31, 2022
@dotnet dotnet deleted a comment from azure-pipelines bot Feb 1, 2022
@dotnet dotnet deleted a comment from azure-pipelines bot Feb 1, 2022
@directhex
Copy link
Contributor Author

Yes, everything broke, GNU as is gone

@dotnet dotnet deleted a comment from azure-pipelines bot Feb 2, 2022
@dotnet dotnet deleted a comment from azure-pipelines bot Feb 3, 2022
This was referenced Feb 3, 2022
Open
Closed
Closed
@ghost
Copy link

ghost commented Feb 4, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Let's give this a full CI run, see if anything broke

Author: directhex
Assignees: directhex
Labels:

os-android, area-Infrastructure
Milestone: -

@dotnet dotnet deleted a comment from azure-pipelines bot Feb 7, 2022
steveisok
steveisok approved these changes Feb 7, 2022
View reviewed changes
Copy link
Member

@steveisok steveisok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Android build looks good

This was referenced Feb 7, 2022
Closed
Closed
Closed
This was referenced Feb 7, 2022
Closed
Closed
Closed
Closed
Closed
Closed
@directhex
Copy link
Contributor Author

@steveisok is it? there are a whole lot of test failures - are those failures new or expected?

@steveisok
Copy link
Member

Details

All look like known issues to me. The ping one in particular was fixed in main yesterday.

@steveisok
Copy link
Member

The runtime tests one should be fixed by #64950

I'd suggest pulling in main and trying again.

@directhex
Copy link
Contributor Author

/azp run runtime-extra-platforms

@dotnet dotnet deleted a comment from azure-pipelines bot Feb 8, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@directhex
Copy link
Contributor Author

I think Android failures are a bad CI machine. I've pinged first responders on Teams

@directhex directhex merged commit 97fc0a4 into dotnet:main Feb 8, 2022
This was referenced Feb 8, 2022
Closed
Closed
akoeplinger added a commit to akoeplinger/runtime that referenced this pull request Feb 11, 2022
@akoeplinger
Add check for Android NDK 23 to AndroidAppBuilder
c1c7386 
We recently bumped the Android NDK in dotnet#64567, add a check to CMakeLists-android.txt to validate it.
@akoeplinger akoeplinger mentioned this pull request Feb 11, 2022
Merged
akoeplinger added a commit that referenced this pull request Feb 11, 2022
@akoeplinger
Add check for Android NDK 23 to AndroidAppBuilder (#65197)
10aaeef 
We recently bumped the Android NDK in #64567, add a check to CMakeLists-android.txt to validate it.
@ghost ghost locked as resolved and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@steveisok steveisok steveisok approved these changes

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

Assignees

@directhex directhex

Labels
area-Infrastructure os-android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@directhex @steveisok @jeffhandley