Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runtime tests on Android #64950

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

akoeplinger
Copy link
Member

In #64744 I changed the name of the env variable used to store the test results directoy but I didn't notice that the runtime tests don't use the same runner.

Fixes #64920

In dotnet#64744 I changed the name of the env variable used to store the test results directoy but I didn't notice that the runtime tests don't use the same runner.

Fixes dotnet#64920
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@akoeplinger
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@elinor-fung elinor-fung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@elinor-fung elinor-fung merged commit af42c8e into dotnet:main Feb 8, 2022
@akoeplinger akoeplinger deleted the fix-android-runtimetests branch February 8, 2022 13:48
Copy link
Member

@fanyang-mono fanyang-mono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! There is work being done to migrate runtime tests to become more like how library tests run, so they run faster.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

range_r work item: fail: Non-success instrumentation exit code: 101, expected: 0
3 participants