Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strings.resx is embedded twice into the assembly for projects that set EnableDefaultItems to true #68218

Closed
ViktorHofer opened this issue Apr 19, 2022 · 1 comment · Fixed by #68220
Closed

Strings.resx is embedded twice into the assembly for projects that set EnableDefaultItems to true #68218

ViktorHofer opened this issue Apr 19, 2022 · 1 comment · Fixed by #68220
Assignees
@ViktorHofer
Labels
area-Infrastructure-libraries bug
Milestone
7.0.0

Comments

@ViktorHofer
Copy link
Member

See title. That's because of the glob that includes all .resx files under the project tree when EnableDefaultItems is set to true and resources.targets then importing it again.

cc @eerhardt
@dotnet-issue-labeler dotnet-issue-labeler bot added area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner labels Apr 19, 2022
@ghost
Copy link

ghost commented Apr 19, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

See title. That's because of the glob that includes all .resx files under the project tree when EnableDefaultItems is set to true and resources.targets then importing it again.

cc @eerhardt

Author: ViktorHofer
Assignees: -
Labels:

area-Infrastructure-libraries, untriaged
Milestone: -

@ViktorHofer ViktorHofer self-assigned this Apr 19, 2022
ViktorHofer added a commit that referenced this issue Apr 19, 2022
@ViktorHofer
Avoid duplicate Strings.resx import & code-cleanup
c263536 
Fixes #68218

Makes assemblies with String.resx resources smaller by avoiding the duplicate resources.
@ViktorHofer ViktorHofer mentioned this issue Apr 19, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Apr 19, 2022
@ViktorHofer ViktorHofer removed the untriaged New issue has not been triaged by the area owner label Apr 19, 2022
@ViktorHofer ViktorHofer added this to the 7.0.0 milestone Apr 19, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Apr 20, 2022
ViktorHofer added a commit that referenced this issue Apr 20, 2022
@ViktorHofer
Avoid duplicate Strings.resx import & code-cleanup (#68220)
30a5b1f 
* Avoid duplicate Strings.resx import & code-cleanup

Fixes #68218

Makes assemblies with String.resx resources smaller by avoiding the duplicate resources.
directhex pushed a commit to directhex/runtime that referenced this issue Apr 21, 2022
@ViktorHofer @directhex
Avoid duplicate Strings.resx import & code-cleanup (dotnet#68220)
5ca4240 
* Avoid duplicate Strings.resx import & code-cleanup

Fixes dotnet#68218

Makes assemblies with String.resx resources smaller by avoiding the duplicate resources.
@ghost ghost locked as resolved and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ViktorHofer ViktorHofer

Labels
area-Infrastructure-libraries bug
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Avoid duplicate Strings.resx import & code-cleanup dotnet/runtime
1 participant
@ViktorHofer