System.Diagnostics.Tests.InstanceDataTests.InstanceDataCollectionCollection_CopyTo failing in CI

[ViktorHofer]

Configuration: net7.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server2022.ES.Open

Build: https://dev.azure.com/dnceng/public/_build/results?buildId=1721549

    System.Diagnostics.Tests.InstanceDataTests.InstanceDataCollectionCollection_CopyTo [FAIL]
      Assert.True() Failure
      Expected: True
      Actual:   False
      Stack Trace:
        /_/src/libraries/System.Diagnostics.PerformanceCounter/tests/InstanceDataTests.cs(122,0): at System.Diagnostics.Tests.InstanceDataTests.InstanceDataCollectionCollection_CopyTo()
           at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
        /_/src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.CoreCLR.cs(379,0): at System.Reflection.RuntimeMethodInfo.InvokeNonEmitUnsafe(Object obj, IntPtr* arguments, Span`1 argsForTemporaryMonoSupport, BindingFlags invokeAttr)

Informaci�n: Los contadores de rendimiento se instalaron correctamente en C:\h\w\B1040971\t\h2gyudok.4kw\provider.man.    System.Diagnostics.Tests.PerformanceDataTests.PerformanceCounter_PerformanceData [SKIP]
      Condition(s) not met: "IsRunnableEnvironment"

Informaci�n: Desinstalaci�n correcta de los contadores de rendimiento del archivo XML de definici�n de contadores C:\h\w\B1040971\t\h2gyudok.4kw\provider.man.  Finished:    System.Diagnostics.PerformanceCounter.Tests
=== TEST EXECUTION SUMMARY ===
   System.Diagnostics.PerformanceCounter.Tests  Total: 90, Errors: 0, Failed: 1, Skipped: 1, Time: 30,024s

Runfo Tracking Issue: system.diagnostics.tests.instancedatatests.instancedatacollectioncollection_copyto

Build	Definition	Kind	Run Name	Console	Core Dump	Test Results	Run Client
1799703	runtime	PR 70062	net7.0-windows-Release-x64-CoreCLR_checked-Windows.10.Amd64.Open	console.log			runclient.py
1757267	runtime	PR 68993	net7.0-windows-Debug-x64-CoreCLR_release-Windows.11.Amd64.ClientPre.Open	console.log			runclient.py
1744574	runtime	Rolling	net7.0-windows-Release-x64-CoreCLR_release-Windows.11.Amd64.ClientPre.Open	console.log			runclient.py
1725393	runtime	PR 67883	net48-windows-Release-x86-Windows.10.Amd64.Client21H1.Open	console.log			runclient.py

Build Result Summary

Day Hit Count	Week Hit Count	Month Hit Count
0	1	2

[dotnet-issue-labeler]

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[ghost]

Tagging subscribers to this area: @dotnet/area-system-diagnostics-performancecounter
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Configuration: net7.0-windows-Release-x86-CoreCLR_release-Windows.10.Amd64.Server2022.ES.Open

Build: https://dev.azure.com/dnceng/public/_build/results?buildId=1721549

    System.Diagnostics.Tests.InstanceDataTests.InstanceDataCollectionCollection_CopyTo [FAIL]
      Assert.True() Failure
      Expected: True
      Actual:   False
      Stack Trace:
        /_/src/libraries/System.Diagnostics.PerformanceCounter/tests/InstanceDataTests.cs(122,0): at System.Diagnostics.Tests.InstanceDataTests.InstanceDataCollectionCollection_CopyTo()
           at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
        /_/src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.CoreCLR.cs(379,0): at System.Reflection.RuntimeMethodInfo.InvokeNonEmitUnsafe(Object obj, IntPtr* arguments, Span`1 argsForTemporaryMonoSupport, BindingFlags invokeAttr)

Informaci�n: Los contadores de rendimiento se instalaron correctamente en C:\h\w\B1040971\t\h2gyudok.4kw\provider.man.    System.Diagnostics.Tests.PerformanceDataTests.PerformanceCounter_PerformanceData [SKIP]
      Condition(s) not met: "IsRunnableEnvironment"

Informaci�n: Desinstalaci�n correcta de los contadores de rendimiento del archivo XML de definici�n de contadores C:\h\w\B1040971\t\h2gyudok.4kw\provider.man.  Finished:    System.Diagnostics.PerformanceCounter.Tests
=== TEST EXECUTION SUMMARY ===
   System.Diagnostics.PerformanceCounter.Tests  Total: 90, Errors: 0, Failed: 1, Skipped: 1, Time: 30,024s

Author:	ViktorHofer
Assignees:	-
Labels:	untriaged, area-System.Diagnostics.PerformanceCounter
Milestone:	-

[danmoseley]

we already have retries here, but evidently those were successful or not needed as there would have been an exception. So pcc.ReadCategory()) gave us 0 values.

        [Fact]
        public static void InstanceDataCollectionCollection_CopyTo()
        {
            InstanceDataCollectionCollection idcc = GetInstanceDataCollectionCollection();

            InstanceDataCollection[] idc = new InstanceDataCollection[idcc.Values.Count];
            idcc.CopyTo(idc, 0);
            Assert.True(idc.Length > 0);
        }

        public static InstanceDataCollectionCollection GetInstanceDataCollectionCollection()
        {
            PerformanceCounterCategory pcc =  Helpers.RetryOnAllPlatforms(() => new PerformanceCounterCategory("Processor"));
            return Helpers.RetryOnAllPlatforms(() => pcc.ReadCategory());
        }

we should update to retry if there were 0 values. basically add an optional retryWhen delegate to RetryOnAllPlatforms that just passes through to the same named parameter on RetryHelper.Execute. (Tweak if there are other tests that do expect zero values)

[danmoseley]

#60933 is similar: retries needed on the ctor in those cases.

[smasher164]

we should update to retry if there were 0 values. basically add an optional retryWhen delegate to RetryOnAllPlatforms that just passes through to the same named parameter on RetryHelper.Execute. (Tweak if there are other tests that do expect zero values)

@danmoseley Since retryWhen is only invoked when an exception is thrown, it sounds like the solution should be to

return Helpers.RetryOnAllPlatforms(() =>
{
    var idcc = pcc.ReadCategory();
    if (idcc.Values.Count == 0)
    {
        throw new ZeroDataException;
    }
    return idcc;
});

In that case, passing a retryWhen delegate through wouldn't be needed, since the exception gets caught by the default retryWhen delegate.

Edit: I put up a PR with this approach. Please let me know if there's I'm missing here.

[danmoseley]

@smasher164 sounds reasonable.