Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetAssemblyName() test scenario should skip for singlefile and aot form factors #68980

Closed
LakshanF opened this issue May 6, 2022 · 3 comments · Fixed by #76591
Closed

GetAssemblyName() test scenario should skip for singlefile and aot form factors #68980

LakshanF opened this issue May 6, 2022 · 3 comments · Fixed by #76591
Assignees
@VSadov
Labels
area-System.Reflection
Milestone
8.0.0

Comments

@LakshanF
Copy link
Contributor

LakshanF commented May 6, 2022

Tracking FB for #67575 so as to merge the PR
@LakshanF LakshanF self-assigned this May 6, 2022
@LakshanF LakshanF mentioned this issue May 6, 2022
Merged
@ghost ghost added the untriaged New issue has not been triaged by the area owner label May 6, 2022
@ghost
Copy link

ghost commented May 6, 2022

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

Tracking FB for #67575 so as to merge the PR

Author: LakshanF
Assignees: LakshanF
Labels:

area-System.Reflection
Milestone: -

@buyaa-n buyaa-n added this to the 7.0.0 milestone May 11, 2022
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label May 11, 2022
@LakshanF LakshanF assigned VSadov and unassigned LakshanF May 12, 2022
@buyaa-n buyaa-n modified the milestones: 7.0.0, 8.0.0 Jul 13, 2022
@buyaa-n
Copy link
Contributor

buyaa-n commented Sep 26, 2022

@LakshanF isn't it done? Seems all related PRs merged

@jkotas
Copy link
Member

jkotas commented Sep 26, 2022

It is about addressing this feedback: #67575 (comment) . Not done yet.

jkotas added a commit to jkotas/runtime that referenced this issue Oct 4, 2022
@jkotas
Use more accurate condition to suppress GetAssemblyName test
b22d687 
Fixes dotnet#68980
@jkotas jkotas mentioned this issue Oct 4, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Oct 4, 2022
jkotas added a commit that referenced this issue Oct 4, 2022
@jkotas
Use more accurate condition to suppress GetAssemblyName test (#76591)
782aa15 
Fixes #68980
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Oct 4, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@VSadov VSadov

Labels
area-System.Reflection
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Use more accurate condition to suppress GetAssemblyName test jkotas/runtime
4 participants
@jkotas @LakshanF @VSadov @buyaa-n